mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00

When Inflights to a particular node is full, i.e. MaxInflightMsgs for the append messages flow is saturated, it is still necessary to continue sending MsgApp to ensure progress. Currently this is achieved by "forgetting" the first in-flight message in the window, which frees up quota for one new MsgApp. This new message is constructed in such a way that it potentially has multiple entries, or a large entry. The effect of this is that the in-flight limitations can be exceeded arbitrarily, for as long as the flow to this node continues being saturated. In particular, if a follower is stuck, the leader will keep sending entries to it. This commit makes the MsgApp empty when Inflights is saturated, and prevents the described leakage of Entries to slow followers. Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
153 lines
4.8 KiB
Go
153 lines
4.8 KiB
Go
// Copyright 2015 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package raft
|
|
|
|
import (
|
|
"testing"
|
|
|
|
pb "go.etcd.io/etcd/raft/v3/raftpb"
|
|
)
|
|
|
|
// TestMsgAppFlowControlFull ensures:
|
|
// 1. msgApp can fill the sending window until full
|
|
// 2. when the window is full, no more msgApp can be sent.
|
|
|
|
func TestMsgAppFlowControlFull(t *testing.T) {
|
|
r := newTestRaft(1, 5, 1, newTestMemoryStorage(withPeers(1, 2)))
|
|
r.becomeCandidate()
|
|
r.becomeLeader()
|
|
|
|
pr2 := r.prs.Progress[2]
|
|
// force the progress to be in replicate state
|
|
pr2.BecomeReplicate()
|
|
// fill in the inflights window
|
|
for i := 0; i < r.prs.MaxInflight; i++ {
|
|
r.Step(pb.Message{From: 1, To: 1, Type: pb.MsgProp, Entries: []pb.Entry{{Data: []byte("somedata")}}})
|
|
ms := r.readMessages()
|
|
if len(ms) != 1 || ms[0].Type != pb.MsgApp {
|
|
t.Fatalf("#%d: len(ms) = %d, want 1 MsgApp", i, len(ms))
|
|
}
|
|
}
|
|
|
|
// ensure 1
|
|
if !pr2.IsPaused() {
|
|
t.Fatal("paused = false, want true")
|
|
}
|
|
|
|
// ensure 2
|
|
for i := 0; i < 10; i++ {
|
|
r.Step(pb.Message{From: 1, To: 1, Type: pb.MsgProp, Entries: []pb.Entry{{Data: []byte("somedata")}}})
|
|
ms := r.readMessages()
|
|
if len(ms) != 0 {
|
|
t.Fatalf("#%d: len(ms) = %d, want 0", i, len(ms))
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestMsgAppFlowControlMoveForward ensures msgAppResp can move
|
|
// forward the sending window correctly:
|
|
// 1. valid msgAppResp.index moves the windows to pass all smaller or equal index.
|
|
// 2. out-of-dated msgAppResp has no effect on the sliding window.
|
|
func TestMsgAppFlowControlMoveForward(t *testing.T) {
|
|
r := newTestRaft(1, 5, 1, newTestMemoryStorage(withPeers(1, 2)))
|
|
r.becomeCandidate()
|
|
r.becomeLeader()
|
|
|
|
pr2 := r.prs.Progress[2]
|
|
// force the progress to be in replicate state
|
|
pr2.BecomeReplicate()
|
|
// fill in the inflights window
|
|
for i := 0; i < r.prs.MaxInflight; i++ {
|
|
r.Step(pb.Message{From: 1, To: 1, Type: pb.MsgProp, Entries: []pb.Entry{{Data: []byte("somedata")}}})
|
|
r.readMessages()
|
|
}
|
|
|
|
// 1 is noop, 2 is the first proposal we just sent.
|
|
// so we start with 2.
|
|
for tt := 2; tt < r.prs.MaxInflight; tt++ {
|
|
// move forward the window
|
|
r.Step(pb.Message{From: 2, To: 1, Type: pb.MsgAppResp, Index: uint64(tt)})
|
|
r.readMessages()
|
|
|
|
// fill in the inflights window again
|
|
r.Step(pb.Message{From: 1, To: 1, Type: pb.MsgProp, Entries: []pb.Entry{{Data: []byte("somedata")}}})
|
|
ms := r.readMessages()
|
|
if len(ms) != 1 || ms[0].Type != pb.MsgApp {
|
|
t.Fatalf("#%d: len(ms) = %d, want 1 MsgApp", tt, len(ms))
|
|
}
|
|
|
|
// ensure 1
|
|
if !pr2.IsPaused() {
|
|
t.Fatalf("#%d: paused = false, want true", tt)
|
|
}
|
|
|
|
// ensure 2
|
|
for i := 0; i < tt; i++ {
|
|
r.Step(pb.Message{From: 2, To: 1, Type: pb.MsgAppResp, Index: uint64(i)})
|
|
if !pr2.IsPaused() {
|
|
t.Fatalf("#%d.%d: paused = false, want true", tt, i)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestMsgAppFlowControlRecvHeartbeat ensures a heartbeat response
|
|
// frees one slot if the window is full.
|
|
func TestMsgAppFlowControlRecvHeartbeat(t *testing.T) {
|
|
r := newTestRaft(1, 5, 1, newTestMemoryStorage(withPeers(1, 2)))
|
|
r.becomeCandidate()
|
|
r.becomeLeader()
|
|
|
|
pr2 := r.prs.Progress[2]
|
|
// force the progress to be in replicate state
|
|
pr2.BecomeReplicate()
|
|
// fill in the inflights window
|
|
for i := 0; i < r.prs.MaxInflight; i++ {
|
|
r.Step(pb.Message{From: 1, To: 1, Type: pb.MsgProp, Entries: []pb.Entry{{Data: []byte("somedata")}}})
|
|
r.readMessages()
|
|
}
|
|
|
|
for tt := 1; tt < 5; tt++ {
|
|
// recv tt msgHeartbeatResp and expect one free slot
|
|
for i := 0; i < tt; i++ {
|
|
if !pr2.IsPaused() {
|
|
t.Fatalf("#%d.%d: paused = false, want true", tt, i)
|
|
}
|
|
// Unpauses the progress, sends an empty MsgApp, and pauses it again.
|
|
r.Step(pb.Message{From: 2, To: 1, Type: pb.MsgHeartbeatResp})
|
|
ms := r.readMessages()
|
|
if len(ms) != 1 || ms[0].Type != pb.MsgApp || len(ms[0].Entries) != 0 {
|
|
t.Fatalf("#%d.%d: len(ms) == %d, want 1 empty MsgApp", tt, i, len(ms))
|
|
}
|
|
}
|
|
|
|
// No more appends are sent if there are no heartbeats.
|
|
for i := 0; i < 10; i++ {
|
|
if !pr2.IsPaused() {
|
|
t.Fatalf("#%d.%d: paused = false, want true", tt, i)
|
|
}
|
|
r.Step(pb.Message{From: 1, To: 1, Type: pb.MsgProp, Entries: []pb.Entry{{Data: []byte("somedata")}}})
|
|
ms := r.readMessages()
|
|
if len(ms) != 0 {
|
|
t.Fatalf("#%d.%d: len(ms) = %d, want 0", tt, i, len(ms))
|
|
}
|
|
}
|
|
|
|
// clear all pending messages.
|
|
r.Step(pb.Message{From: 2, To: 1, Type: pb.MsgHeartbeatResp})
|
|
r.readMessages()
|
|
}
|
|
}
|