mirror of
https://github.com/etcd-io/etcd.git
synced 2024-09-27 06:25:44 +00:00

Shallow copy of user handlers leads to a nil map assignment when enabling pprof. Since the map is being modified, it should probably be deep copied into the server context, which fixes the crash.
207 lines
5.8 KiB
Go
207 lines
5.8 KiB
Go
// Copyright 2015 The etcd Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package embed
|
|
|
|
import (
|
|
"crypto/tls"
|
|
"io/ioutil"
|
|
defaultLog "log"
|
|
"net"
|
|
"net/http"
|
|
"net/http/pprof"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/coreos/etcd/etcdserver"
|
|
"github.com/coreos/etcd/etcdserver/api/v3rpc"
|
|
pb "github.com/coreos/etcd/etcdserver/etcdserverpb"
|
|
"github.com/coreos/etcd/pkg/transport"
|
|
|
|
"github.com/cockroachdb/cmux"
|
|
gw "github.com/grpc-ecosystem/grpc-gateway/runtime"
|
|
"golang.org/x/net/context"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/credentials"
|
|
)
|
|
|
|
const pprofPrefix = "/debug/pprof"
|
|
|
|
type serveCtx struct {
|
|
l net.Listener
|
|
secure bool
|
|
insecure bool
|
|
|
|
ctx context.Context
|
|
cancel context.CancelFunc
|
|
|
|
userHandlers map[string]http.Handler
|
|
}
|
|
|
|
func newServeCtx() *serveCtx {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
return &serveCtx{ctx: ctx, cancel: cancel, userHandlers: make(map[string]http.Handler)}
|
|
}
|
|
|
|
// serve accepts incoming connections on the listener l,
|
|
// creating a new service goroutine for each. The service goroutines
|
|
// read requests and then call handler to reply to them.
|
|
func (sctx *serveCtx) serve(s *etcdserver.EtcdServer, tlscfg *tls.Config, handler http.Handler, errc chan<- error) error {
|
|
logger := defaultLog.New(ioutil.Discard, "etcdhttp", 0)
|
|
<-s.ReadyNotify()
|
|
plog.Info("ready to serve client requests")
|
|
|
|
m := cmux.New(sctx.l)
|
|
|
|
if sctx.insecure {
|
|
gs := v3rpc.Server(s, nil)
|
|
grpcl := m.Match(cmux.HTTP2())
|
|
go func() { errc <- gs.Serve(grpcl) }()
|
|
|
|
opts := []grpc.DialOption{
|
|
grpc.WithInsecure(),
|
|
}
|
|
gwmux, err := sctx.registerGateway(opts)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
httpmux := sctx.createMux(gwmux, handler)
|
|
|
|
srvhttp := &http.Server{
|
|
Handler: httpmux,
|
|
ErrorLog: logger, // do not log user error
|
|
}
|
|
httpl := m.Match(cmux.HTTP1())
|
|
go func() { errc <- srvhttp.Serve(httpl) }()
|
|
plog.Noticef("serving insecure client requests on %s, this is strongly discouraged!", sctx.l.Addr().String())
|
|
}
|
|
|
|
if sctx.secure {
|
|
gs := v3rpc.Server(s, tlscfg)
|
|
handler = grpcHandlerFunc(gs, handler)
|
|
|
|
dtls := transport.ShallowCopyTLSConfig(tlscfg)
|
|
// trust local server
|
|
dtls.InsecureSkipVerify = true
|
|
creds := credentials.NewTLS(dtls)
|
|
opts := []grpc.DialOption{grpc.WithTransportCredentials(creds)}
|
|
gwmux, err := sctx.registerGateway(opts)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
tlsl := tls.NewListener(m.Match(cmux.Any()), tlscfg)
|
|
// TODO: add debug flag; enable logging when debug flag is set
|
|
httpmux := sctx.createMux(gwmux, handler)
|
|
|
|
srv := &http.Server{
|
|
Handler: httpmux,
|
|
TLSConfig: tlscfg,
|
|
ErrorLog: logger, // do not log user error
|
|
}
|
|
go func() { errc <- srv.Serve(tlsl) }()
|
|
|
|
plog.Infof("serving client requests on %s", sctx.l.Addr().String())
|
|
}
|
|
|
|
return m.Serve()
|
|
}
|
|
|
|
// grpcHandlerFunc returns an http.Handler that delegates to grpcServer on incoming gRPC
|
|
// connections or otherHandler otherwise. Copied from cockroachdb.
|
|
func grpcHandlerFunc(grpcServer *grpc.Server, otherHandler http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
if r.ProtoMajor == 2 && strings.Contains(r.Header.Get("Content-Type"), "application/grpc") {
|
|
grpcServer.ServeHTTP(w, r)
|
|
} else {
|
|
otherHandler.ServeHTTP(w, r)
|
|
}
|
|
})
|
|
}
|
|
|
|
func servePeerHTTP(l net.Listener, handler http.Handler) error {
|
|
logger := defaultLog.New(ioutil.Discard, "etcdhttp", 0)
|
|
// TODO: add debug flag; enable logging when debug flag is set
|
|
srv := &http.Server{
|
|
Handler: handler,
|
|
ReadTimeout: 5 * time.Minute,
|
|
ErrorLog: logger, // do not log user error
|
|
}
|
|
return srv.Serve(l)
|
|
}
|
|
|
|
func (sctx *serveCtx) registerGateway(opts []grpc.DialOption) (*gw.ServeMux, error) {
|
|
ctx := sctx.ctx
|
|
addr := sctx.l.Addr().String()
|
|
gwmux := gw.NewServeMux()
|
|
|
|
err := pb.RegisterKVHandlerFromEndpoint(ctx, gwmux, addr, opts)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = pb.RegisterWatchHandlerFromEndpoint(ctx, gwmux, addr, opts)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = pb.RegisterLeaseHandlerFromEndpoint(ctx, gwmux, addr, opts)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = pb.RegisterClusterHandlerFromEndpoint(ctx, gwmux, addr, opts)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = pb.RegisterMaintenanceHandlerFromEndpoint(ctx, gwmux, addr, opts)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
err = pb.RegisterAuthHandlerFromEndpoint(ctx, gwmux, addr, opts)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return gwmux, nil
|
|
}
|
|
|
|
func (sctx *serveCtx) createMux(gwmux *gw.ServeMux, handler http.Handler) *http.ServeMux {
|
|
httpmux := http.NewServeMux()
|
|
for path, h := range sctx.userHandlers {
|
|
httpmux.Handle(path, h)
|
|
}
|
|
|
|
httpmux.Handle("/v3alpha/", gwmux)
|
|
httpmux.Handle("/", handler)
|
|
return httpmux
|
|
}
|
|
|
|
func (sctx *serveCtx) registerPprof() {
|
|
f := func(s string, h http.Handler) {
|
|
if sctx.userHandlers[s] != nil {
|
|
plog.Warningf("path %s already registered by user handler", s)
|
|
return
|
|
}
|
|
sctx.userHandlers[s] = h
|
|
}
|
|
f(pprofPrefix+"/", http.HandlerFunc(pprof.Index))
|
|
f(pprofPrefix+"/profile", http.HandlerFunc(pprof.Profile))
|
|
f(pprofPrefix+"/symbol", http.HandlerFunc(pprof.Symbol))
|
|
f(pprofPrefix+"/cmdline", http.HandlerFunc(pprof.Cmdline))
|
|
f(pprofPrefix+"/trace", http.HandlerFunc(pprof.Trace))
|
|
|
|
f(pprofPrefix+"/heap", pprof.Handler("heap"))
|
|
f(pprofPrefix+"/goroutine", pprof.Handler("goroutine"))
|
|
f(pprofPrefix+"/threadcreate", pprof.Handler("threadcreate"))
|
|
f(pprofPrefix+"/block", pprof.Handler("block"))
|
|
}
|