Mirroristas/kaspad
2
0
Fork 0
mirror of https://github.com/kaspanet/kaspad.git synced 2025-10-14 00:59:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

[NOD-475] Return error when requesting limit=0 (#505)

Browse Source
This commit is contained in:
Dan Aharoni 2019-12-01 17:25:27 +02:00 committed by Svarog
parent 2402bae1ff
commit 1b6b02e0d2
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apiserver/controllers/block.go
View File

@ -54,9 +54,9 @@ func GetBlockByHashHandler(blockHash string) (interface{}, error) {
// GetBlocksHandler searches for all blocks // GetBlocksHandler searches for all blocks
func GetBlocksHandler(order string, skip uint64, limit uint64) (interface{}, error) { func GetBlocksHandler(order string, skip uint64, limit uint64) (interface{}, error) {
if limit > maxGetBlocksLimit { if limit < 1 || limit > maxGetBlocksLimit {
return nil, httpserverutils.NewHandlerError(http.StatusBadRequest, return nil, httpserverutils.NewHandlerError(http.StatusBadRequest,
errors.Errorf("Limit higher than %d or lower than 0 was requested.", maxGetBlocksLimit)) errors.Errorf("Limit higher than %d or lower than 1 was requested.", maxGetTransactionsLimit))
} }
blocks := []*dbmodels.Block{} blocks := []*dbmodels.Block{}
db, err := database.DB() db, err := database.DB()

4
apiserver/controllers/transaction.go
View File

@ -79,9 +79,9 @@ func GetTransactionByHashHandler(txHash string) (interface{}, error) {
// GetTransactionsByAddressHandler searches for all transactions // GetTransactionsByAddressHandler searches for all transactions
// where the given address is either an input or an output. // where the given address is either an input or an output.
func GetTransactionsByAddressHandler(address string, skip uint64, limit uint64) (interface{}, error) { func GetTransactionsByAddressHandler(address string, skip uint64, limit uint64) (interface{}, error) {
if limit > maxGetTransactionsLimit { if limit < 1 || limit > maxGetTransactionsLimit {
return nil, httpserverutils.NewHandlerError(http.StatusBadRequest, return nil, httpserverutils.NewHandlerError(http.StatusBadRequest,
errors.Errorf("Limit higher than %d or lower than 0 was requested.", maxGetTransactionsLimit)) errors.Errorf("Limit higher than %d or lower than 1 was requested.", maxGetTransactionsLimit))
} }
db, err := database.DB() db, err := database.DB()