Mirroristas/kaspad
2
0
Fork 0
mirror of https://github.com/kaspanet/kaspad.git synced 2025-10-13 16:49:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

[DEV-226] Fix sorting of hashes in blockset.hashes() (#98)

Browse Source 
* [DEV-226] Fix sorting of hashes in blockset.hashes()

* [DEV-226] add TestHashes
This commit is contained in:
Ori Newman 2018-10-17 15:35:56 +03:00 committed by stasatdaglabs
parent 3deaea6c15
commit 201d7e0207
2 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
blockdag/blockset.go
View File

@ -130,7 +130,7 @@ func (bs blockSet) hashes() []daghash.Hash {
hashes = append(hashes, hash)
}
sort.Slice(hashes, func(i, j int) bool {
return daghash.Less(&hashes[j], &hashes[i])
return daghash.Less(&hashes[i], &hashes[j])
})
return hashes
}

35
blockdag/blockset_test.go Normal file
View File

@ -0,0 +1,35 @@
package blockdag
import (
"testing"
"github.com/daglabs/btcd/dagconfig/daghash"
)
func TestHashes(t *testing.T) {
bs := setFromSlice(
&blockNode{
hash: daghash.Hash{3},
},
&blockNode{
hash: daghash.Hash{1},
},
&blockNode{
hash: daghash.Hash{0},
},
&blockNode{
hash: daghash.Hash{2},
},
)
expected := []daghash.Hash{
daghash.Hash{0},
daghash.Hash{1},
daghash.Hash{2},
daghash.Hash{3},
}
if !daghash.AreEqual(bs.hashes(), expected) {
t.Errorf("TestHashes: hashes are not ordered as expected")
}
}