Mirroristas/kaspad
2
0
Fork 0
mirror of https://github.com/kaspanet/kaspad.git synced 2025-10-14 00:59:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent infinite ticker leaks in kaspaminer (#1476)

Browse Source 
* Prevent infinite tickers leaks in kaspaminer

* Reset ticker in ConnectionManager instead of allocating a new one

Co-authored-by: Ori Newman <orinewman1@gmail.com>
This commit is contained in:
Elichai Turkel 2021-02-01 14:52:17 +02:00 committed by GitHub
parent d281dabdb4
commit 280fa3de46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/kaspaminer/mineloop.go
View File

@ -167,6 +167,8 @@ func templatesLoop(client *minerClient, miningAddr util.Address,
newTemplateChan <- template newTemplateChan <- template
} }
getBlockTemplate() getBlockTemplate()
const tickerTime = 500 * time.Millisecond
ticker := time.NewTicker(tickerTime)
for { for {
select { select {
case <-stopChan: case <-stopChan:
@ -174,7 +176,8 @@ func templatesLoop(client *minerClient, miningAddr util.Address,
return return
case <-client.blockAddedNotificationChan: case <-client.blockAddedNotificationChan:
getBlockTemplate() getBlockTemplate()
case <-time.Tick(500 * time.Millisecond): ticker.Reset(tickerTime)
case <-ticker.C:
getBlockTemplate() getBlockTemplate()
} }
} }

3
infrastructure/network/connmanager/connmanager.go
View File

@ -147,8 +147,7 @@ func (c *ConnectionManager) IsBanned(netConnection *netadapter.NetConnection) (b
func (c *ConnectionManager) waitTillNextIteration() { func (c *ConnectionManager) waitTillNextIteration() {
select { select {
case <-c.resetLoopChan: case <-c.resetLoopChan:
c.loopTicker.Stop() c.loopTicker.Reset(connectionsLoopInterval)
c.loopTicker = time.NewTicker(connectionsLoopInterval)
case <-c.loopTicker.C: case <-c.loopTicker.C:
} }
} }