From 4002051a22d914db76fef4cbaff00253665564b9 Mon Sep 17 00:00:00 2001 From: Dave Collins Date: Tue, 5 Nov 2013 23:33:21 -0600 Subject: [PATCH] Optimize readVarString. Before: BenchmarkReadVarStr4 1000000 1698 ns/op BenchmarkReadVarStr10 1000000 1812 ns/op After: BenchmarkReadVarStr4 2000000 853 ns/op BenchmarkReadVarStr10 5000000 712 ns/op This is part ef the ongoing effort to optimize serialization as noted in conformal/btcd#27. --- common.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common.go b/common.go index b1853471d..42a389d4a 100644 --- a/common.go +++ b/common.go @@ -167,7 +167,7 @@ func readVarString(r io.Reader, pver uint32) (string, error) { } buf := make([]byte, count) - err = readElement(r, buf) + _, err = io.ReadFull(r, buf) if err != nil { return "", err }