From 71875c99d675470ee4caa038a1fe96a1b5039e2e Mon Sep 17 00:00:00 2001 From: Mike Zak Date: Mon, 7 Jun 2021 14:07:25 +0300 Subject: [PATCH] Invert the condition for banning when mempool rejects a transaction --- .../flows/transactionrelay/handle_relayed_transactions.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/protocol/flows/transactionrelay/handle_relayed_transactions.go b/app/protocol/flows/transactionrelay/handle_relayed_transactions.go index 3cbd48938..d8afb3712 100644 --- a/app/protocol/flows/transactionrelay/handle_relayed_transactions.go +++ b/app/protocol/flows/transactionrelay/handle_relayed_transactions.go @@ -180,10 +180,10 @@ func (flow *handleRelayedTransactionsFlow) receiveTransactions(requestedTransact return errors.Wrapf(err, "failed to process transaction %s", txID) } - shouldBan := true + shouldBan := false if txRuleErr := (&mempool_old.TxRuleError{}); errors.As(ruleErr.Err, txRuleErr) { - if txRuleErr.RejectCode != mempool_old.RejectInvalid { - shouldBan = false + if txRuleErr.RejectCode == mempool_old.RejectInvalid { + shouldBan = true } }