Mirroristas/kaspad
2
0
Fork 0
mirror of https://github.com/kaspanet/kaspad.git synced 2025-06-05 21:56:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix RPC requests with unknown payloads crashing kaspad (#1203)

Browse Source 
* [NOD-1596] Return an error on an unknown field.

* [NOD-1596] Don't use unknownFields to check whether a message is invalid.
This commit is contained in:
stasatdaglabs 2020-12-24 15:17:34 +02:00 committed by GitHub
parent a0b93e1230
commit 7cbda3b018
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
infrastructure/network/netadapter/server/grpcserver/protowire/wire.go
View File

@ -11,7 +11,11 @@ type converter interface {
// ToAppMessage converts a KaspadMessage to its appmessage.Message representation
func (x *KaspadMessage) ToAppMessage() (appmessage.Message, error) {
appMessage, err := x.Payload.(converter).toAppMessage()
converter, ok := x.Payload.(converter)
if !ok {
return nil, errors.Errorf("received invalid message")
}
appMessage, err := converter.toAppMessage()
if err != nil {
return nil, err
}