Revert "Rename isHighPriority to neverExpires"

This reverts commit b2da9a4a00c02fb380d2518cf54fa16257bd8423.
This commit is contained in:
Mike Zak 2021-06-07 09:50:26 +03:00
parent e5e266ff0b
commit b412cd9bbc
4 changed files with 15 additions and 47 deletions

View File

@ -27,7 +27,7 @@ func newMempool(consensus externalapi.Consensus, dagParams *dagconfig.Params) *m
return mp
}
func (mp *mempool) ValidateAndInsertTransaction(transaction *externalapi.DomainTransaction, neverExpires bool) (
func (mp *mempool) ValidateAndInsertTransaction(transaction *externalapi.DomainTransaction, isHighPriority bool) (
acceptedTransactions []*externalapi.DomainTransaction, err error) {
panic("mempool.ValidateAndInsertTransaction not implemented") // TODO (Mike)

View File

@ -6,13 +6,12 @@ import (
)
type idToTransaction map[externalapi.DomainTransactionID]*mempoolTransaction
type idToOrphan map[externalapi.DomainTransactionID]*orphanTransaction
type mempoolTransaction struct {
transaction *externalapi.DomainTransaction
parentsInPool idToTransaction
neverExpires bool
addAtDAAScore uint64
transaction *externalapi.DomainTransaction
parentsInPool idToTransaction
isHighPriority bool
addAtDAAScore uint64
}
func (mt *mempoolTransaction) transactionID() *externalapi.DomainTransactionID {
@ -21,7 +20,7 @@ func (mt *mempoolTransaction) transactionID() *externalapi.DomainTransactionID {
type orphanTransaction struct {
transaction *externalapi.DomainTransaction
neverExpires bool
isHighPriority bool
addedAtDAAScore uint64
}

View File

@ -1,14 +1,12 @@
package mempool
import (
"github.com/kaspanet/kaspad/domain/consensus/model/externalapi"
)
import "github.com/kaspanet/kaspad/domain/consensus/model/externalapi"
type previousOutpointToOrphans map[externalapi.DomainOutpoint]idToOrphan
type previousOutpointToOrphans map[externalapi.DomainOutpoint]idToTransaction
type orphansPool struct {
mempool *mempool
allOrphans idToOrphan
allOrphans idToTransaction
orphanByPreviousOutpoint previousOutpointToOrphans
lastExpireScan uint64
}
@ -16,14 +14,14 @@ type orphansPool struct {
func newOrphansPool(mp *mempool) *orphansPool {
return &orphansPool{
mempool: mp,
allOrphans: idToOrphan{},
allOrphans: idToTransaction{},
orphanByPreviousOutpoint: previousOutpointToOrphans{},
lastExpireScan: 0,
}
}
func (op *orphansPool) maybeAddOrphan(transaction *externalapi.DomainTransaction,
missingParents []*externalapi.DomainTransactionID, neverExpires bool) error {
missingParents []*externalapi.DomainTransactionID, isHighPriority bool) error {
panic("orphansPool.maybeAddOrphan not implemented") // TODO (Mike)
}
@ -38,37 +36,8 @@ func (op *orphansPool) unorphanTransaction(orphanTransactionID *externalapi.Doma
panic("orphansPool.unorphanTransaction not implemented") // TODO (Mike)
}
func (op *orphansPool) removeOrphan(orphanTransactionID *externalapi.DomainTransactionID, removeRedeemers bool) {
var orphanTransaction *orphanTransaction
var ok bool
if orphanTransaction, ok = op.allOrphans[*orphanTransactionID]; !ok {
return
}
// Remove orphan from allOrphans
delete(op.allOrphans, *orphanTransactionID)
// Remove orphan from all relevant entries in orphanByPreviousOutpoint
for _, input := range orphanTransaction.transaction.Inputs {
if orphans, ok := op.orphanByPreviousOutpoint[input.PreviousOutpoint]; ok {
delete(orphans, orphanTransactionID)
if len(orphans) == 0 {
delete(op.orphanByPreviousOutpoint, input.PreviousOutpoint)
}
}
}
// Recursively remove redeemers if requested.
// Since the size of the orphan pool is very limited - the recursion depth is properly bound.
if removeRedeemers {
outpoint := externalapi.DomainOutpoint{TransactionID: *orphanTransactionID}
for i := range orphanTransaction.transaction.Outputs {
outpoint.Index = uint32(i)
for _, orphanRedeemer := range op.orphanByPreviousOutpoint[outpoint] {
op.removeOrphan(orphanRedeemer.transactionID(), true)
}
}
}
func (op *orphansPool) removeOrphan(orphanTransactionID *externalapi.DomainTransactionID) error {
panic("orphansPool.removeOrphan not implemented") // TODO (Mike)
}
func (op *orphansPool) expireOrphanTransactions() error {
@ -83,7 +52,7 @@ func (op *orphansPool) expireOrphanTransactions() error {
for _, orphanTransaction := range op.allOrphans {
// Never expire high priority transactions
if orphanTransaction.neverExpires {
if orphanTransaction.isHighPriority {
continue
}

View File

@ -48,7 +48,7 @@ func (tp *transactionsPool) expireOldTransactions() error {
for _, mempoolTransaction := range tp.allTransactions {
// Never expire high priority transactions
if mempoolTransaction.neverExpires {
if mempoolTransaction.isHighPriority {
continue
}