Change IBD finished log to specify if completed succesfully or not (#1754)

* Change IBD finished log to specify if complete succesfully or not

* Move log to outside UnsetIBDRunning

* Style inhancement of IBD finished string

app/protocol/flowcontext/blocks.go

@@ -161,7 +161,6 @@ func (f *FlowContext) UnsetIBDRunning() {
 	}
 
 	f.ibdPeer = nil
-	log.Infof("IBD finished")
 }
 
 // IBDPeer returns the current IBD peer or null if the node is not

app/protocol/flows/blockrelay/ibd.go

@@ -23,10 +23,14 @@ func (flow *handleRelayInvsFlow) runIBDIfNotRunning(highHash *externalapi.Domain
 		log.Debugf("IBD is already running")
 		return nil
 	}
-	defer flow.UnsetIBDRunning()
+
+	isFinishedSuccessfully := false
+	defer func() {
+		flow.UnsetIBDRunning()
+		flow.logIBDFinished(isFinishedSuccessfully)
+	}()
 
 	log.Debugf("IBD started with peer %s and highHash %s", flow.peer, highHash)
-
 	log.Debugf("Syncing headers up to %s", highHash)
 	headersSynced, err := flow.syncHeaders(highHash)
 	if err != nil {
@@ -56,9 +60,19 @@ func (flow *handleRelayInvsFlow) runIBDIfNotRunning(highHash *externalapi.Domain
 	}
 	log.Debugf("Finished downloading block bodies up to %s", highHash)
 
+	isFinishedSuccessfully = true
+
 	return nil
 }
 
+func (flow *handleRelayInvsFlow) logIBDFinished(isFinishedSuccessfully bool) {
+	successString := "successfully"
+	if !isFinishedSuccessfully {
+		successString = "(interrupted)"
+	}
+	log.Infof("IBD finished %s", successString)
+}
+
 // syncHeaders attempts to sync headers from the peer. This method may fail
 // because the peer and us have conflicting pruning points. In that case we
 // return (false, nil) so that we may stop IBD gracefully.