mirror of
https://github.com/kaspanet/kaspad.git
synced 2025-03-30 15:08:33 +00:00
21 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Michael Sutton
|
3f80638c86
|
Add missing locks to notification listener modifications (#2124) | ||
|
Svarog
|
24c94b38be
|
Move OnBlockAdded event to the channel that was only used by virtualChanged events (#2059)
* Move OnBlockAdded event to the channel that was only used by virtualChanged events * Don't send notifications for header-only and invalid blocks * Return block status from block processor and use it for event raising decision * Use MaybeEnqueue for consensus events * go lint * Fix RPC call to actually include tx ids Co-authored-by: msutton <mikisiton2@gmail.com> |
||
|
Ori Newman
|
4dd7113dc5
|
Increase virtualChangeChan to 100e3 (#2056)
* Increase virtualChangeChan to 100e3 Don't crash when sending UTXO RPC notification to a closed route Throw error if virtualChangeChan is full * Use MaybeEnqueue in more places * Remove comment * Ignore capacity reached errors on MaybeEnqueue |
||
|
Michael Sutton
|
016ddfdfce
|
Use a channel for utxo change events (#2052)
* Use a channel from within consensus in order to raise change events in order -- note that this is only a draft commit for discussion * Fix compilation * Check for nil * Allow nil virtualChangeChan * Remove redundant comments * Call notifyVirtualChange instead of notifyUTXOsChanged * Remove redundant comment * Add a separate function for initVirtualChangeHandler * Remove redundant type * Check for nil in the right place * Fix integration test * Add data to virtual changeset and cleanup block added event logic * Renames * Comment Co-authored-by: Ori Newman <orinewman1@gmail.com> |
||
|
Svarog
|
52fbeedf20
|
Add AcceptedTransactionIDs to ChainChanged notification and VirtualSelectedParentChain RPC (#2036)
* Add acceptedTransactionIds to GetVirtualSelectedParentChainFromBlockResponseMessage and VirtualSelectedParentChainChangedNotificationMessage * Modify appmessage structs to include new fields * Implement the functionality for acceptedTransactionID notifications * Add missing field for IncludeAcceptedTransactionIds * Notify of block added before notifying that chain changed * Use consensushashing instead of Transaction.ID * Don't notify of empty virtual changes * Don't generate virtualChainChanged notification if there's nobody subscribed * Fix test to not expect empty notifications * Don't generate acceptedTransactionIDs if they were not requested by anyone Co-authored-by: Ori Newman <orinewman1@gmail.com> |
||
|
Michael Sutton
|
21b82d7efc
|
Block template cache (#1994)
* minor text fix * Implement a block template cache with template modification/reuse mechanism * Fix compilation error * Address review comments * Added a through TestModifyBlockTemplate test * Update header timestamp if possible * Avoid copying the transactions when only the header changed * go fmt |
||
|
Michael Sutton
|
c4a034eb43
|
Optimize the miner-kaspad flow and latency (#1988)
* protobuf for new block template notification structs * appmessage and wire for new block template notification structs * Set up the entire handler/call-chain for managing the new-block-template event |
||
|
Ori Newman
|
32e8e539ac
|
Apply ResolveVirtual diffs to the UTXO index (#1868)
* Apply ResolveVirtual diffs to the UTXO index * Add comments Co-authored-by: Ori Newman <> |
||
|
Svarog
|
c13a4d90ed
|
Mempool redesign (#1752)
* Added model and stubs for all main methods * Add constructors to all main objects * Implement BlockCandidateTransactions * implement expireOldTransactions and expireOrphanTransactions * Rename isHighPriority to neverExpires * Add stub for checkDoubleSpends * Revert "Rename isHighPriority to neverExpires" This reverts commit b2da9a4a00c02fb380d2518cf54fa16257bd8423. * Imeplement transactionsOrderedByFeeRate * Orphan maps should be idToOrphan * Add error.go to mempool * Invert the condition for banning when mempool rejects a transaction * Move all model objects to model package * Implement getParentsInPool * Implemented mempoolUTXOSet.addTransaction * Implement removeTransaction, remove sanity checks * Implemented mempoolUTXOSet.checkDoubleSpends * Implemented removeOrphan * Implement removeOrphan * Implement maybeAddOrphan and AddOrphan * Implemented processOrphansAfterAcceptedTransaction * Implement transactionsPool.addTransaction * Implement RemoveTransaction * If a transaction was removed from the mempool - update it's redeemers in orphan pool as well * Use maximumOrphanTransactionCount * Add allowOrphans to ValidateAndInsertTransaction stub * Implement validateTransaction functions * Implement fillInputs * Implement ValidateAndInsertTransaction * Implement HandleNewBlockTransactions * Implement missing mempool interface methods * Add comments to exported functions * Call ValidateTransactionInIsolation where needed * Implement RevalidateHighPriorityTransactions * Rewire kaspad to use new mempool, and fix compilation errors * Update rebroadcast logic to use new structure * Handle non-standard transaction errors properly * Add mutex to mempool * bugfix: GetTransaction panics when ok is false * properly calculate targetBlocksPerSecond in config.go * Fix various lint errors and tests * Fix expected text in test for duplicate transactions * Skip the coinbase transaction in HandleNewBlockTransactions * Unorphan the correct transactions * Call ValidateTransactionAndPopulateWithConsensusData on unorphanTransaction * Re-apply policy_test as check_transactions_standard_test * removeTransaction: Remove redeemers in orphan pool as well * Remove redundant check for uint64 < 0 * Export and rename isDust -> IsTransactionOutputDust to allow usage by rothschild * Add allowOrphan to SubmitTransaction RPC request * Remove all implementation from mempool.go * tidy go mod * Don't pass acceptedOrphans to handleNewBlockTransactions * Use t.Errorf in stead of t.Fatalf * Remove minimum relay fee from TestDust, as it's no longer configurable * Add separate VirtualDAASCore method for faster retrieval where it's repeated multiple times * Broadcast all transactions that were accepted * Don't re-use GetVirtualDAAScore in GetVirtualInfo - this causes a deadlock * Use real transaction count, and not Orphan * Get mempool config from outside, incorporating values received from cli * Use MinRelayFee and MaxOrphanTxs from global kaspad config * Add explanation for the seemingly redundant check for transaction version in checkTransactionStandard * Update some comment * Convert creation of acceptedTransactions to a single line * Move mempoolUTXOSet out of checkDoubleSpends * Add test for attempt to insert double spend into mempool * fillInputs: Skip check for coinbase - it's always false in mempool * Clarify comment about removeRedeemers when removing random orphan * Don't remove high-priority transactions in limitTransactionCount * Use mempool.removeTransaction in limitTransactionCount * Add mutex comment to handleNewBlockTransactions * Return error from limitTransactionCount * Pluralize the map types * mempoolUTXOSet.removeTransaction: Don't restore utxo if it was not created in mempool * Don't evacuate from orphanPool high-priority transactions * Disallow double-spends in orphan pool * Don't use exported (and locking) methods from inside mempool * Check for double spends in mempool during revalidateTransaction * Add checkOrphanDuplicate * Add orphan to acceptedOrphans, not current * Add TestHighPriorityTransactions * Fix off-by-one error in limitTransactionCount * Add TestRevalidateHighPriorityTransactions * Remove checkDoubleSpends from revalidateTransaction * Fix TestRevalidateHighPriorityTransactions * Move check for MaximumOrphanCount to beggining of maybeAddOrphan * Rename all map type to singulateToSingularMap * limitOrphanPool only after the orphan was added * TestDoubleSpendInMempool: use createChildTxWhenParentTxWasAddedByConsensus instead of createTransactionWithUTXOEntry * Fix some comments * Have separate min/max transaction versions for mempool * Add comment on defaultMaximumOrphanTransactionCount to keep it small as long as we have recursion * Fix comment * Rename: createChildTxWhenParentTxWasAddedByConsensus -> createChildTxWhereParentTxWasAddedByConsensus * Handle error from createChildTxWhereParentTxWasAddedByConsensus * Rename createChildTxWhereParentTxWasAddedByConsensus -> createChildAndParentTxsAndAddParentToConsensus * Convert all MaximumXXX constants to uint64 * Add comment * remove mutex comments |
||
|
stasatdaglabs
|
363494ef7a |
Implement NotifyVirtualDaaScoreChanged (#1737)
* Add notifyVirtualDaaScoreChanged to protowire. * Add notifyVirtualDaaScoreChanged to the rest of kaspad. * Add notifyVirtualDaaScoreChanged to the rest of kaspad. * Test the DAA score notification in TestVirtualSelectedParentBlueScore. * Rename TestVirtualSelectedParentBlueScore to TestVirtualSelectedParentBlueScoreAndVirtualDAAScore. (cherry picked from commit 83e631548f206aaf2da5b2103681c715bc250c75) |
||
|
stasatdaglabs
|
c5b0394bbc
|
In RPC, use RPCTransactions and RPCBlocks instead of TransactionMessages and BlockMessages (#1609)
* Replace BlockMessage with RpcBlock in rpc.proto. * Convert everything in kaspad to use RPCBlocks and fix tests. * Fix compilation errors in stability tests and the miner. * Update TransactionVerboseData in rpc.proto. * Update TransactionVerboseData in the rest of kaspad. * Make golint happy. * Include RpcTransactionVerboseData in RpcTransaction instead of the other way around. * Regenerate rpc.pb.go after merge. * Update appmessage types. * Update appmessage request and response types. * Reimplement conversion functions between appmessage.RPCTransaction and protowire.RpcTransaction. * Extract RpcBlockHeader toAppMessage/fromAppMessage out of RpcBlock. * Fix compilation errors in getBlock, getBlocks, and submitBlock. * Fix compilation errors in getMempoolEntry. * Fix compilation errors in notifyBlockAdded. * Update verbosedata.go. * Fix compilation errors in getBlock and getBlocks. * Fix compilation errors in getBlocks tests. * Fix conversions between getBlocks message types. * Fix integration tests. * Fix a comment. * Add selectedParent to the verbose block response. |
||
|
Ori Newman
|
2adb4f5d0f
|
Fix UTXO index (#1548)
* Add VirtualUTXODiff and VirtualParents to block insertion result * Add GetVirtualUTXOs * Add OnPruningPointUTXOSetOverrideHandler * Add recovery to UTXO index * Add UTXO set override notification * Fix compilation error * Fix iterators in UTXO index and fix TestUTXOIndex * Change Dialing to DEBUG * Change LogBlock location * Rename StopNotify to StopNotifying * Add sanity check * Add comment * Remove receiver from serialization functions Co-authored-by: Elichai Turkel <elichai.turkel@gmail.com> |
||
|
stasatdaglabs
|
3a4fa6e0e1
|
Add blockVerboseData to blockAddedNotifications (#1508)
* Add blockVerboseData to blockAddedNotifications. * Run the documentation generator. |
||
|
Ori Newman
|
02d5fb29cf
|
Fix notifyVirtualSelectedParentBlueScoreChanged to show the selected tip blue score instead of the virtual's (#1309)
* Fix notifyVirtualSelectedParentBlueScoreChanged to show the selected tip blue score instead of the virtual's * Fix ShouldMine() to fetch selected tip header |
||
|
stasatdaglabs
|
21a459c0f4
|
Implement virtual selected parent chain RPC methods (#1249)
* [NOD-1579] Rename AcceptedTxIDs to AcceptedTransactionIDs. * [NOD-1579] Add InsertBlockResult to ValidateAndInsertBlock results. * [NOD-1593] Rename InsertBlockResult to BlockInsertionResult. * [NOD-1593] Add SelectedParentChainChanges to AddBlockToVirtual's result. * [NOD-1593] Implement findSelectedParentChainChanges. * [NOD-1593] Implement TestFindSelectedParentChainChanges. * [NOD-1593] Fix a string. * [NOD-1593] Finish implementing TestFindSelectedParentChainChanges. * [NOD-1593] Fix merge errors. * [NOD-1597] Begin implementing UTXOIndex. * [NOD-1597] Connect UTXOIndex to RPC. * [NOD-1597] Connect Consensus to UTXOIndex. * [NOD-1597] Add AcceptanceData to BlockInfo. * [NOD-1597] Implement UTXOIndex.Update(). * [NOD-1597] Implement add(), remove(), and discard() in utxoIndexStore. * [NOD-1597] Add error cases to add() and remove(). * [NOD-1597] Add special cases to add() and remove(). * [NOD-1597] Implement commit. * [NOD-1597] Add a mutex around UTXOIndex.Update(). * [NOD-1597] Return changes to the UTXO from Update(). * [NOD-1597] Add NotifyUTXOsChangedRequestMessage and related structs. * [NOD-1597] Implement HandleNotifyUTXOsChanged. * [NOD-1597] Begin implementing TestUTXOIndex. * [NOD-1597] Implement RegisterForUTXOsChangedNotifications. * [NOD-1597] Fix bad transaction.ID usage. * [NOD-1597] Implement convertUTXOChangesToUTXOsChangedNotification. * [NOD-1597] Make UTXOsChangedNotificationMessage.Removed UTXOsByAddressesEntry instead of just RPCOutpoint so that the client can discern which address was the UTXO removed for. * [NOD-1597] Collect outpoints in TestUTXOIndex. * [NOD-1597] Rename RPC stuff. * [NOD-1597] Add messages for GetUTXOsByAddresses. * [NOD-1597] Implement HandleGetUTXOsByAddresses. * [NOD-1597] Implement GetUTXOsByAddresses. * [NOD-1597] Implement UTXOs(). * [NOD-1597] Implement getUTXOOutpointEntryPairs(). * [NOD-1597] Expand TestUTXOIndex. * [NOD-1597] Convert SubmitTransaction to use RPCTransaction instead of MsgTx. * [NOD-1597] Finish implementing TestUTXOIndex. * [NOD-1597] Add messages for GetVirtualSelectedParentBlueScore. * [NOD-1597] Implement HandleGetVirtualSelectedParentBlueScore and GetVirtualSelectedParentBlueScore. * [NOD-1597] Implement TestVirtualSelectedParentBlueScore. * [NOD-1597] Implement NotifyVirtualSelectedParentBlueScoreChanged. * [NOD-1597] Expand TestVirtualSelectedParentBlueScore. * [NOD-1597] Implement notifyVirtualSelectedParentBlueScoreChanged. * [NOD-1597] Make go lint happy. * [NOD-1593] Fix merge errors. * [NOD-1593] Rename findSelectedParentChainChanges to calculateSelectedParentChainChanges. * [NOD-1593] Expand TestCalculateSelectedParentChainChanges. * [NOD-1597] Add logs to utxoindex.go. * [NOD-1597] Add logs to utxoindex/store.go. * [NOD-1597] Add logs to RPCManager.NotifyXXX functions. * Implement notifySelectedParentChainChanged. * Implement TestSelectedParentChain. * Rename NotifyChainChanged to NotifyVirtualSelectedParentChainChanged. * Rename GetChainFromBlock to GetVirtualSelectedParentChainFromBlock. * Remove AcceptanceIndex from the config. * Implement HandleGetVirtualSelectedParentChainFromBlock. * Expand TestVirtualSelectedParentChain. * Fix merge errors. * Add a comment. * Move a comment. |
||
|
stasatdaglabs
|
053bb351b5
|
[NOD-1597] Implement a UTXO index (#1221)
* [NOD-1579] Rename AcceptedTxIDs to AcceptedTransactionIDs. * [NOD-1579] Add InsertBlockResult to ValidateAndInsertBlock results. * [NOD-1593] Rename InsertBlockResult to BlockInsertionResult. * [NOD-1593] Add SelectedParentChainChanges to AddBlockToVirtual's result. * [NOD-1593] Implement findSelectedParentChainChanges. * [NOD-1593] Implement TestFindSelectedParentChainChanges. * [NOD-1593] Fix a string. * [NOD-1593] Finish implementing TestFindSelectedParentChainChanges. * [NOD-1593] Fix merge errors. * [NOD-1597] Begin implementing UTXOIndex. * [NOD-1597] Connect UTXOIndex to RPC. * [NOD-1597] Connect Consensus to UTXOIndex. * [NOD-1597] Add AcceptanceData to BlockInfo. * [NOD-1597] Implement UTXOIndex.Update(). * [NOD-1597] Implement add(), remove(), and discard() in utxoIndexStore. * [NOD-1597] Add error cases to add() and remove(). * [NOD-1597] Add special cases to add() and remove(). * [NOD-1597] Implement commit. * [NOD-1597] Add a mutex around UTXOIndex.Update(). * [NOD-1597] Return changes to the UTXO from Update(). * [NOD-1597] Add NotifyUTXOsChangedRequestMessage and related structs. * [NOD-1597] Implement HandleNotifyUTXOsChanged. * [NOD-1597] Begin implementing TestUTXOIndex. * [NOD-1597] Implement RegisterForUTXOsChangedNotifications. * [NOD-1597] Fix bad transaction.ID usage. * [NOD-1597] Implement convertUTXOChangesToUTXOsChangedNotification. * [NOD-1597] Make UTXOsChangedNotificationMessage.Removed UTXOsByAddressesEntry instead of just RPCOutpoint so that the client can discern which address was the UTXO removed for. * [NOD-1597] Collect outpoints in TestUTXOIndex. * [NOD-1597] Rename RPC stuff. * [NOD-1597] Add messages for GetUTXOsByAddresses. * [NOD-1597] Implement HandleGetUTXOsByAddresses. * [NOD-1597] Implement GetUTXOsByAddresses. * [NOD-1597] Implement UTXOs(). * [NOD-1597] Implement getUTXOOutpointEntryPairs(). * [NOD-1597] Expand TestUTXOIndex. * [NOD-1597] Convert SubmitTransaction to use RPCTransaction instead of MsgTx. * [NOD-1597] Finish implementing TestUTXOIndex. * [NOD-1597] Add messages for GetVirtualSelectedParentBlueScore. * [NOD-1597] Implement HandleGetVirtualSelectedParentBlueScore and GetVirtualSelectedParentBlueScore. * [NOD-1597] Implement TestVirtualSelectedParentBlueScore. * [NOD-1597] Implement NotifyVirtualSelectedParentBlueScoreChanged. * [NOD-1597] Expand TestVirtualSelectedParentBlueScore. * [NOD-1597] Implement notifyVirtualSelectedParentBlueScoreChanged. * [NOD-1597] Make go lint happy. * [NOD-1593] Fix merge errors. * [NOD-1593] Rename findSelectedParentChainChanges to calculateSelectedParentChainChanges. * [NOD-1593] Expand TestCalculateSelectedParentChainChanges. * [NOD-1597] Add logs to utxoindex.go. * [NOD-1597] Add logs to utxoindex/store.go. * [NOD-1597] Add logs to RPCManager.NotifyXXX functions. * [NOD-1597] Ignore transactions that aren't accepted. * [NOD-1597] Use GetBlockAcceptanceData instead of GetBlockInfo. * [NOD-1597] Convert scriptPublicKey to string directly, instead of using hex. * [NOD-1597] Add a comment. * [NOD-1597] Guard against calling utxoindex methods when utxoindex is turned off. * [NOD-1597] Add lock to UTXOs. * [NOD-1597] Guard against calls to getUTXOOutpointEntryPairs when staging isn't empty. |
||
|
Svarog
|
281944762d
|
[NOD-1500] Glue between domain and application (#1007)
* [NOD-1500] Added Domain type and Constructor
* [NOD-1500] Replaced dag+txpool with domain in flowContext
* [NOD-1500] Replaced dag+txpool with domain in flowContext
* [NOD-1500] Converters: domain objects from/to appmessage
* [NOD-1500] Convert hashes to DomainHashes in appmessages
* [NOD-1500] Remove references to daghash in dagconfig
* [NOD-1500] Fixed all appmessage usages of hashes
* [NOD-1500] Update all RPC to use domain
* [NOD-1500] Big chunk of protocol flows re-wired to domain
* [NOD-1500] Finished re-wiring all protocol flows to new Domain
* [NOD-1500] Fix some mempool and kaspaminer compilation errors
* [NOD-1500] Deleted util/{block,tx,daghash} and dbaccess
* [NOD-1500] util.CoinbaseTransactionIndex -> transactionhelper.CoinbaseTransactionIndex
* [NOD-1500] Fix txsigner
* [NOD-1500] Removed all references to util/subnetworkid
* [NOD-1500] Update RpcGetBlock related messages
* [NOD-1500] Many more compilation fixes
* [NOD-1500] Return full list of missing blocks for orphan resolution
* [NOD-1500] Fixed handshake
* [NOD-1500] Fixed flowcontext compilation
* [NOD-1500] Update users of StartIBDIfRequired to handle error
* [NOD-1500] Removed some more fields from RPC
* [NOD-1500] Fix the getBlockTemplate flow
* [NOD-1500] Fix HandleGetCurrentNetwork
* [NOD-1500] Remove redundant code
* [NOD-1500] Remove obsolete notifications
* [NOD-1500] Split MiningManager and Consensus to separate fields in Domain
* [NOD-1500] Update two wrong references to location of txscript
* [NOD-1500] Added comments
* [NOD-1500] Fix some tests
* [NOD-1500] Removed serialization logic from appmessage
* [NOD-1500] Rename database/serialization/messages.proto to dbobjects.proto
* [NOD-1500] Delete integration tests
* [NOD-1500] Remove txsort
* [NOD-1500] Fix tiny bug
* [NOD-1500] Remove rogue dependancy on bchd
* [NOD-1500] Some stylistic fixes
|
||
|
Svarog
|
22237a4a8d
|
[NOD-1439] Added Stop command (#940)
* [NOD-1439] Added Stop command * [NOD-1439] Added comment explaining why we wait before closing the StopChan * [NOD-1439] Warnf -> Warn * [NOD-1439] Rename Stop command to Shut Down * [NOD-1439] Clean up pauseBeforeShutDown * [NOD-1439] Add ShutDownRequestMessage case for toRPCPayload * [NOD-1439] Minor stylistic changes |
||
|
stasatdaglabs
|
fed34273a1
|
[NOD-1404] Remove most of the notification manager to fix a deadlock (#936)
* [NOD-1404] Remove most of the notification manager to fix a deadlock. * [NOD-1404] Rename a couple of fields. * [NOD-1404] Fix merge errors. * [NOD-1404] Remove most of the notification manager to fix a deadlock (#935) * [NOD-1404] Remove most of the notification manager to fix a deadlock. * [NOD-1404] Rename a couple of fields. |
||
|
Svarog
|
1e08bfca9c
|
[NOD-1032] Consensus updates pre-pruning (#917)
* [NOD-1249] Add pruning related constants (#869) * [NOD-1249] Add pruning related constants * [NOD-1249] Change status suspect to UTXONotVerified * [NOD-1249] Add TestPruningDepth * [NOD-1249] Add comment to pruningDepth * [NOD-1249] Add pruning helper functions (#875) * [NOD-1249] Added node.blockAtDepth * [NOD-1249] Added node.finalityPoint() * [NOD-1249] Add hasFinalityPointInOthersSelectedChain * [NOD-1249] Add nonFinalityViolatingBlues * [NOD-1249] Added isInPastOfAny * [NOD-1249] Updated all calls to blockNode functions that require dag * [NOD-1249] Add blockNode.reds field and persist it * [NOD-1249] Add checkObjectiveFinality * [NOD-1249] Add isViolatingSubjectiveFinality * [NOD-1249] Added to TestGHOSTDAG check that reds are as expected * [NOD-1249] Add checkMergeLimit and checkDAGRelations * [NOD-1249] Invert condition in blockInDepth * [NOD-1249] Make isInPastOfAny resemble isInPast * [NOD-1249] Added comments to isInPast and isInPastOfAny * [NOD-1252] Remove any references to legacy finality (#876) * [NOD-1032] validateParents: check number of parents and that no parents were manually rejected (#877) * [NOD-1254] Block verification changes (#882) * [NOD-1254] Call checkDAGRelations and move it to correct place * [NOD-1254] Use blockStatuses properly * [NOD-1254] Add support for setting node's verification flag and set it to UTXONotVerified once block passes basic verification * [NOD-1254] Check for subjctiveFinality, and for node not being in the selectedParentChain * [NOD-1254] Make blockStatus an ordinary value - not bit flags * [NOD-1254] Isolate all utxo-requiring validation into a single separate if branches * [NOD-1254] Re-arrange connectBloc so that things that happen in UTXO-validated blocks only are all grouped together * [NOD-1254] Resolve and check selectedParent's status before validatingUTXO * [NOD-1254] Separate virtualUTXODiff from utxoVerificationOutput * [NOD-1254] Stylistic fixes * [NOD-1254] Use dag.index.(Set)BlockNodeStatus instead of accessing node.status * [NOD-1288] Sub-routinize checkConnectToPastUTXO * [NOD-1288] Re-write checkConnectToPastUTXO in a way that allows to filter-out invalid transactions * [NOD-1288] Make checkTxSequenceLock use already calculated utxo outputs * [NOD-1288] Make checkTxMass use already calculated utxo outputs * [NOD-1288] Use dag.sigCache for ValidateTransactionScripts * [NOD-1288] Use checkConnectTransactionToPastUTXO in applyBlueBlocks * [NOD-1288] Clean-up old code-path from no longer used functions * [NOD-1288] Skip any irrelevant parts of txo verification if block is genesis * [NOD-1288] Set where it should have been * [NOD-1288] Fix reachability checks to never use the new node + make isInSelectedParentChainOf return true if node == other * [NOD-1288] invert the condition for isNewSelectedTip * [NOD-1288] Separate checkIsAccepted to own function, and properly handle coinbase * [NOD-1288] Don't update utxo-diff for UTXONotVerified parents/tips + Make PrepareBlockForTest resolve the selectedParent's UTXOSet if needed * [NOD-1288] Include mass off coinbase transactions * [NOD-1288] Move comment to correct position * [NOD-1288] If blockAtDepth should return genesis - do it immidiately * [NOD-1288] Comment-out instead of removeing scriptval_test.go * [NOD-1288] Rename: entry -> utxoEntry * [NOD-1288] Remove special function for calcCoinbaseTxMass * [NOD-1288] Remove redundant check from checkEntryAmounts * [NOD-1288] Rename: MaxMassPerBlock -> MaxMassAcceptedByBlock * [NOD-1255] Implement boundedMergeBreakingParents * [NOD-1255] Implement selectAllowedTips * [NOD-1255] Integrate virtual parent selection into block verification process * [NOD-1255] Add node to tips all the time, remove it from candidates and add it's parents if it's disqualified * [NOD-1255] remove tips from virtaulBlock * [NOD-1255] Rename: didVirtualParentsChanged -> didVirtualParentsChange * [NOD-1255] Remove redundant sanity check * [NOD-1255] Handle a forgotten error * [NOD-1255] Prettify selectVirtualParents * [NOD-1255] UpdateTipsUTXO should run over all UTXO-Verified tips, even if they are not parents of virtual * [NOD-1311] Make isInPast inclusive * [NOD-1032] Handle finality conflicts (#904) * [NOD-1312] AddTip should not include finalityViolating and manuallyRejected blocks * [NOD-1312] Implement resolveFinalityConflict * [NOD-1312] Implement dag notifications for finalityChanges + updateing DAG state * [NOD-1312] Added finality conflict rpc boilerplate * [NOD-1312] Implement handling of getFinalityConflicts + resolveFinalityConflict RPCs * [NOD-1312] Implement finality conflict related notifications * [NOD-1312] Move all time to millisecond time * [NOD-1312] Add comments + unexport some methods * [NOD-1312] Add clarification in comments * [NOD-1312] Move updateFinalityConflictResolution to finality_conflicts.go * [NOD-1312] Rename: currentSelectedTip -> selectedTip * [NOD-1312] Add long comment to ResolveFinalityConflict * [NOD-1312] Convert areAllInSelectedParentChainOf into isInSelectedParentChainOfAll * [NOD-1312] Rename chainUpdates (type) -> selectedParentChainUpdates, to distinguish from the variable chainUpdates * [NOD-1032] Make all blockdag tests compile * [NOD-1278] Fix finality-related tests (#910) * [NOD-1032] Don't return node.dag.genesis from blockAtDepth because it might still not exist * [NOD-1032] Actually add a tip in dag.addTip * [NOD-1278] Add transaction to utxo set if it's coinbase * [NOD-1278] Use VirtualParentHashes instead of TipHashes where appropriate * [NOD-1278] If no valid virtual parent candidates - return error, don't wait for panic * [NOD-1278] Transition TestCalcSequenceLock from newTestDAG to DAGSetup * [NOD-1278] Fix .bluest() tie-breaker * [NOD-1278] Remove feeData structure, as it no longer works, store feeData in acceptanceData * [NOD-1278] Remove dag parameter from blockNode methods * [NOD-1278] Fix TestBlueBlockWindow * [NOD-1278] Don't subject selectedParent to MaxMergeSet * [NOD-1278] se PrepareAndProcessBlockForTest instead of .addTip in TestSelectedPath * [NOD-1278] Fixed TestDAGStateSerialization * [NOD-1278] Fix TestAcceptanceIndexRecover * [NOD-1278] Fix TestCheckConnectBlockTemplate * [NOD-1278] Fix TestChainUpdates * [NOD-1278] Fix and rename TestVirtualBlock -> TestTips * [NOD-1278] Rename checkIsAccepted -> maybeAcceptTx * [NOD-1278] Re-activate TestDoubleSpends * Revert "[NOD-1278] Fixed TestDAGStateSerialization" This reverts commit 845095d6de7207b07cf819d05f3f38ad94da9cf6. * [NOD-1278] Remove dag parameter from expectedCoinbaseTransaction * [NOD-1348] Implemented simplified Finality Conflict Resolution scheme (#911) * [NOD-1348] Rename functions according to Research spec * [NOD-1348] Added blockSet.areAllIn * [NOD-1348] Implemented simplified finality conflict resolution scheme * [NOD-1348] Refactorings and fixes in selectVirtualParents * [NOD-1278] Fix bugs discovered by unit-tests + Fix unit-tests (#916) * Updated to version v0.3.1 * [NOD-858] Don't switch sync peer if the syncing process hasn't yet started with the current sync peer (#700) * [NOD-858] Don't switch sync peer if the syncing process hasn't yet started with the current sync peer * [NOD-858] SetShouldSendBlockLocator(false) on OnBlockLocator * [NOD-858] Rename shouldSendBlockLocator->wasBlockLocatorRequested * [NOD-858] Move panic to shouldReplaceSyncPeer * [NOD-869] Add a print after os.Exit(1) to see if it is ever called (#701) * [NOD-1238] Fix acceptance index never being initialized. (#859) * [NOD-1278] Genesis never violates finality * [NOD-1348] Refactorings and fixes in selectVirtualParents * [NOD-1278] Don't call dag.selectVirtualParents for genesis * [NOD-1278] Properly organize errors in maybeAcceptBlock * [NOD-1278] updateTipsUTXO should only run on tips whose status is * [NOD-1278] updateTipsUTXO should only run on tips whose status is `valid` * [NOD-1278] Fix TestDoubleSpends * [NOD-1278] Fix TestDAGIndexFailedStatus * [NOD-1278] IsFinalizedTransaction should use uint64 everywhere * [NOD-1278] If tx is coinbase and not selectedParent - don't update pastUTXO * [NOD-1278] Store tips and validTips separately * [NOD-1278] Store ValidTips and VirtualParents in dagState * [NOD-1278] Fix TestProcessOrphans * [NOD-1278] Fix TestProcessOrphans * [NOD-1278] Fix TestOrderInDiffFromAcceptanceData * [NOD-1278] Fix TestHelp * [NOD-1278] Remove mining.PrepareBlockForTest; use blockdag.PrepareBlockForTest instead * [NOD-1278] Explicitly disallow chained transactions * [NOD-1278] * [NOD-1278] Fix some comments Co-authored-by: Ori Newman <orinewman1@gmail.com> Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com> Co-authored-by: Yuval Shaul <yuval.shaul@gmail.com> * [NOD-1355] Add unit-test for finality + When resolving finalityConflict - make sure the block that will come out selectedTip is statusValid (#919) * [NOD-1355] Added test for finality * [NOD-1355] When resolving finalityConflict - make sure the block that will come out selectedTip is statusValid * [NOD-1032] Renames: anything about inputsWithReferencedUTXOEntries -> remove 'Referenced' * [NOD-1032] Don't ignore non-rule errors * [NOD-1032] Fix comment * [NOD-1032] Enhanced comments on TestChainUpdates * [NOD-1032] Remove scriptval_test.go * [NOD-1032] Extracted isNewSelectedTip to a method * [NOD-1032] Use dag.Now() instead of mstime.Now() * [NOD-1032] Print block status when accepting block * [NOD-1032] Add comment explaining boundedMergeBreakingParents * [NOD-1032] Enhanced test and imporved comments in TestFinality * [NOD-1032] Rename: Objective finality -> bounded merge depth * [NOD-1032] No need to check that validTips are valid * [NOD-1032] Remove dag from arguments of updateDiffAndDiffChild * [NOD-1032] Correct variable names in LookupNodes [NOD-1032] Correct variable names in LookupNodes * [NOD-1032] Fix some comments * [NOD-1032] Some style changes * [NOD-1032] Refactor isAnyInPastOf * [NOD-1032] Enhance comment in updateVirtualParents * [NOD-1032] Flip condition in updateVirtualParents * [NOD-1032] Stylistic and grammatic fixes in dag.go and dag_test.go * [NOD-1032] Explain why updateSelectedParentSet receives geneses on init * [NOD-1032] Remove ErrParentManuallyRejected * [NOD-1032] Added wrapper for resolveNodeStatus that creates a special transaction for it * [NOD-1032] Rename: statusUTXONotVerified -> statusUTXOPendingVerification * [NOD-1032] Use virtual parents in CurrentBits() * [NOD-1032] rename: isViolatingSubjectiveFinality -> isViolatingFinality * [NOD-1032] Move updateVirtualAndTips to applyDAGChanges * [NOD-1032] Invert condition for isFinalityPointInPast * [NOD-1032] Fix antiPastBetween isInPast became inclusive * [NOD-1032] Remove redundant call for addTip * [NOD-1032] Use calcCoinbaseTxMass where appropriate * [NOD-1032] Remove time fields from conflict notifications * [NOD-1032] Assign the correct thing to i * [NOD-1032] unify checkOutputsAmounts and checkTxOutputAmounts * [NOD-1032] Cleanup in CheckTransactionInputsAndCalulateFee * [NOD-1032] Fixed some style and comments * [NOD-1032] If selectedParent is disqualifiedFromChain - validateAndApplyUTXOSet should return this as a ruleError * [NOD-1032] Set the status in resolveNodeStatus * [NOD-1032] Correct comment on boundedMergeBreakingParents * [NOD-1032] Fix a typo. * [NOD-1032] Update a variable name. * [NOD-1032] Fix a comment. * [NOD-1032] Fix merge errors. * [NOD-1032] Add VirtualParentHashes to getBlockDagInfo. * [NOD-1032] Update handleGetBlockTemplate. * [NOD-1032] Comment out all the old RPC stuff. * [NOD-1032] Remove irrelevant type. * [NOD-1032] Implement ResolveFinalityConflict. * [NOD-1032] Remove irrelevant comments. * [NOD-1032] Implement NotifyFinalityConflicts. * [NOD-1032] Add FinalityConflictNotification and FinalityConflictResolvedNotification. * [NOD-1032] Finish implementing finality conflict notifications. * [NOD-1032] Remove old RPC stuff. * [NOD-1032] Fix grammar in a comment. Co-authored-by: Ori Newman <orinewman1@gmail.com> Co-authored-by: stasatdaglabs <39559713+stasatdaglabs@users.noreply.github.com> Co-authored-by: Yuval Shaul <yuval.shaul@gmail.com> Co-authored-by: stasatdaglabs <stas@daglabs.com> |
||
|
stasatdaglabs
|
4c915f12b7
|
[NOD-1319] Reimplement kaspad's RPC in gRPC (#914)
* [NOD-1319] Create the protorpc package. * [NOD-1319] Use a general ClientStream in closeSend. * [NOD-1319] Decouple p2pServer from gRPCServer. * [NOD-1319] Begin implementing rpcServer. * [NOD-1319] Move grpcStream to grpc_connection.go. * [NOD-1319] Fold the rpc messages.proto into a common message.proto. * [NOD-1319] Remove code duplication in MessageStream. * [NOD-1319] Rename methods in netadapter. * [NOD-1319] Rename message_xxx to p2p_xxx. * [NOD-1319] Section off p2p messages from rpc messages in messages.proto. * [NOD-1319] Split toPayload to a p2p part and and rpc part. * [NOD-1319] Rename msgxxx.go to p2p_msgxx.go in the appmessage package. * [NOD-1319] Implement GetCurrentVersionRequestMessage and GetCurrentVersionResponseMessage. * [NOD-1319] Implement toAppMessage and fromAppMessage for getCurrentNetwork * [NOD-1319] Make a temporary workaround so that tests pass. * [NOD-1319] Begin implementing the rpc manager. * [NOD-1319] Implement an initial routerInitializer for rpc. * [NOD-1319] Rename the spawn in routerInitializer. * [NOD-1319] Implement an RPC context. * [NOD-1319] Move the actual handlers to a separate package. * [NOD-1319] Use the correct value for the GetCurrentNetwork response. * [NOD-1319] Fix some names. * [NOD-1319] Begin implementing a cli rpc client. * [NOD-1319] Implement connecting to the RPC server. * [NOD-1319] Make sure that connecting to the server and sending/receiving messages works. * [NOD-1319] Make kaspactl2 speak in json strings. * [NOD-1319] Finish implementing kaspactl2. * [NOD-1319] Remove debug messages. * [NOD-1319] Properly handle errors in rpc.go. * [NOD-1319] Move the grpc client to a separate package. * [NOD-1319] Extract Post out of PostString. * [NOD-1319] Implement PostAppMessage. * [NOD-1319] Stub out submitBlock. * [NOD-1319] Stub out getBlockTemplate. * [NOD-1319] Combine request and reponse files. * [NOD-1319] Implement submitBlock. * [NOD-1319] Implement returning errors from RPC. * [NOD-1319] Begin implementing getBlockTemplate. * [NOD-1319] Add missing field in GetBlockTemplateRequestMessage. * [NOD-1319] Implement a minimal getBlockTemplate. * [NOD-1319] Add getBlockTemplate stuff to grpc. * [NOD-1319] Implement the rest of getBlockTemplate. * [NOD-1319] Add block/transaction added handlers to the protocol manager. * [NOD-1319] Implement NotifyTransactionAddedToMempool. * [NOD-1319] Implement NotifyBlockAddedToDAG. * [NOD-1319] Connect block/transaction added handlers. * [NOD-1319] Add notifyBlockAdded. * [NOD-1319] Add a notification system. * [NOD-1319] Improve the notification system. * [NOD-1319] Add a block added listener stub. * [NOD-1319] Add BlockAddedNotificationMessage. * [NOD-1319] Finish implementing HandleNotifyBlockAdded. * [NOD-1319] Println instead of Print in kaspactl2. * [NOD-1319] Remove unused flags in kaspactl2. * [NOD-1319] Make kaspaminer work with the new RPC. * [NOD-1319] Fix a bad log. * [NOD-1319] Make kaspaminer work. * [NOD-1319] Disconnect the old RPC. * [NOD-1319] Move grpcclient.go. * [NOD-1319] Begin generalizing the rpcClient. * [NOD-1319] Move errors to the side of the payload. * [NOD-1319] Add errors to appmessage. * [NOD-1319] Move AttachRouter to grpcclient. * [NOD-1319] Fix kaspaminer not handling responses. * [NOD-1319] Properly handle blockAddedNotifications. * [NOD-1319] Move errors into individual response objects. * [NOD-1319] Begin replacing the RPC client in the integration tests. * [NOD-1319] Implement GetPeerAddresses. * [NOD-1319] Implement GetPeerAddresses. * [NOD-1319] Fix setOnBlockAddedHandler. * [NOD-1319] Remove the old kaspactl. * [NOD-1319] Move ConvertGetBlockTemplateResultToBlock to the mining package. * [NOD-1319] Implement getSelectedTipHash. * [NOD-1319] Simplify testRPCRouter. * [NOD-1319] Write stubs for the required test RPC commands. * [NOD-1319] Implement a minimal getMempoolEntry. * [NOD-1319] Implement a minimal getMempoolEntry. * [NOD-1319] Implement getConnectedPeerInfo. * [NOD-1319] Delete the old RPC. * [NOD-1319] Fix a fromAppMessage. * [NOD-1319] Implement connectToPeer. * [NOD-1319] Fix a bug in registerForBlockAddedNotifications. * [NOD-1319] Fix a deadlock in closing notification listeners. * [NOD-1319] Fix merge errors. * [NOD-1319] Fix an import. * [NOD-1319] Properly handle errors in grpcclient. * [NOD-1319] Fix TestIBD. * [NOD-1319] Prevent kaspaminer from running when not connected. * [NOD-1319] Implement sendRawTransaction. * [NOD-1319] Implement sendRawTransaction in the client. * [NOD-1319] Extract a general RPC client from the integration test RPC client. * [NOD-1319] Use the general RPC client for the miner. * [NOD-1319] Move the rpcclient package out of netadapter. * [NOD-1319] Normalize onBlockAdded. * [NOD-1319] Begin implementing notifyChainChanged. * [NOD-1319] Implement the model for notifyChainChanged. * [NOD-1319] Implement conversions for notifyChainChanged. * [NOD-1319] Implement HandleNotifyChainChanged. * [NOD-1319] Normalize notifications. * [NOD-1319] Implement RegisterForChainChangedNotifications. * [NOD-1319] Begin connecting blockdag's chain-changed notification with the RPC. * [NOD-1319] Finish implementing notifyChainChanged. * [NOD-1319] Implement getBlockHex. * [NOD-1319] Rename getBlockHex to getBlock. * [NOD-1319] Implement the verbose model for getBlock. * [NOD-1319] Implement buildBlockVerboseData. * [NOD-1319] Implement buildTransactionVerboseData. * [NOD-1319] Move verboseData stuff to verbosedata.go. * [NOD-1319] Add includeTransactionVerboseData. * [NOD-1319] Begin implementing getSubnetwork. * [NOD-1319] Finish implementing getSubnetwork. * [NOD-1319] Begin implementing getChainFromBlock. * [NOD-1319] Finish implementing getChainFromBlock. * [NOD-1319] Begin implementing getBlocks. * [NOD-1319] Finish implementing getBlocks. * [NOD-1319] Fix bad responses in HandleNotifyChainChanged. * [NOD-1319] Fix bugs in verbosedata.go. * [NOD-1319] Fix more bugs in verbosedata.go. * [NOD-1319] Make go vet happy. * [NOD-1319] Extract handleBlockDAGNotifications to a method. * [NOD-1319] Add a newline. * [NOD-1319] Use peers instead of connections to check if connected. * [NOD-1319] Add a comment. * [NOD-1319] Lock the dag lock in getBlock. * [NOD-1319] Rename netAdapter.connections to p2pConnections. * [NOD-1319] In protowire, rename wireXXX to protoXXX. * [NOD-1319] Rename PostString to PostJSON. * [NOD-1319] Disallow empty transactions in SendRawTransaction. * [NOD-1319] Disallow empty blocks in SubmitBlocks. * [NOD-1319] Add SetLogger. * [NOD-1319] Fix an error message. * [NOD-1319] Fix an error message. * [NOD-1319] Rename testTimeout to rpcTimeout. * [NOD-1319] Rename SendRawTransaction to SubmitTransaction. * [NOD-1319] Rename ConnectToPeer to AddPeer. * [NOD-1319] Add missing longPollID to request. * [NOD-1319] Rename ChainChangedChainBlock to ChainBlock. * [NOD-1319] Rename Vin and Vout. * [NOD-1319] Implement RPCErrorf. * [NOD-1319] Fix RPCErrorf's comment. * [NOD-1319] Remove unused flags in kaspaminer. |