5 Commits

Author SHA1 Message Date
msutton
9f9610df49 Fixed a bug in the reported virtual changeset, and modified the test to verify it 2022-07-14 18:30:30 +03:00
msutton
733c2eda7f Improve and clarify resolve virtual tests 2022-07-14 15:45:09 +03:00
msutton
09186a414a Make sure the block at the split point is reversed to new chain as well 2022-07-08 17:23:59 +03:00
msutton
fa20e016cb Illustrate the bug through prints 2022-06-30 17:45:07 +03:00
Michael Sutton
d957a6d93a
Fix UTXO diff child error (#2084)
* Avoid creating the chain iterator if high hash is actually low hash

* Always use iterator in nextPruningPointAndCandidateByBlockHash

* Initial failing test

* Minimal failing test + some comments

* go lint

* Add simpler tests with two different errors

* Missed some error checks

* Minor

* A workaround patch for preventing the missing utxo child diff bug

* Make sure we fully resolve virtual

* Move ResolveVirtualWithMaxParam to test consensus

* Mark virtual not updated and loop in batches

* Refactor: remove VirtualChangeSet from functions return values

* Remove workaround comments

* If block has no body, virtual is still considered updated

* Remove special error ErrReverseUTXODiffsUTXODiffChildNotFound

Co-authored-by: Ori Newman <orinewman1@gmail.com>
2022-06-15 02:52:14 +03:00