mirror of
https://github.com/kaspanet/kaspad.git
synced 2025-09-14 05:20:11 +00:00

* Use selectedParent instead of selectedTip for non-selectedTip blocks in restoreSingleBlockStatus * Cache the selectedParent for re-use in a resolveSingleBlockStatus chain * Implement and use reverseUTXOSet * Reverse blocks in correct order * Support resolveBlockStatus without separate stagingAreas for usage of testConsensus * Handle the case where the tip of the resolved block is not the next selectedTip * Unify isResolveTip * Some minor fixes and cleanup * Add full finality window re-org test to stability-slow * rename: useSeparateStagingAreasPerBlock -> useSeparateStagingAreaPerBlock * Better logs in resolveSingleBlockStatus * A few retouches to reverseUTXODiffs * TEMPORARY COMMIT: EXTRAT ALL DIFFFROMS TO SEPARATE METHODS * TEMPORARY COMMIT: REMOVE DIFFICULTY CHECKS IN DEVNET * Don't pre-allocate in utxo-algebra, since the numbers are not known ahead-of-time * Add some logs to reverseUTXODiffs * Revert "TEMPORARY COMMIT: REMOVE DIFFICULTY CHECKS IN DEVNET" This reverts commit c0af9dc6ade78a914c970e11bc63c34605565f57. * Revert "TEMPORARY COMMIT: EXTRAT ALL DIFFFROMS TO SEPARATE METHODS" This reverts commit 4fcca1b48c3a1183598833a355b9bfaf169edba1. * Remove redundant paranthesis * Revise some logs messages * Rename:oneBlockBeforeCurrentUTXOSet -> lastResolvedBlockUTXOSet * Don't break if the block was resolved as invalid * rename unverifiedBlocks to recentlyVerifiedBlcks in reverseUTXODiffs * Add errors.New to the panic, for a stack trace * Reverse the UTXODiffs after the main block has been commited * Use the correct value for previousUTXODiff * Add test for ReverseUTXODiff * Fix some names and comments * Update TestReverseUTXODiffs to use consensus.Config * Fix comments mentioning 'oneBlockBeforeTip'
158 lines
5.7 KiB
Go
158 lines
5.7 KiB
Go
package consensusstatemanager
|
|
|
|
import (
|
|
"github.com/kaspanet/kaspad/domain/consensus/model"
|
|
"github.com/kaspanet/kaspad/domain/consensus/model/externalapi"
|
|
"github.com/kaspanet/kaspad/infrastructure/logger"
|
|
)
|
|
|
|
// AddBlock submits the given block to be added to the
|
|
// current virtual. This process may result in a new virtual block
|
|
// getting created
|
|
func (csm *consensusStateManager) AddBlock(stagingArea *model.StagingArea, blockHash *externalapi.DomainHash) (
|
|
*externalapi.SelectedChainPath, externalapi.UTXODiff, *model.UTXODiffReversalData, error) {
|
|
|
|
onEnd := logger.LogAndMeasureExecutionTime(log, "csm.AddBlock")
|
|
defer onEnd()
|
|
|
|
log.Debugf("Resolving whether the block %s is the next virtual selected parent", blockHash)
|
|
isCandidateToBeNextVirtualSelectedParent, err := csm.isCandidateToBeNextVirtualSelectedParent(stagingArea, blockHash)
|
|
if err != nil {
|
|
return nil, nil, nil, err
|
|
}
|
|
|
|
var reversalData *model.UTXODiffReversalData
|
|
if isCandidateToBeNextVirtualSelectedParent {
|
|
// It's important to check for finality violation before resolving the block status, because the status of
|
|
// blocks with a selected chain that doesn't contain the pruning point cannot be resolved because they will
|
|
// eventually try to fetch UTXO diffs from the past of the pruning point.
|
|
log.Debugf("Block %s is candidate to be the next virtual selected parent. Resolving whether it violates "+
|
|
"finality", blockHash)
|
|
isViolatingFinality, shouldNotify, err := csm.isViolatingFinality(stagingArea, blockHash)
|
|
if err != nil {
|
|
return nil, nil, nil, err
|
|
}
|
|
|
|
if shouldNotify {
|
|
//TODO: Send finality conflict notification
|
|
log.Warnf("Finality Violation Detected! Block %s violates finality!", blockHash)
|
|
}
|
|
|
|
if !isViolatingFinality {
|
|
log.Debugf("Block %s doesn't violate finality. Resolving its block status", blockHash)
|
|
var blockStatus externalapi.BlockStatus
|
|
blockStatus, reversalData, err = csm.resolveBlockStatus(stagingArea, blockHash, true)
|
|
if err != nil {
|
|
return nil, nil, nil, err
|
|
}
|
|
|
|
log.Debugf("Block %s resolved to status `%s`", blockHash, blockStatus)
|
|
}
|
|
} else {
|
|
log.Debugf("Block %s is not the next virtual selected parent, "+
|
|
"therefore its status remains `%s`", blockHash, externalapi.StatusUTXOPendingVerification)
|
|
}
|
|
|
|
log.Debugf("Adding block %s to the DAG tips", blockHash)
|
|
newTips, err := csm.addTip(stagingArea, blockHash)
|
|
if err != nil {
|
|
return nil, nil, nil, err
|
|
}
|
|
log.Debugf("After adding %s, the amount of new tips are %d", blockHash, len(newTips))
|
|
|
|
log.Debugf("Updating the virtual with the new tips")
|
|
selectedParentChainChanges, virtualUTXODiff, err := csm.updateVirtual(stagingArea, blockHash, newTips)
|
|
if err != nil {
|
|
return nil, nil, nil, err
|
|
}
|
|
|
|
return selectedParentChainChanges, virtualUTXODiff, reversalData, nil
|
|
}
|
|
|
|
func (csm *consensusStateManager) isCandidateToBeNextVirtualSelectedParent(
|
|
stagingArea *model.StagingArea, blockHash *externalapi.DomainHash) (bool, error) {
|
|
|
|
log.Debugf("isCandidateToBeNextVirtualSelectedParent start for block %s", blockHash)
|
|
defer log.Debugf("isCandidateToBeNextVirtualSelectedParent end for block %s", blockHash)
|
|
|
|
if blockHash.Equal(csm.genesisHash) {
|
|
log.Debugf("Block %s is the genesis block, therefore it is "+
|
|
"the selected parent by definition", blockHash)
|
|
return true, nil
|
|
}
|
|
|
|
virtualGhostdagData, err := csm.ghostdagDataStore.Get(csm.databaseContext, stagingArea, model.VirtualBlockHash)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
log.Debugf("Selecting the next selected parent between "+
|
|
"the block %s the current selected parent %s", blockHash, virtualGhostdagData.SelectedParent())
|
|
nextVirtualSelectedParent, err := csm.ghostdagManager.ChooseSelectedParent(
|
|
stagingArea, virtualGhostdagData.SelectedParent(), blockHash)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
log.Debugf("The next selected parent is: %s", nextVirtualSelectedParent)
|
|
|
|
return blockHash.Equal(nextVirtualSelectedParent), nil
|
|
}
|
|
|
|
func (csm *consensusStateManager) addTip(stagingArea *model.StagingArea, newTipHash *externalapi.DomainHash) (newTips []*externalapi.DomainHash, err error) {
|
|
log.Debugf("addTip start for new tip %s", newTipHash)
|
|
defer log.Debugf("addTip end for new tip %s", newTipHash)
|
|
|
|
log.Debugf("Calculating the new tips for new tip %s", newTipHash)
|
|
newTips, err = csm.calculateNewTips(stagingArea, newTipHash)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
csm.consensusStateStore.StageTips(stagingArea, newTips)
|
|
log.Debugf("Staged the new tips, len: %d", len(newTips))
|
|
|
|
return newTips, nil
|
|
}
|
|
|
|
func (csm *consensusStateManager) calculateNewTips(
|
|
stagingArea *model.StagingArea, newTipHash *externalapi.DomainHash) ([]*externalapi.DomainHash, error) {
|
|
|
|
log.Debugf("calculateNewTips start for new tip %s", newTipHash)
|
|
defer log.Debugf("calculateNewTips end for new tip %s", newTipHash)
|
|
|
|
if newTipHash.Equal(csm.genesisHash) {
|
|
log.Debugf("The new tip is the genesis block, therefore it is the only tip by definition")
|
|
return []*externalapi.DomainHash{newTipHash}, nil
|
|
}
|
|
|
|
currentTips, err := csm.consensusStateStore.Tips(stagingArea, csm.databaseContext)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
log.Debugf("The current tips are: %s", currentTips)
|
|
|
|
newTipParents, err := csm.dagTopologyManager.Parents(stagingArea, newTipHash)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
log.Debugf("The parents of the new tip are: %s", newTipParents)
|
|
|
|
newTips := []*externalapi.DomainHash{newTipHash}
|
|
|
|
for _, currentTip := range currentTips {
|
|
isCurrentTipInNewTipParents := false
|
|
for _, newTipParent := range newTipParents {
|
|
if currentTip.Equal(newTipParent) {
|
|
isCurrentTipInNewTipParents = true
|
|
break
|
|
}
|
|
}
|
|
if !isCurrentTipInNewTipParents {
|
|
newTips = append(newTips, currentTip)
|
|
}
|
|
}
|
|
log.Debugf("The calculated new tips are: %s", newTips)
|
|
|
|
return newTips, nil
|
|
}
|