mirror of
https://github.com/kaspanet/kaspad.git
synced 2025-05-23 15:26:42 +00:00

* [NOD-1575] Implement Clone and Equal for all model types * [NOD-1575] Add assertion for transaction ID equality * [NOD-1575] Use DomainTransaction.Equal to compare to expected coinbase transaction * [NOD-1575] Add TestDomainBlockHeader_Clone * [NOD-1575] Don't clone nil values * [NOD-1575] Add type assertions * [NOD-1575] Don't clone nil values * [NOD-1575] Add missing Equals * [NOD-1575] Add length checks * [NOD-1575] Update comment * [NOD-1575] Check length for TransactionAcceptanceData * [NOD-1575] Explicitly clone nils where needed * [NOD-1575] Clone tx id * [NOD-1575] Flip condition * Nod 1576 make coverage tests for equal clone inside model externalapi (#1177) * [NOD-1576] Make coverage tests for equal and clone inside model and externalapi * Some formatting and naming fixes * Made transactionToCompare type exported * Added some tests and made some changes to the tests code * No changes made * Some formatting and naming changes made * Made better test coverage for externalapi clone and equal functions * Changed expected result for two cases * Added equal and clone functions tests for ghostdag and utxodiff * Added tests * [NOD-1576] Implement reachabilitydata equal/clone unit tests * [NOD-1576] Full coverage of reachabilitydata equal/clone unit tests * Made changes and handling panic to transaction_equal_clone_test.go and formating of utxodiff_equal_clone_test.go * Added recoverForEqual2 for handling panic to transaction_equal_clone_test.go * [NOD-1576] Full coverage of transaction equal unit test * [NOD-1576] Add expects panic * [NOD-1576] Allow composites in go vet * [NOD-1576] Code review fixes (#1223) * [NOD-1576] Code review fixes * [NOD-1576] Code review fixes part 2 * [NOD-1576] Fix wrong name Co-authored-by: karim1king <karimkaspersky@yahoo.com> Co-authored-by: Ori Newman <orinewman1@gmail.com> Co-authored-by: Karim <karim1king@users.noreply.github.com> * Fix merge errors * Use Equal where possible * Use Equal where possible * Use Equal where possible Co-authored-by: andrey-hash <74914043+andrey-hash@users.noreply.github.com> Co-authored-by: karim1king <karimkaspersky@yahoo.com> Co-authored-by: Karim <karim1king@users.noreply.github.com>
67 lines
2.4 KiB
Go
67 lines
2.4 KiB
Go
package consensusstatemanager
|
|
|
|
import "github.com/kaspanet/kaspad/domain/consensus/model/externalapi"
|
|
|
|
func (csm *consensusStateManager) isViolatingFinality(blockHash *externalapi.DomainHash) (isViolatingFinality bool,
|
|
shouldSendNotification bool, err error) {
|
|
|
|
log.Tracef("isViolatingFinality start for block %s", blockHash)
|
|
defer log.Tracef("isViolatingFinality end for block %s", blockHash)
|
|
|
|
if blockHash.Equal(csm.genesisHash) {
|
|
log.Tracef("Block %s is the genesis block, "+
|
|
"and does not violate finality by definition", blockHash)
|
|
return false, false, nil
|
|
}
|
|
|
|
var finalityPoint *externalapi.DomainHash
|
|
virtualFinalityPoint, err := csm.finalityManager.VirtualFinalityPoint()
|
|
if err != nil {
|
|
return false, false, err
|
|
}
|
|
log.Tracef("The virtual finality point is: %s", virtualFinalityPoint)
|
|
|
|
// There can be a situation where the virtual points close to the pruning point (or even in the past
|
|
// of the pruning point before calling validateAndInsertBlock for the pruning point block) and the
|
|
// finality point from the virtual point-of-view is in the past of the pruning point.
|
|
// In such situation we override the finality point to be the pruning point to avoid situations where
|
|
// the virtual selected parent chain don't include the pruning point.
|
|
pruningPoint, err := csm.pruningStore.PruningPoint(csm.databaseContext)
|
|
if err != nil {
|
|
return false, false, err
|
|
}
|
|
log.Tracef("The pruning point is: %s", pruningPoint)
|
|
|
|
isFinalityPointInPastOfPruningPoint, err := csm.dagTopologyManager.IsAncestorOf(virtualFinalityPoint, pruningPoint)
|
|
if err != nil {
|
|
return false, false, err
|
|
}
|
|
|
|
if !isFinalityPointInPastOfPruningPoint {
|
|
finalityPoint = virtualFinalityPoint
|
|
} else {
|
|
log.Tracef("The virtual finality point is %s in the past of the pruning point, so finality is validated "+
|
|
"using the pruning point", virtualFinalityPoint)
|
|
finalityPoint = pruningPoint
|
|
}
|
|
|
|
isInSelectedParentChainOfFinalityPoint, err := csm.dagTopologyManager.IsInSelectedParentChainOf(finalityPoint,
|
|
blockHash)
|
|
if err != nil {
|
|
return false, false, err
|
|
}
|
|
|
|
if !isInSelectedParentChainOfFinalityPoint {
|
|
if !isFinalityPointInPastOfPruningPoint {
|
|
return true, true, nil
|
|
}
|
|
// On IBD it's pretty normal to get blocks in the anticone of the pruning
|
|
// point, so we don't notify on cases when the pruning point is in the future
|
|
// of the finality point.
|
|
return true, false, nil
|
|
}
|
|
log.Tracef("Block %s does not violate finality", blockHash)
|
|
|
|
return false, false, nil
|
|
}
|