kaspad/domain/consensus/processes/consensusstatemanager/resolve_block_status_test.go
Svarog 8ccf381fc7 [NOD-1532] csm unit tests (#1059)
* Revert "[NOD-1500] Delete integration tests"

This reverts commit fcb57a206690a884fa6afb69d5d493282954a8bf.

* [NOD-1518] hashserialization -> consenusserialization

* [NOD-1518] Fix add genesis to virtual

* [NOD-1518] Fix a bug in SerializeCoinbasePayload.

* [NOD-1518] Fix a loop error and make pastMedianTime behave correctly everywhere on genesis.

* [NOD-1518] Fix another bug and an infinite loop.

* [NOD-1518] Fix uninitialized slice.

* [NOD-1518] Fix bad should-commit checks and another infinite loop.

* [NOD-1518] Fix nil serialization.

* [NOD-1518] Rename blockHash to currentBlockHash.

* [NOD-1518] Move the check whether stagedVirtualUTXOSet != nil to the top of commitVirtualUTXODiff.

* [NOD-1518] Simplify utxoDiffStore.Commit.

* [NOD-1518] Unextract resolveBlockStatusAndCheckFinality.

* [NOD-1518] Move no-transactions logic into CalculateIDMerkleRoot.

* [NOD-1518] Remove redundant is-staged check.

* [NOD-1518] Fix merge errors.

* [NOD-1518] Don't write anything if utxoDiffChild is nil.

* [NOD-1518] Stage virtualAcceptanceData and virtualMultiset.

* [NOD-1518] Fix bugs in getBlockTemplate and submitBlock.

* [NOD-1518] Fix bad validation order in validateHeaderInContext.

* [NOD-1518] Fix bug in Next().

* [NOD-1518] Fix nil dereference of subnetworks in AddressCache.

* [NOD-1518] Fix multisetStore.Get returning a pointer to a multiset that is changed in place.

* [NOD-1518] Break on genesis in countSubtrees.

* [NOD-1518] Fix createBlockLocator.

* [NOD-1518] Fix MsgTxToDomainTransaction.

* [NOD-1518] Set MaxTxVersion to 1.

* [NOD-1518] Fix missing error handling, bug in MsgTxToDomainTransaction, and bad subnetwork equality check.

* [NOD-1518] Fix bug in hasUTXOByOutpointFromStagedVirtualUTXODiff.

* [NOD-1518] Remove irrelevant comments.

* [NOD-1518] Generate transactions with sufficient fee in tx_relay_test.

* [NOD-1518] Fix broken RPC handlers.

* [NOD-1518] Fix merge errors.

* [NOD-1518] Fix bad exists check in restorePastUTXO and missing genesis check in CalculatePastUTXOAndAcceptanceData.

* [NOD-1518] Add a comment.

* [NOD-1518] Use a regular mutex instead of a read-write mutex in consensus to avoid dealing with sneaky not-actually-read functions.

* [NOD-1518] Fix a deadlock in GetVirtualSelectedParent.

* [NOD-1518] Fix missing handler registration for CmdHeader.

* [NOD-1518] Fix processHeader calling OnNewBlock and LogBlock. Also fix conversion errors in IBDRootUTXOSetAndBlock.

* [NOD-1518] Fix bad Command() in MsgIBDRootUTXOSetAndBlock.

* [NOD-1518] Fix bad SyncStateMissingUTXOSet logic in resolveSyncState.

* [NOD-1518] Rename mode to syncState.

* [NOD-1518] Fix headers-only blocks coming in after the consensus thinks it's synced.

* [NOD-1518] Fix selectedChildIterator.Next not ignoring virtual, infinite loop in HashSet.Length().

* [NOD-1518] Fix not-properly wrapped IBD blocks.

* [NOD-1532] Add TestMultiset

* [NOD-1518] Fix bad conversion in RequestIBDBlocks.

* [NOD-1518] Fix bad string for CmdRequestHeaders.

* [NOD-1518] Fix bad string for CmdDoneHeaders.

* [NOD-1518] Fix bad Command() for MsgIBDRootNotFound.

* [NOD-1532] Add TestPastUTXOMultiset

* [NOD-1518] Fix bad areHeaderTipsSyncedMaxTimeDifference value.

* [NOD-1532] Added TestDoubleSpends

* [NOD-1518] Add missing string for CmdRequestIBDBlocks.

* [NOD-1518] Fix bad check for SyncStateMissingBlockBodies.

* [NOD-1518] Fix bad timeout durations in tests.

* [NOD-1518] Fix IBD blocks not calling OnNewBlock.

* [NOD-1518] Change when IBD finishes.

* [NOD-1518] Properly clone utxoDiffChild.

* [NOD-1532] Update hashes of blocks

* [NOD-1532] Fix genesis blocks and a few more bugs

* [NOD-1532] Bugfix: incorrect key passed to dbTx.Put

* [NOD-1532] Make sure there's no nil payloads

* [NOD-1532] Fix AddBlockToVirtual

* [NOD-1532] Update tips and virtualDiffParents properly

* [NOD-1532] Allow nil payload

* [NOD-1532] Check for actual error and not just some RuleError

* [NOD-1532] Get rid of SimpleCoinbaseData and make OpTrueScript P2SH

* [NOD-1532] If coinbaseData is nil - fill in with generic coinbaseData

Co-authored-by: Ori Newman <orinewman1@gmail.com>
Co-authored-by: stasatdaglabs <stas@daglabs.com>
2020-11-17 16:00:16 +02:00

151 lines
6.7 KiB
Go

package consensusstatemanager_test
import (
"errors"
"testing"
"github.com/kaspanet/kaspad/domain/consensus/ruleerrors"
"github.com/kaspanet/kaspad/domain/consensus/utils/consensusserialization"
"github.com/kaspanet/kaspad/domain/consensus"
"github.com/kaspanet/kaspad/domain/consensus/model/externalapi"
"github.com/kaspanet/kaspad/domain/consensus/utils/testutils"
"github.com/kaspanet/kaspad/domain/consensus/utils/transactionhelper"
"github.com/kaspanet/kaspad/domain/dagconfig"
)
func TestDoubleSpends(t *testing.T) {
testutils.ForAllNets(t, true, func(t *testing.T, params *dagconfig.Params) {
factory := consensus.NewFactory()
consensus, teardown, err := factory.NewTestConsensus(params, "TestUTXOCommitment")
if err != nil {
t.Fatalf("Error setting up consensus: %+v", err)
}
defer teardown()
// Mine chain of two blocks to fund our double spend
firstBlockHash, err := consensus.AddBlock([]*externalapi.DomainHash{params.GenesisHash}, nil, nil)
if err != nil {
t.Fatalf("Error creating firstBlock: %+v", err)
}
fundingBlockHash, err := consensus.AddBlock([]*externalapi.DomainHash{firstBlockHash}, nil, nil)
if err != nil {
t.Fatalf("Error creating fundingBlock: %+v", err)
}
fundingBlock, err := consensus.GetBlock(fundingBlockHash)
if err != nil {
t.Fatalf("Error getting fundingBlock: %+v", err)
}
// Get funding transaction
fundingTransaction := fundingBlock.Transactions[transactionhelper.CoinbaseTransactionIndex]
// Create two transactions that spends the same output, but with different IDs
spendingTransaction1, err := testutils.CreateTransaction(fundingTransaction)
if err != nil {
t.Fatalf("Error creating spendingTransaction1: %+v", err)
}
spendingTransaction2, err := testutils.CreateTransaction(fundingTransaction)
if err != nil {
t.Fatalf("Error creating spendingTransaction2: %+v", err)
}
spendingTransaction2.Outputs[0].Value-- // tweak the value to create a different ID
spendingTransaction1ID := consensusserialization.TransactionID(spendingTransaction1)
spendingTransaction2ID := consensusserialization.TransactionID(spendingTransaction2)
if *spendingTransaction1ID == *spendingTransaction2ID {
t.Fatalf("spendingTransaction1 and spendingTransaction2 ids are equal")
}
// Mine a block with spendingTransaction1 and make sure that it's valid
goodBlock1Hash, err := consensus.AddBlock([]*externalapi.DomainHash{fundingBlockHash}, nil,
[]*externalapi.DomainTransaction{spendingTransaction1})
if err != nil {
t.Fatalf("Error adding goodBlock1: %+v", err)
}
goodBlock1Status, err := consensus.BlockStatusStore().Get(consensus.DatabaseContext(), goodBlock1Hash)
if err != nil {
t.Fatalf("Error getting status of goodBlock1: %+v", err)
}
if goodBlock1Status != externalapi.StatusValid {
t.Fatalf("GoodBlock1 status expected to be '%s', but is '%s'", externalapi.StatusValid, goodBlock1Status)
}
// To check that a block containing the same transaction already in it's past is disqualified:
// Add a block on top of goodBlock, containing spendingTransaction1, and make sure it's disqualified
doubleSpendingBlock1Hash, err := consensus.AddBlock([]*externalapi.DomainHash{goodBlock1Hash}, nil,
[]*externalapi.DomainTransaction{spendingTransaction1})
if err != nil {
t.Fatalf("Error adding doubleSpendingBlock1: %+v", err)
}
doubleSpendingBlock1Status, err := consensus.BlockStatusStore().Get(consensus.DatabaseContext(), doubleSpendingBlock1Hash)
if err != nil {
t.Fatalf("Error getting status of goodBlock: %+v", err)
}
if doubleSpendingBlock1Status != externalapi.StatusDisqualifiedFromChain {
t.Fatalf("GoodBlock status expected to be '%s', but is '%s'",
externalapi.StatusDisqualifiedFromChain, doubleSpendingBlock1Status)
}
// To check that a block containing a transaction that double-spends a transaction that
// is in it's past is disqualified:
// Add a block on top of goodBlock, containing spendingTransaction2, and make sure it's disqualified
doubleSpendingBlock2Hash, err := consensus.AddBlock([]*externalapi.DomainHash{goodBlock1Hash}, nil,
[]*externalapi.DomainTransaction{spendingTransaction2})
if err != nil {
t.Fatalf("Error adding doubleSpendingBlock2: %+v", err)
}
doubleSpendingBlock2Status, err := consensus.BlockStatusStore().Get(consensus.DatabaseContext(), doubleSpendingBlock2Hash)
if err != nil {
t.Fatalf("Error getting status of goodBlock: %+v", err)
}
if doubleSpendingBlock2Status != externalapi.StatusDisqualifiedFromChain {
t.Fatalf("GoodBlock status expected to be '%s', but is '%s'",
externalapi.StatusDisqualifiedFromChain, doubleSpendingBlock2Status)
}
// To make sure that a block double-spending itself is rejected:
// Add a block on top of goodBlock, containing both spendingTransaction1 and spendingTransaction2, and make
// sure AddBlock returns a RuleError
_, err = consensus.AddBlock([]*externalapi.DomainHash{goodBlock1Hash}, nil,
[]*externalapi.DomainTransaction{spendingTransaction1, spendingTransaction2})
if err == nil {
t.Fatalf("No error when adding a self-double-spending block")
}
if !errors.Is(err, ruleerrors.ErrDoubleSpendInSameBlock) {
t.Fatalf("Adding self-double-spending block should have "+
"returned ruleerrors.ErrDoubleSpendInSameBlock, but instead got: %+v", err)
}
// To make sure that a block containing the same transaction twice is rejected:
// Add a block on top of goodBlock, containing spendingTransaction1 twice, and make
// sure AddBlock returns a RuleError
_, err = consensus.AddBlock([]*externalapi.DomainHash{goodBlock1Hash}, nil,
[]*externalapi.DomainTransaction{spendingTransaction1, spendingTransaction2})
if err == nil {
t.Fatalf("No error when adding a block containing the same transactin twice")
}
if !errors.Is(err, ruleerrors.ErrDuplicateTx) {
t.Fatalf("Adding block that contains the same transaction twice should have "+
"returned ruleerrors.ErrDuplicateTx, but instead got: %+v", err)
}
// Check that a block will not get disqualified if it has a transaction that double spends
// a transaction from its anticone.
goodBlock2Hash, err := consensus.AddBlock([]*externalapi.DomainHash{fundingBlockHash}, nil,
[]*externalapi.DomainTransaction{spendingTransaction2})
if err != nil {
t.Fatalf("Error adding goodBlock: %+v", err)
}
//use ResolveBlockStatus, since goodBlock2 might not be the selectedTip
goodBlock2Status, err := consensus.ConsensusStateManager().ResolveBlockStatus(goodBlock2Hash)
if err != nil {
t.Fatalf("Error getting status of goodBlock: %+v", err)
}
if goodBlock2Status != externalapi.StatusValid {
t.Fatalf("GoodBlock status expected to be '%s', but is '%s'", externalapi.StatusValid, goodBlock2Status)
}
})
}