Mirroristas/openpgpjs
2
0
Fork 0
mirror of https://github.com/openpgpjs/openpgpjs.git synced 2025-03-30 15:08:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: drop unused, unnecessary error assertion

Browse Source 
The `expect().to.not.throw` check as written is a no-op.
In fact, `throw` should have been called as a function.

We drop the relevant check altogether since if the wrapped
operation throws, the test will naturally fail due to the
unexpected error.
This commit is contained in:
larabr 2024-11-13 19:44:06 +01:00
parent 088d5f3638
commit 121b478312
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/general/key.js
View File

@ -3806,7 +3806,7 @@ CNa5yq6lyexhsn2Vs8DsX+SOSUyNJiy5FyIJ
const passphrase = 'hello world';
const key = await openpgp.readKey({ armoredKey: priv_key_rsa });
expect(key.keyPacket.isDummy()).to.be.false;
expect(key.keyPacket.makeDummy()).to.not.throw;
key.keyPacket.makeDummy();
expect(key.keyPacket.isDummy()).to.be.true;
// dummy primary key should always be marked as not decrypted
const decryptedKey = await openpgp.decryptKey({ privateKey: key, passphrase });
@ -3825,7 +3825,7 @@ CNa5yq6lyexhsn2Vs8DsX+SOSUyNJiy5FyIJ
it('makeDummy() - should work for encrypted keys with unknown s2k (unparseableKeyMaterial)', async function() {
const key = await openpgp.readKey({ armoredKey: encryptedKeyUnknownS2K });
expect(key.keyPacket.isDummy()).to.be.false;
expect(key.keyPacket.makeDummy()).to.not.throw;
key.keyPacket.makeDummy();
expect(key.keyPacket.isDummy()).to.be.true;
expect(key.keyPacket.unparseableKeyMaterial).to.not.exist;
});