From 7982713f3d71a88cc81fa65273335c5c73baea7d Mon Sep 17 00:00:00 2001 From: larabr <7375870+larabr@users.noreply.github.com> Date: Tue, 2 Apr 2024 13:51:38 +0200 Subject: [PATCH] Fix reused reference of notation array in input With the new salt notation, the original input array was mutated, which is undesirable, but it also led to an error when signing with multiple keys, since duplicate salt notations were detected. --- src/key/helper.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/key/helper.js b/src/key/helper.js index 97a68c26..3934cad9 100644 --- a/src/key/helper.js +++ b/src/key/helper.js @@ -218,7 +218,7 @@ export async function createSignaturePacket(dataToSign, privateKey, signingKeyPa Object.assign(signaturePacket, signatureProperties); signaturePacket.publicKeyAlgorithm = signingKeyPacket.algorithm; signaturePacket.hashAlgorithm = await getPreferredHashAlgo(privateKey, signingKeyPacket, date, userID, config); - signaturePacket.rawNotations = notations; + signaturePacket.rawNotations = [...notations]; await signaturePacket.sign(signingKeyPacket, dataToSign, date, detached, config); return signaturePacket; }