Mirroristas/owncast
2
0
Fork 0
mirror of https://github.com/owncast/owncast.git synced 2024-10-10 19:16:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Stop playback metrics on player unmount

Browse Source
This commit is contained in:
Gabe Kangas 2022-10-12 18:08:14 -07:00
parent 4eb5bff3db
commit d40e66b7ef
No known key found for this signature in database
GPG Key ID: 9A56337728BC81EA
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
web/components/video/OwncastPlayer/OwncastPlayer.tsx
View File

@ -291,6 +291,7 @@ export const OwncastPlayer: FC<OwncastPlayerProps> = ({ source, online }) => {
useEffect(
() => () => {
stopLatencyCompensator();
playbackMetrics.stop();
},
[],
);

12
web/components/video/metrics/playback.js
View File

@ -49,6 +49,7 @@ class PlaybackMetrics {
this.send = this.send.bind(this);
this.collectPlaybackMetrics = this.collectPlaybackMetrics.bind(this);
this.handleNoLongerBuffering = this.handleNoLongerBuffering.bind(this);
this.sendMetricsTimer = 0;
this.player.on('canplaythrough', this.handleNoLongerBuffering);
this.player.on('error', this.handleError);
@ -81,11 +82,16 @@ class PlaybackMetrics {
this.videoJSReady();
setInterval(() => {
this.sendMetricsTimer = setInterval(() => {
this.send();
}, METRICS_SEND_INTERVAL);
}
stop() {
clearInterval(this.sendMetricsTimer);
this.player.off();
}
// Keep our client clock in sync with the server clock to determine
// accurate latency calculations.
setClockSkew(skewMs) {
@ -249,12 +255,12 @@ class PlaybackMetrics {
bandwidth: roundedAverageBandwidth,
latency: roundedAverageLatency,
downloadDuration: roundedAverageDownloadDuration,
errors: errorCount + this.isBuffering ? 1 : 0,
errors: errorCount + (this.isBuffering ? 1 : 0),
qualityVariantChanges: this.qualityVariantChanges,
};
} else {
data = {
errors: errorCount + this.isBuffering ? 1 : 0,
errors: errorCount + (this.isBuffering ? 1 : 0),
};
}