Add golangci-lint run to lib/ (#181)

* [lib] Add .golangci.yaml as symlink

https://github.com/golang/go/wiki/Modules#faqs--multi-module-repositories

* [golangci-lint] Change `nakedret` settings

* [linter] Can be replaced with faster hex.EncodeToString (perfsprint)

* [linter] Fix too many quotes

* [ci] Add `golangci-lint run` of `lib/`

Signed-off-by: Julian Strobl <jmastr@mailbox.org>

.github/workflows/audit.yaml

@@ -56,7 +56,7 @@ jobs:
         run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
 
       - name: Run golangci-lint
-        run: golangci-lint run
+        run: (golangci-lint run && cd lib && golangci-lint run)
 
       - name: Run tests
         run: go test -race -vet=off ./...

.golangci.yaml

@@ -66,6 +66,9 @@ linters:
     - usestdlibvars
     - wastedassign
     - zerologlint
+linters-settings:
+  nakedret:
+    max-func-lines: 100
 issues:
   exclude-rules:
     - path: codec\.go

lib/.golangci.yaml

@@ -0,0 +1 @@
+../.golangci.yaml

lib/config.go

@@ -10,7 +10,7 @@ import (
 // Config defines library top level configuration.
 type Config struct {
 	ChainID        string                `mapstructure:"chain-id" json:"chain-id"`
-	EncodingConfig params.EncodingConfig `mapstructure:"encoding-config" json:"encoding-config""`
+	EncodingConfig params.EncodingConfig `mapstructure:"encoding-config" json:"encoding-config"`
 	RootDir        string                `mapstructure:"root-dir" json:"root-dir"`
 	RPCEndpoint    string                `mapstructure:"rpc-endpoint" json:"rpc-endpoint"`
 }

lib/tx.go

@@ -50,7 +50,7 @@ func getKeyPairFromKeyring(address sdk.AccAddress) (keyPair KeyPair, err error)
 		return
 	}
 
-	name := fmt.Sprintf("%x", []byte(address)) + ".address"
+	name := hex.EncodeToString([]byte(address)) + ".address"
 	i, err := ring.Get(name)
 	if err != nil {
 		return