From 1b76af856515b4093dc51933a4c6ac718a96e8b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Eckel?= Date: Thu, 27 Oct 2022 15:59:02 +0200 Subject: [PATCH] added wrong ConnectionError refereing removed obsolete tests clear singleton before /after making DB connection tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Jürgen Eckel --- planetmint/backend/tarantool/connection.py | 2 +- tests/backend/test_connection.py | 15 ++++++++++----- tests/test_core.py | 18 +++--------------- 3 files changed, 14 insertions(+), 21 deletions(-) diff --git a/planetmint/backend/tarantool/connection.py b/planetmint/backend/tarantool/connection.py index 7599a1a..d4e491f 100644 --- a/planetmint/backend/tarantool/connection.py +++ b/planetmint/backend/tarantool/connection.py @@ -9,7 +9,7 @@ import tarantool from planetmint.config import Config from transactions.common.exceptions import ConfigurationError from planetmint.utils import Lazy -from planetmint.backend.connection import DBConnection +from planetmint.backend.connection import DBConnection, ConnectionError logger = logging.getLogger(__name__) diff --git a/tests/backend/test_connection.py b/tests/backend/test_connection.py index 10d9b3c..5dc3f42 100644 --- a/tests/backend/test_connection.py +++ b/tests/backend/test_connection.py @@ -7,12 +7,17 @@ import pytest def test_get_connection_raises_a_configuration_error(monkeypatch): - from planetmint.backend.connection import Connection - from planetmint.backend.localmongodb.connection import LocalMongoDBConnection + from planetmint.backend.connection import ConnectionError from planetmint.backend.tarantool.connection import TarantoolDBConnection + + with pytest.raises(ConnectionError): + TarantoolDBConnection("localhost", "1337", "mydb", "password") + +@pytest.mark.skip(reason="we currently do not suppport mongodb.") +def test_get_connection_raises_a_configuration_error_mongodb(monkeypatch): + from planetmint.backend.localmongodb.connection import LocalMongoDBConnection from transactions.common.exceptions import ConfigurationError with pytest.raises(ConnectionError): - LocalMongoDBConnection("localhost", "1337", "mydb", "password") - with pytest.raises(ConnectionError): - TarantoolDBConnection("localhost", "1337", "mydb", "password") + conn = LocalMongoDBConnection("localhost", "1337", "mydb", "password") + diff --git a/tests/test_core.py b/tests/test_core.py index 6a43b51..f24db27 100644 --- a/tests/test_core.py +++ b/tests/test_core.py @@ -9,6 +9,7 @@ from planetmint.version import __tm_supported_versions__ from transactions.types.assets.create import Create from transactions.types.assets.transfer import Transfer from transactions.common.exceptions import ConfigurationError +from planetmint.backend.connection import Connection, ConnectionError @pytest.fixture @@ -38,20 +39,6 @@ def config(request, monkeypatch): monkeypatch.setattr("planetmint.config", config) return config - -def test_bigchain_class_initialization_with_parameters(): - from planetmint.backend.localmongodb.connection import LocalMongoDBConnection - - init_db_kwargs = { - "backend": "localmongodb", - "host": "this_is_the_db_host", - "port": 12345, - "name": "this_is_the_db_name", - } - with pytest.raises(ConfigurationError): - LocalMongoDBConnection(**init_db_kwargs) - - def test_bigchain_class_default_initialization(config): from planetmint import Planetmint from planetmint.validation import BaseValidationRules @@ -65,7 +52,8 @@ def test_bigchain_class_default_initialization(config): @pytest.mark.bdb def test_get_spent_issue_1271(b, alice, bob, carol): from planetmint import Planetmint - + connection = Connection() + del connection planet = Planetmint() print(f" CONNECTION HOST : {planet.connection.host}") tx_1 = Create.generate(