Resolve flake8 issues

Signed-off-by: Sangat Das <sangatdas5@gmail.com>

planetmint/backend/schema.py

@@ -11,7 +11,8 @@ import logging
 import planetmint
 from planetmint.backend.connection import connect
 from planetmint.transactions.common.exceptions import ValidationError
-from planetmint.transactions.common.utils import validate_all_values_for_key_in_obj, validate_all_values_for_key_in_list
+from planetmint.transactions.common.utils import (
+    validate_all_values_for_key_in_obj, validate_all_values_for_key_in_list)
 
 logger = logging.getLogger(__name__)
 

planetmint/commands/planetmint.py

@@ -18,8 +18,8 @@ from planetmint.core import rollback
 from planetmint.migrations.chain_migration_election import ChainMigrationElection
 from planetmint.utils import load_node_key
 from planetmint.transactions.common.transaction_mode_types import BROADCAST_TX_COMMIT
-from planetmint.transactions.common.exceptions import (DatabaseDoesNotExist,
+from planetmint.transactions.common.exceptions import (
-                                          ValidationError)
+    DatabaseDoesNotExist, ValidationError)
 from planetmint.transactions.types.elections.vote import Vote
 import planetmint
 from planetmint import (backend, ValidatorElection,

planetmint/lib.py

@@ -24,31 +24,26 @@ import requests
 import planetmint
 from planetmint import backend, config_utils, fastquery
 from planetmint.models import Transaction
-from planetmint.transactions.common.exceptions import (SchemaValidationError,
+from planetmint.transactions.common.exceptions import (
-                                          ValidationError,
+    SchemaValidationError, ValidationError, DoubleSpend)
-                                          DoubleSpend)
+from planetmint.transactions.common.transaction_mode_types import (BROADCAST_TX_COMMIT, BROADCAST_TX_ASYNC, BROADCAST_TX_SYNC)
-from planetmint.transactions.common.transaction_mode_types import (BROADCAST_TX_COMMIT,
-                                                      BROADCAST_TX_ASYNC,
-                                                      BROADCAST_TX_SYNC)
 from planetmint.tendermint_utils import encode_transaction, merkleroot
 from planetmint import exceptions as core_exceptions
 from planetmint.validation import BaseValidationRules
 
-
 logger = logging.getLogger(__name__)
 
-
 class Planetmint(object):
-    """Bigchain API
+    """Planetmint API
 
     Create, read, sign, write transactions to the database
     """
 
     def __init__(self, connection=None):
-        """Initialize the Bigchain instance
+        """Initialize the Planetmint instance
 
-        A Bigchain instance has several configuration parameters (e.g. host).
+        A Planetmint instance has several configuration parameters (e.g. host).
-        If a parameter value is passed as an argument to the Bigchain
+        If a parameter value is passed as an argument to the Planetmint
         __init__ method, then that is the value it will have.
         Otherwise, the parameter value will come from an environment variable.
         If that environment variable isn't set, then the value

planetmint/models.py

@@ -4,8 +4,7 @@
 # Code is Apache-2.0 and docs are CC-BY-4.0
 
 from planetmint.backend.schema import validate_language_key
-from planetmint.transactions.common.exceptions import (InvalidSignature,
+from planetmint.transactions.common.exceptions import (InvalidSignature, DuplicateTransaction)
-                                          DuplicateTransaction)
 from planetmint.transactions.common.schema import validate_transaction_schema
 from planetmint.transactions.common.transaction import Transaction
 from planetmint.transactions.common.utils import (validate_txn_obj, validate_key)

planetmint/transactions/common/input.py

@@ -3,28 +3,10 @@
 # SPDX-License-Identifier: (Apache-2.0 AND CC-BY-4.0)
 # Code is Apache-2.0 and docs are CC-BY-4.0
 
-from collections import namedtuple
+from cryptoconditions import Fulfillment
-from copy import deepcopy
+from cryptoconditions.exceptions import ASN1DecodeError, ASN1EncodeError
-from functools import reduce, lru_cache
-import rapidjson
 
-import base58
+from planetmint.transactions.common.exceptions import InvalidSignature
-from cryptoconditions import Fulfillment, ThresholdSha256, Ed25519Sha256
-from cryptoconditions.exceptions import (
-    ParsingError, ASN1DecodeError, ASN1EncodeError, UnsupportedTypeError)
-try:
-    from hashlib import sha3_256
-except ImportError:
-    from sha3 import sha3_256
-
-from planetmint.transactions.common.crypto import PrivateKey, hash_data
-from planetmint.transactions.common.exceptions import (KeypairMismatchException,
-                                          InputDoesNotExist, DoubleSpend,
-                                          InvalidHash, InvalidSignature,
-                                          AmountError, AssetIdMismatch,
-                                          ThresholdTooDeep)
-from planetmint.transactions.common.utils import serialize
-from .memoize import memoize_from_dict, memoize_to_dict
 from .utils import _fulfillment_to_details, _fulfillment_from_details
 from .output import Output
 from .transaction_link import TransactionLink

planetmint/transactions/common/output.py

@@ -3,28 +3,12 @@
 # SPDX-License-Identifier: (Apache-2.0 AND CC-BY-4.0)
 # Code is Apache-2.0 and docs are CC-BY-4.0
 
-from collections import namedtuple
+from functools import reduce
-from copy import deepcopy
-from functools import reduce, lru_cache
-import rapidjson
 
 import base58
 from cryptoconditions import Fulfillment, ThresholdSha256, Ed25519Sha256
-from cryptoconditions.exceptions import (
-    ParsingError, ASN1DecodeError, ASN1EncodeError, UnsupportedTypeError)
-try:
-    from hashlib import sha3_256
-except ImportError:
-    from sha3 import sha3_256
 
-from planetmint.transactions.common.crypto import PrivateKey, hash_data
+from planetmint.transactions.common.exceptions import AmountError
-from planetmint.transactions.common.exceptions import (KeypairMismatchException,
-                                          InputDoesNotExist, DoubleSpend,
-                                          InvalidHash, InvalidSignature,
-                                          AmountError, AssetIdMismatch,
-                                          ThresholdTooDeep)
-from planetmint.transactions.common.utils import serialize
-from .memoize import memoize_from_dict, memoize_to_dict
 from .utils import _fulfillment_to_details, _fulfillment_from_details
 
 class Output(object):

planetmint/transactions/common/transaction.py

@@ -13,13 +13,13 @@ Attributes:
 """
 from collections import namedtuple
 from copy import deepcopy
-from functools import reduce, lru_cache
+from functools import lru_cache
 import rapidjson
 
 import base58
 from cryptoconditions import Fulfillment, ThresholdSha256, Ed25519Sha256
 from cryptoconditions.exceptions import (
-    ParsingError, ASN1DecodeError, ASN1EncodeError, UnsupportedTypeError)
+    ParsingError, ASN1DecodeError, ASN1EncodeError)
 try:
     from hashlib import sha3_256
 except ImportError:
@@ -29,8 +29,7 @@ from planetmint.transactions.common.crypto import PrivateKey, hash_data
 from planetmint.transactions.common.exceptions import (KeypairMismatchException,
                                           InputDoesNotExist, DoubleSpend,
                                           InvalidHash, InvalidSignature,
-                                          AmountError, AssetIdMismatch,
+                                          AmountError, AssetIdMismatch)
-                                          ThresholdTooDeep)
 from planetmint.transactions.common.utils import serialize
 from .memoize import memoize_from_dict, memoize_to_dict
 from .input import Input

planetmint/transactions/common/transaction_link.py

@@ -3,29 +3,6 @@
 # SPDX-License-Identifier: (Apache-2.0 AND CC-BY-4.0)
 # Code is Apache-2.0 and docs are CC-BY-4.0
 
-from collections import namedtuple
-from copy import deepcopy
-from functools import reduce, lru_cache
-import rapidjson
-
-import base58
-from cryptoconditions import Fulfillment, ThresholdSha256, Ed25519Sha256
-from cryptoconditions.exceptions import (
-    ParsingError, ASN1DecodeError, ASN1EncodeError, UnsupportedTypeError)
-try:
-    from hashlib import sha3_256
-except ImportError:
-    from sha3 import sha3_256
-
-from planetmint.transactions.common.crypto import PrivateKey, hash_data
-from planetmint.transactions.common.exceptions import (KeypairMismatchException,
-                                          InputDoesNotExist, DoubleSpend,
-                                          InvalidHash, InvalidSignature,
-                                          AmountError, AssetIdMismatch,
-                                          ThresholdTooDeep)
-from planetmint.transactions.common.utils import serialize
-from .memoize import memoize_from_dict, memoize_to_dict
-
 class TransactionLink(object):
     """An object for unidirectional linking to a Transaction's Output.
 

planetmint/transactions/common/utils.py

@@ -10,14 +10,9 @@ import rapidjson
 
 import planetmint
 from planetmint.transactions.common.exceptions import ValidationError
-from cryptoconditions import Fulfillment, ThresholdSha256, Ed25519Sha256
+from cryptoconditions import ThresholdSha256, Ed25519Sha256
-from planetmint.transactions.common.exceptions import (KeypairMismatchException,
+from planetmint.transactions.common.exceptions import ThresholdTooDeep
-                                          InputDoesNotExist, DoubleSpend,
+from cryptoconditions.exceptions import UnsupportedTypeError
-                                          InvalidHash, InvalidSignature,
-                                          AmountError, AssetIdMismatch,
-                                          ThresholdTooDeep)
-from cryptoconditions.exceptions import (
-    ParsingError, ASN1DecodeError, ASN1EncodeError, UnsupportedTypeError)
 
 
 def gen_timestamp():
@@ -221,3 +216,4 @@ def _fulfillment_from_details(data, _depth=0):
         return threshold
 
     raise UnsupportedTypeError(data.get('type'))
+    

planetmint/transactions/types/assets/transfer.py

@@ -4,7 +4,6 @@
 # Code is Apache-2.0 and docs are CC-BY-4.0
 
 from planetmint.transactions.common.transaction import Transaction
-from planetmint.transactions.common.input import Input
 from planetmint.transactions.common.output import Output
 from copy import deepcopy
 

planetmint/transactions/types/elections/election.py

@@ -11,17 +11,14 @@ from planetmint import backend
 from planetmint.transactions.types.assets.create import Create
 from planetmint.transactions.types.assets.transfer import Transfer
 from planetmint.transactions.types.elections.vote import Vote
-from planetmint.transactions.common.exceptions import (InvalidSignature,
+from planetmint.transactions.common.exceptions import (
-                                          MultipleInputsError,
+    InvalidSignature, MultipleInputsError, InvalidProposer, 
-                                          InvalidProposer,
+    UnequalValidatorSet, DuplicateTransaction)
-                                          UnequalValidatorSet,
-                                          DuplicateTransaction)
 from planetmint.tendermint_utils import key_from_base64, public_key_to_base64
 from planetmint.transactions.common.crypto import (public_key_from_ed25519_key)
 from planetmint.transactions.common.transaction import Transaction
-from planetmint.transactions.common.schema import (_validate_schema,
+from planetmint.transactions.common.schema import (
-                                      TX_SCHEMA_COMMON,
+    _validate_schema, TX_SCHEMA_COMMON, TX_SCHEMA_CREATE)
-                                      TX_SCHEMA_CREATE)
 
 
 class Election(Transaction):

planetmint/transactions/types/elections/vote.py

@@ -6,10 +6,8 @@
 from planetmint.transactions.types.assets.create import Create
 from planetmint.transactions.types.assets.transfer import Transfer
 from planetmint.transactions.common.transaction import Transaction
-from planetmint.transactions.common.schema import (_validate_schema,
+from planetmint.transactions.common.schema import (
-                                      TX_SCHEMA_COMMON,
+    _validate_schema, TX_SCHEMA_COMMON, TX_SCHEMA_TRANSFER, TX_SCHEMA_VOTE)
-                                      TX_SCHEMA_TRANSFER,
-                                      TX_SCHEMA_VOTE)
 
 
 class Vote(Transaction):

planetmint/web/views/parameters.py

@@ -5,10 +5,8 @@
 
 import re
 
-from planetmint.transactions.common.transaction_mode_types import (BROADCAST_TX_COMMIT,
+from planetmint.transactions.common.transaction_mode_types import (
-                                                      BROADCAST_TX_ASYNC,
+    BROADCAST_TX_COMMIT, BROADCAST_TX_ASYNC, BROADCAST_TX_SYNC)
-                                                      BROADCAST_TX_SYNC)
-
 
 def valid_txid(txid):
     if re.match('^[a-fA-F0-9]{64}$', txid):

tests/common/conftest.py

@@ -152,8 +152,8 @@ def tx(utx, user_priv):
 
 @pytest.fixture
 def transfer_utx(user_output, user2_output, utx):
-    from planetmint.transactions.common.transaction import (Input, TransactionLink,
+    from planetmint.transactions.common.transaction import (
-                                               Transaction)
+        Input, TransactionLink, Transaction)
     user_output = user_output.to_dict()
     input = Input(utx.outputs[0].fulfillment,
                   user_output['public_keys'],

tests/common/test_transaction.py

@@ -621,8 +621,8 @@ def test_multiple_input_validation_of_transfer_tx(user_input, user_output,
                                                   user2_priv, user3_pub,
                                                   user3_priv,
                                                   asset_definition):
-    from planetmint.transactions.common.transaction import (Transaction, TransactionLink,
+    from planetmint.transactions.common.transaction import (
-                                               Input, Output)
+        Transaction, TransactionLink, Input, Output)
     from cryptoconditions import Ed25519Sha256
     from .utils import validate_transaction_model
 

tests/conftest.py

@@ -27,8 +27,8 @@ from planetmint.transactions.common import crypto
 from planetmint.transactions.common.transaction_mode_types import BROADCAST_TX_COMMIT
 from planetmint.tendermint_utils import key_from_base64
 from planetmint.backend import schema, query
-from planetmint.transactions.common.crypto import (key_pair_from_ed25519_key,
+from planetmint.transactions.common.crypto import (
-                                      public_key_from_ed25519_key)
+    key_pair_from_ed25519_key, public_key_from_ed25519_key)
 from planetmint.transactions.common.exceptions import DatabaseDoesNotExist
 from planetmint.lib import Block
 from tests.utils import gen_vote

tests/tendermint/test_lib.py

@@ -17,9 +17,8 @@ import pytest
 from pymongo import MongoClient
 
 from planetmint import backend
-from planetmint.transactions.common.transaction_mode_types import (BROADCAST_TX_COMMIT,
+from planetmint.transactions.common.transaction_mode_types import (
-                                                      BROADCAST_TX_ASYNC,
+    BROADCAST_TX_COMMIT, BROADCAST_TX_ASYNC, BROADCAST_TX_SYNC)
-                                                      BROADCAST_TX_SYNC)
 from planetmint.lib import Block
 
 

tests/upsert_validator/test_validator_election.py

@@ -9,11 +9,9 @@ import pytest
 
 from planetmint.tendermint_utils import public_key_to_base64
 from planetmint.upsert_validator import ValidatorElection
-from planetmint.transactions.common.exceptions import (DuplicateTransaction,
+from planetmint.transactions.common.exceptions import (
-                                          UnequalValidatorSet,
+    DuplicateTransaction, UnequalValidatorSet, InvalidProposer,
-                                          InvalidProposer,
+    MultipleInputsError, InvalidPowerChange)
-                                          MultipleInputsError,
-                                          InvalidPowerChange)
 
 pytestmark = pytest.mark.bdb
 

tests/validation/test_transaction_structure.py

@@ -16,9 +16,8 @@ except ImportError:
     import sha3
 from unittest.mock import MagicMock
 
-from planetmint.transactions.common.exceptions import (AmountError,
+from planetmint.transactions.common.exceptions import (
-                                          SchemaValidationError,
+    AmountError, SchemaValidationError, ThresholdTooDeep)
-                                          ThresholdTooDeep)
 from planetmint.models import Transaction
 from planetmint.transactions.common.utils import _fulfillment_to_details, _fulfillment_from_details
 
@@ -214,8 +213,6 @@ def test_high_amounts(b, create_tx, alice):
 # Conditions
 
 def test_handle_threshold_overflow():
-    from planetmint.transactions.common import transaction
-
     cond = {
         'type': 'ed25519-sha-256',
         'public_key': 'a' * 43,
@@ -231,7 +228,6 @@ def test_handle_threshold_overflow():
 
 
 def test_unsupported_condition_type():
-    from planetmint.transactions.common import transaction
     from cryptoconditions.exceptions import UnsupportedTypeError
 
     with pytest.raises(UnsupportedTypeError):

tests/web/test_transactions.py

@@ -15,9 +15,8 @@ except ImportError:
     from sha3 import sha3_256
 
 from planetmint.transactions.common import crypto
-from planetmint.transactions.common.transaction_mode_types import (BROADCAST_TX_COMMIT,
+from planetmint.transactions.common.transaction_mode_types import (
-                                                      BROADCAST_TX_ASYNC,
+    BROADCAST_TX_COMMIT, BROADCAST_TX_ASYNC, BROADCAST_TX_SYNC)
-                                                      BROADCAST_TX_SYNC)
 
 TX_ENDPOINT = '/api/v1/transactions/'