From ac6e1e47e49f63b7858c5e404a4136751a339053 Mon Sep 17 00:00:00 2001 From: Ben Allfree Date: Mon, 23 Jan 2023 15:53:32 +0000 Subject: [PATCH] fix: proper handling of http-proxy error conditions --- packages/daemon/src/services/ProxyService.ts | 3 +++ readme.md | 1 + 2 files changed, 4 insertions(+) diff --git a/packages/daemon/src/services/ProxyService.ts b/packages/daemon/src/services/ProxyService.ts index 4a65f9d2..049062dc 100644 --- a/packages/daemon/src/services/ProxyService.ts +++ b/packages/daemon/src/services/ProxyService.ts @@ -33,6 +33,9 @@ export const proxyService = mkSingleton(async (config: ProxyServiceConfig) => { const { coreInternalUrl } = config const proxy = httpProxy.createProxyServer({}) + proxy.on('error', (err, req, res, target) => { + warn(`Proxy error ${err} on ${req.url} (${req.headers.host})`) + }) const server = createServer(async (req, res) => { dbg(`Incoming request ${req.headers.host}/${req.url}`) diff --git a/readme.md b/readme.md index ab891681..8335319c 100644 --- a/readme.md +++ b/readme.md @@ -139,6 +139,7 @@ If all goes well: - Fix: requests for instances not ending in `pockethost.io` now rejected - Fix: realtime logging API requests no longer intercepted by PocketBase - Fix: potential timer memory leak +- Fix: proper handling of http-proxy error conditions - Chore: various internal error trapping and logging **0.6.1**