fix: disallow backups if data dir doesn't exist

packages/daemon/src/services/InstanceService.ts

@@ -119,9 +119,14 @@ export const createInstanceService = async (config: InstanceServiceConfig) => {
           api.shutdown()
         },
       })
+
       const { pid } = childProcess
       assertTruthy(pid, `Expected PID here but got ${pid}`)
 
+      if (!instance.isBackupAllowed) {
+        await client.updateInstance(instance.id, { isBackupAllowed: true })
+      }
+
       const invocation = await client.createInvocation(instance, pid)
       const tm = createTimerManager({})
       const api: InstanceApi = (() => {

packages/pockethost.io/src/routes/app/instances/[instanceId]/Backup.svelte

@@ -58,6 +58,7 @@
 <div class="py-4">
   <h2>Backup</h2>
 
+  {#if instance.isBackupAllowed}
     <div class="text-center py-5">
       <button class="btn btn-light" on:click={() => startBackup()} disabled={isBackingUp}>
         <i class="bi bi-safe" /> Backup Now
@@ -96,6 +97,10 @@
         </div>
       {/each}
     </div>
+  {/if}
+  {#if !instance.isBackupAllowed}
+    You must access this instance at least once before backups can be made.
+  {/if}
 </div>
 
 <style lang="scss">

readme.md

@@ -136,13 +136,13 @@ open https://pockethost.io
 
 **next**
 
-- [x] fix: incorrect instance information displaying on dashboard details
+- [x] fix: incorrect instance information displaying on dashboard details in some cases
 - [x] fix: more helpful error message when backup fails for nonexistent instance
 - [x] chore: move version number to base package.json
 - [x] refactor: logging and async helpers
 - [x] chore: restore auto-cancellation
 - [x] chore: rebuild with go 1.19.3 and include in bin name
-- [ ] fix: Disallow backups if data dir doesn't exist
+- [x] fix: Disallow backups if data dir doesn't exist
 
 **0.5.2**