From f3d9ac8b68cf9bc4e4d76c2912427ab6e0076b9a Mon Sep 17 00:00:00 2001 From: Ben Allfree Date: Sun, 10 Nov 2024 17:45:02 -0800 Subject: [PATCH] enh: improve instance error logging --- .../src/services/InstanceService/index.ts | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/packages/pockethost/src/services/InstanceService/index.ts b/packages/pockethost/src/services/InstanceService/index.ts index 4ffe9db4..2452ff0a 100644 --- a/packages/pockethost/src/services/InstanceService/index.ts +++ b/packages/pockethost/src/services/InstanceService/index.ts @@ -232,8 +232,7 @@ export const instanceService = mkSingleton( dbg(`Updated instance fields`, fields) }) .catch((e) => { - dbg(`Error updating instance fields`, fields) - error(e) + error(`Error updating instance fields`, { fields, e }) }) }, ) @@ -339,12 +338,16 @@ export const instanceService = mkSingleton( exitCode.then((code) => { info(`Processes exited with ${code}.`) setImmediate(() => { - _safeShutdown().catch(error) + _safeShutdown().catch((err) => { + error(`Error shutting down ${id}`, { err }) + }) }) }) shutdownManager.add(async () => { dbg(`killing ${id}`) - await childProcess.kill().catch(error) + await childProcess.kill().catch((err) => { + error(`Error killing ${id}`, { err }) + }) dbg(`killed ${id}`) }) @@ -379,7 +382,9 @@ export const instanceService = mkSingleton( userInstanceLogger.info( `Instance has been idle for ${DAEMON_PB_IDLE_TTL()}ms. Hibernating to conserve resources.`, ) - await _safeShutdown().catch(error) + await _safeShutdown().catch((err) => { + error(`Error shutting down ${id}`, { err }) + }) return false } else { trace(`${openRequestCount} requests remain open`) @@ -407,7 +412,9 @@ export const instanceService = mkSingleton( return `${e}` })() warn(`Instance failed to start: ${detail}`) - _safeShutdown(e).catch(error) + _safeShutdown(e).catch((err) => { + error(`Error shutting down ${id}`, { err }) + }) }) return api