Mirroristas/rathena
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added missing state checks in banking functions (#7645)

Browse Source 
Co-authored-by: Lemongrass3110 <lemongrass@kstp.at>
This commit is contained in:
Jittapan Pluemsumran
2023-03-14 17:34:05 +07:00
committed by GitHub
parent 7dd6eb5182
commit 22abdf8dbe
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/map/pc.cpp
View File

@@ -14524,8 +14524,11 @@ void pc_expire_check(map_session_data *sd) {
* @param money Amount of money to deposit
**/
enum e_BANKING_DEPOSIT_ACK pc_bank_deposit(map_session_data *sd, int money) {
unsigned int limit_check = money + sd->bank_vault;
if (!sd->state.banking) {
return BDA_ERROR;
}
unsigned int limit_check = money + sd->bank_vault;
if( money <= 0 || limit_check > MAX_BANK_ZENY ) {
return BDA_OVERFLOW;
} else if ( money > sd->status.zeny ) {
@@ -14548,8 +14551,11 @@ enum e_BANKING_DEPOSIT_ACK pc_bank_deposit(map_session_data *sd, int money) {
* @param money Amount of money that will be withdrawn
**/
enum e_BANKING_WITHDRAW_ACK pc_bank_withdraw(map_session_data *sd, int money) {
if (!sd->state.banking) {
return BWA_UNKNOWN_ERROR;
}
unsigned int limit_check = money + sd->status.zeny;
if( money <= 0 ) {
return BWA_UNKNOWN_ERROR;
} else if ( money > sd->bank_vault ) {