From 30a33ac7b5a28a1111ae558fd336b905e6468f10 Mon Sep 17 00:00:00 2001 From: Atemo Date: Fri, 14 Jun 2024 21:28:14 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Aleos --- doc/status.txt | 6 +++--- src/map/clif.cpp | 6 ++---- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/doc/status.txt b/doc/status.txt index b072489e3d..a599325aa2 100644 --- a/doc/status.txt +++ b/doc/status.txt @@ -213,9 +213,9 @@ Flags: Various status flags for specific status change events. MobLoseTarget - When active on a monster it will lose the target. RestartOnMapWarp - Restarts the timer of a status when warping to another map. SpreadEffect - Passes the status onto a target when SC_DEADLYINFECT is active. - SendVal1 - Whether val1 shoudn't be ignored. - SendVal2 - Whether val2 shoudn't be ignored. - SendVal3 - Whether val3 shoudn't be ignored. + SendVal1 - Whether val1 shouldn't be ignored. + SendVal2 - Whether val2 shouldn't be ignored. + SendVal3 - Whether val3 shouldn't be ignored. NoClearbuff - Cannot be removed by 'status_change_clear_buffs()', 'sc_end SC_ALL', 'status_change_clear(3)', etc. NoForcedEnd - Cannot be removed by sc_end. diff --git a/src/map/clif.cpp b/src/map/clif.cpp index e6cc319540..99b960921c 100644 --- a/src/map/clif.cpp +++ b/src/map/clif.cpp @@ -1751,8 +1751,7 @@ int clif_spawn( struct block_list *bl, bool walking ){ case BL_PET: if (vd->head_bottom) clif_pet_equip_area((TBL_PET*)bl); // needed to display pet equip properly - clif_efst_status_change_sub( *bl, *bl, AREA_WOS ); - break; + [[fallthrough]]; case BL_HOM: case BL_MER: case BL_ELEM: @@ -5111,8 +5110,7 @@ void clif_getareachar_unit( map_session_data* sd,struct block_list *bl ){ case BL_PET: if (vd->head_bottom) clif_pet_equip(sd, (TBL_PET*)bl); // needed to display pet equip properly - clif_efst_status_change_sub( sd->bl, *bl, SELF ); - break; + [[fallthrough]]; case BL_HOM: case BL_ELEM: clif_efst_status_change_sub( sd->bl, *bl, SELF );