diff --git a/src/map/script.cpp b/src/map/script.cpp index 8ded14acfa..7602f068b2 100644 --- a/src/map/script.cpp +++ b/src/map/script.cpp @@ -6737,7 +6737,7 @@ static int script_getitem_randomoption(struct script_state *st, struct map_sessi // If no player is attached if( !script_rid2sd(sd) ){ ShowError( "buildin_%s: variable \"%s\" was not a server variable, but no player was attached.\n", funcname, opt_id_var ); - return false; + return SCRIPT_CMD_FAILURE; } } @@ -6756,7 +6756,7 @@ static int script_getitem_randomoption(struct script_state *st, struct map_sessi // If no player is attached if( !script_rid2sd(sd) ){ ShowError( "buildin_%s: variable \"%s\" was not a server variable, but no player was attached.\n", funcname, opt_val_var ); - return false; + return SCRIPT_CMD_FAILURE; } } @@ -6775,7 +6775,7 @@ static int script_getitem_randomoption(struct script_state *st, struct map_sessi // If no player is attached if( !script_rid2sd(sd) ){ ShowError( "buildin_%s: variable \"%s\" was not a server variable, but no player was attached.\n", funcname, opt_param_var ); - return false; + return SCRIPT_CMD_FAILURE; } } @@ -6792,11 +6792,6 @@ static int script_getitem_randomoption(struct script_state *st, struct map_sessi opt_id_ref = reference_getref(opt_id); opt_id_n = script_array_highest_key(st, sd, opt_id_var, opt_id_ref); - if (opt_id_n < 1) { - ShowError("buildin_%s: No option id listed.\n", funcname); - return SCRIPT_CMD_FAILURE; - } - opt_val_ref = reference_getref(opt_val); opt_param_ref = reference_getref(opt_param); @@ -6900,8 +6895,8 @@ int script_countitem_sub(struct item *items, struct item_data *id, int size, boo * Returns number of items in inventory * countitem({,}) * countitem2(,,,,,,,{,}) [Lupus] - * countitem3(,,,,,,,,,,) - * countitem3("",,,,,,,,,,) + * countitem3(,,,,,,,,,,{,}) + * countitem3("",,,,,,,,,,{,}) */ BUILDIN_FUNC(countitem) { @@ -6917,16 +6912,8 @@ BUILDIN_FUNC(countitem) random_option = true; } - if (script_hasdata(st, aid)) { - if (!(sd = map_id2sd(script_getnum(st, aid)))) { - ShowError("buildin_%s: player not found (AID=%d).\n", command, script_getnum(st, aid)); - st->state = END; - return SCRIPT_CMD_FAILURE; - } - } else { - if (!script_rid2sd(sd)) - return SCRIPT_CMD_FAILURE; - } + if (!script_accid2sd(aid, sd)) + return SCRIPT_CMD_FAILURE; struct item_data *id; @@ -6964,16 +6951,8 @@ BUILDIN_FUNC(cartcountitem) if (command[strlen(command) - 1] == '2') aid = 10; - if (script_hasdata(st, aid)) { - if (!(sd = map_id2sd(script_getnum(st, aid)))) { - ShowError("buildin_%s: player not found (AID=%d).\n", command, script_getnum(st, aid)); - st->state = END; - return SCRIPT_CMD_FAILURE; - } - } else { - if (!script_rid2sd(sd)) - return SCRIPT_CMD_FAILURE; - } + if (!script_accid2sd(aid, sd)) + return SCRIPT_CMD_FAILURE; if (!pc_iscarton(sd)) { ShowError("buildin_%s: Player doesn't have cart (CID:%d).\n", command, sd->status.char_id); @@ -7017,16 +6996,8 @@ BUILDIN_FUNC(storagecountitem) if (command[strlen(command) - 1] == '2') aid = 10; - if (script_hasdata(st, aid)) { - if (!(sd = map_id2sd(script_getnum(st, aid)))) { - ShowError("buildin_%s: player not found (AID=%d).\n", command, script_getnum(st, aid)); - st->state = END; - return SCRIPT_CMD_FAILURE; - } - } else { - if (!script_rid2sd(sd)) - return SCRIPT_CMD_FAILURE; - } + if (!script_accid2sd(aid, sd)) + return SCRIPT_CMD_FAILURE; struct item_data *id; @@ -7069,16 +7040,8 @@ BUILDIN_FUNC(guildstoragecountitem) if (command[strlen(command) - 1] == '2') aid = 10; - if (script_hasdata(st, aid)) { - if (!(sd = map_id2sd(script_getnum(st, aid)))) { - ShowError("buildin_%s: player not found (AID=%d).\n", command, script_getnum(st, aid)); - st->state = END; - return SCRIPT_CMD_FAILURE; - } - } else { - if (!script_rid2sd(sd)) - return SCRIPT_CMD_FAILURE; - } + if (!script_accid2sd(aid, sd)) + return SCRIPT_CMD_FAILURE; struct item_data *id;