diff --git a/src/common/utils.cpp b/src/common/utils.cpp index 2059102523..8ba73e9972 100644 --- a/src/common/utils.cpp +++ b/src/common/utils.cpp @@ -240,7 +240,7 @@ void findfile(const char *p, const char *pat, void (func)(const char*)) sprintf(tmppath,"%s%c%s",path, PATHSEP, entry->d_name); // check if the pattern matchs. - if (entry->d_name && strstr(entry->d_name, pattern)) { + if (entry->d_name[0] && strstr(entry->d_name, pattern)) { func( tmppath ); } // check if it is a directory. diff --git a/src/map/atcommand.cpp b/src/map/atcommand.cpp index 51e5a7c00d..831a49a34e 100644 --- a/src/map/atcommand.cpp +++ b/src/map/atcommand.cpp @@ -3990,7 +3990,7 @@ ACMD_FUNC(mapinfo) { char direction[12]; int i, m_id, chat_num = 0, list = 0, vend_num = 0; unsigned short m_index; - char mapname[24]; + char mapname[MAP_NAME_LENGTH]; nullpo_retr(-1, sd); @@ -3998,7 +3998,7 @@ ACMD_FUNC(mapinfo) { memset(mapname, '\0', sizeof(mapname)); memset(direction, '\0', sizeof(direction)); - sscanf(message, "%11d %23[^\n]", &list, mapname); + sscanf(message, "%11d %11[^\n]", &list, mapname); if (list < 0 || list > 3) { clif_displaymessage(fd, msg_txt(sd,1038)); // Please enter at least one valid list number (usage: @mapinfo <0-3> ). @@ -7357,7 +7357,7 @@ ACMD_FUNC(showmobs) return 0; } - if(mob_id == atoi(mob_name) && mob_db(mob_id)->jname) + if(mob_id == atoi(mob_name) && mob_db(mob_id)->jname[0]) strcpy(mob_name,mob_db(mob_id)->jname); // --ja-- //strcpy(mob_name,mob_db(mob_id)->name); // --en-- @@ -9143,13 +9143,12 @@ ACMD_FUNC(charcommands) { /* for new mounts */ ACMD_FUNC(mount2) { clif_displaymessage(sd->fd,msg_txt(sd,1362)); // NOTICE: If you crash with mount your LUA is outdated. - if (!&sd->sc || !(sd->sc.data[SC_ALL_RIDING])) { + if (!sd->sc.data[SC_ALL_RIDING]) { clif_displaymessage(sd->fd,msg_txt(sd,1363)); // You have mounted. sc_start(NULL, &sd->bl, SC_ALL_RIDING, 10000, 1, INVALID_TIMER); } else { clif_displaymessage(sd->fd,msg_txt(sd,1364)); // You have released your mount. - if (&sd->sc) - status_change_end(&sd->bl, SC_ALL_RIDING, INVALID_TIMER); + status_change_end(&sd->bl, SC_ALL_RIDING, INVALID_TIMER); } return 0; } diff --git a/src/map/channel.cpp b/src/map/channel.cpp index cdb225f6cf..deee27ef02 100644 --- a/src/map/channel.cpp +++ b/src/map/channel.cpp @@ -39,7 +39,7 @@ DBMap* channel_get_db(void){ return channel_db; } struct Channel* channel_create(struct Channel *tmp_chan) { struct Channel* channel; - if (!tmp_chan->name) + if (!tmp_chan->name[0]) return NULL; CREATE(channel, struct Channel, 1); //will exit on fail allocation @@ -50,8 +50,8 @@ struct Channel* channel_create(struct Channel *tmp_chan) { channel->type = tmp_chan->type; channel->color = tmp_chan->color; safestrncpy(channel->name, tmp_chan->name, CHAN_NAME_LENGTH); // Store channel cname without '#' - safestrncpy(channel->alias, tmp_chan->alias ? tmp_chan->alias : tmp_chan->name, CHAN_NAME_LENGTH); - if (!tmp_chan->pass) + safestrncpy(channel->alias, tmp_chan->alias[0] ? tmp_chan->alias : tmp_chan->name, CHAN_NAME_LENGTH); + if (!tmp_chan->pass[0]) channel->pass[0] = '\0'; else safestrncpy(channel->pass, tmp_chan->pass, CHAN_NAME_LENGTH); @@ -394,7 +394,7 @@ int channel_pcquit(struct map_session_data *sd, int type){ if(!sd) return -1; // Leave all chat channels. - if(type&(1|2) && channel_config.ally_tmpl.name != NULL && sd->guild){ //quit guild and ally chan + if(type&(1|2) && channel_config.ally_tmpl.name[0] && sd->guild){ //quit guild and ally chan struct guild *g = sd->guild; if(type&1 && channel_haspc(g->channel,sd)==1){ channel_clean(g->channel,sd,0); //leave guild chan @@ -410,7 +410,7 @@ int channel_pcquit(struct map_session_data *sd, int type){ } } } - if(type&4 && channel_config.map_tmpl.name != NULL && channel_haspc(map[sd->bl.m].channel,sd)==1){ //quit map chan + if(type&4 && channel_config.map_tmpl.name[0] && channel_haspc(map[sd->bl.m].channel,sd)==1){ //quit map chan channel_clean(map[sd->bl.m].channel,sd,0); } if(type&8 && sd->channel_count ) { //quit all chan @@ -612,11 +612,11 @@ int channel_display_list(struct map_session_data *sd, const char *options){ char output[CHAT_SIZE_MAX]; clif_displaymessage(sd->fd, msg_txt(sd,1410)); // ---- Public Channels ---- - if( channel_config.map_tmpl.name != NULL && map[sd->bl.m].channel ) { + if( channel_config.map_tmpl.name[0] && map[sd->bl.m].channel ) { sprintf(output, msg_txt(sd,1409), map[sd->bl.m].channel->name, db_size(map[sd->bl.m].channel->users));// - #%s (%d users) clif_displaymessage(sd->fd, output); } - if( channel_config.ally_tmpl.name != NULL && sd->status.guild_id ) { + if( channel_config.ally_tmpl.name[0] && sd->status.guild_id ) { struct guild *g = sd->guild; if (g && g->channel) { sprintf(output, msg_txt(sd,1409), g->channel->name, db_size(((struct Channel *)g->channel)->users));// - #%s (%d users) @@ -1016,7 +1016,7 @@ int channel_pcban(struct map_session_data *sd, char *chname, char *pname, int fl sprintf(output, msg_txt(sd,1443), channel->name);// ---- '#%s' Ban List: clif_displaymessage(sd->fd, output); for( cbe = (struct chan_banentry *)dbi_first(iter); dbi_exists(iter); cbe = (struct chan_banentry *)dbi_next(iter) ) { //for all users - if (cbe->char_name && cbe->char_name[0] != '\0') + if (cbe->char_name[0]) sprintf(output, "%d: %s",cbe->char_id,cbe->char_name); else sprintf(output, "%d: ****",cbe->char_id); @@ -1263,7 +1263,7 @@ int channel_pcautojoin_sub(DBKey key, DBData *data, va_list ap) { nullpo_ret(channel); nullpo_ret((sd = va_arg(ap, struct map_session_data *))); - if (channel->pass && channel->pass[0] != '\0') + if (channel->pass[0]) return 0; if (!(channel->opt&CHAN_OPT_AUTOJOIN)) return 0; diff --git a/src/map/chrif.cpp b/src/map/chrif.cpp index d6cad6d701..43ca22cfaa 100644 --- a/src/map/chrif.cpp +++ b/src/map/chrif.cpp @@ -312,7 +312,7 @@ int chrif_save(struct map_session_data *sd, int flag) { chrif_bsdata_save(sd, ((flag&CSAVE_QUITTING) && !(flag&CSAVE_AUTOTRADE))); - if (&sd->storage && sd->storage.dirty) + if (sd->storage.dirty) storage_storagesave(sd); if (flag&CSAVE_INVENTORY) intif_storage_save(sd,&sd->inventory); @@ -322,7 +322,7 @@ int chrif_save(struct map_session_data *sd, int flag) { //For data sync if (sd->state.storage_flag == 2) storage_guild_storagesave(sd->status.account_id, sd->status.guild_id, flag); - if (&sd->premiumStorage && sd->premiumStorage.dirty) + if (sd->premiumStorage.dirty) storage_premiumStorage_save(sd); if (flag&CSAVE_QUITTING) diff --git a/src/map/clif.cpp b/src/map/clif.cpp index 78e0b70acf..983d561d1d 100644 --- a/src/map/clif.cpp +++ b/src/map/clif.cpp @@ -10534,7 +10534,7 @@ void clif_parse_LoadEndAck(int fd,struct map_session_data *sd) #endif // Instances do not need their own channels - if( channel_config.map_tmpl.name != NULL && (channel_config.map_tmpl.opt&CHAN_OPT_AUTOJOIN) && !map[sd->bl.m].flag.chmautojoin && !map[sd->bl.m].instance_id ) + if( channel_config.map_tmpl.name[0] && (channel_config.map_tmpl.opt&CHAN_OPT_AUTOJOIN) && !map[sd->bl.m].flag.chmautojoin && !map[sd->bl.m].instance_id ) channel_mjoin(sd); //join new map clif_pk_mode_message(sd); diff --git a/src/map/guild.cpp b/src/map/guild.cpp index eca6f710f4..40331d3823 100644 --- a/src/map/guild.cpp +++ b/src/map/guild.cpp @@ -540,7 +540,7 @@ int guild_recv_info(struct guild *sg) { if( sd==NULL ) continue; sd->guild = g; - if(channel_config.ally_tmpl.name && (channel_config.ally_tmpl.opt&CHAN_OPT_AUTOJOIN)) { + if(channel_config.ally_tmpl.name[0] && (channel_config.ally_tmpl.opt&CHAN_OPT_AUTOJOIN)) { channel_gjoin(sd,3); //make all member join guildchan+allieschan } @@ -709,7 +709,7 @@ void guild_member_joined(struct map_session_data *sd) { if (g->instance_id != 0) instance_reqinfo(sd, g->instance_id); - if( channel_config.ally_tmpl.name != NULL && (channel_config.ally_tmpl.opt&CHAN_OPT_AUTOJOIN) ) { + if( channel_config.ally_tmpl.name[0] && (channel_config.ally_tmpl.opt&CHAN_OPT_AUTOJOIN) ) { channel_gjoin(sd,3); } } @@ -1673,7 +1673,7 @@ int guild_allianceack(int guild_id1,int guild_id2,uint32 account_id1,uint32 acco clif_guild_allianceinfo(sd_mem); // join ally channel - if( channel_config.ally_tmpl.name != NULL && (channel_config.ally_tmpl.opt&CHAN_OPT_AUTOJOIN) ) { + if( channel_config.ally_tmpl.name[0] && (channel_config.ally_tmpl.opt&CHAN_OPT_AUTOJOIN) ) { channel_gjoin(sd_mem,2); } } @@ -1758,7 +1758,7 @@ int guild_broken(int guild_id,int flag) { guild_db->foreach(guild_db,guild_broken_sub,guild_id); castle_db->foreach(castle_db,castle_guild_broken_sub,guild_id); storage_guild_delete(guild_id); - if( channel_config.ally_tmpl.name != NULL ) { + if( channel_config.ally_tmpl.name[0] ) { channel_delete(g->channel,false); } idb_remove(guild_db,guild_id); diff --git a/src/map/homunculus.cpp b/src/map/homunculus.cpp index 488bf0bd60..8085647180 100644 --- a/src/map/homunculus.cpp +++ b/src/map/homunculus.cpp @@ -360,7 +360,7 @@ short hom_checkskill(struct homun_data *hd,uint16 skill_id) if (idx < 0) // Invalid skill return 0; - if (!hd || !&hd->homunculus) + if (!hd) return 0; if (hd->homunculus.hskill[idx].id == skill_id) diff --git a/src/map/log.cpp b/src/map/log.cpp index da32130eca..cd5950f52e 100644 --- a/src/map/log.cpp +++ b/src/map/log.cpp @@ -226,7 +226,7 @@ void log_pick(int id, int16 m, e_log_pick_type type, int amount, struct item* it StringBuf_Printf(&buf, ", `option_parm%d`", i); } StringBuf_Printf(&buf, ") VALUES(NOW(),'%u','%c','%d','%d','%d','%s','%" PRIu64 "','%d'", - id, log_picktype2char(type), itm->nameid, amount, itm->refine, map[m].name ? map[m].name : "", itm->unique_id, itm->bound); + id, log_picktype2char(type), itm->nameid, amount, itm->refine, map[m].name[0] ? map[m].name : "", itm->unique_id, itm->bound); for (i = 0; i < MAX_SLOTS; i++) StringBuf_Printf(&buf, ",'%d'", itm->card[i]); @@ -250,7 +250,7 @@ void log_pick(int id, int16 m, e_log_pick_type type, int amount, struct item* it return; time(&curtime); strftime(timestring, sizeof(timestring), log_timestamp_format, localtime(&curtime)); - fprintf(logfp,"%s - %d\t%c\t%hu,%d,%d,%hu,%hu,%hu,%hu,%s,'%" PRIu64 "',%d\n", timestring, id, log_picktype2char(type), itm->nameid, amount, itm->refine, itm->card[0], itm->card[1], itm->card[2], itm->card[3], map[m].name?map[m].name:"", itm->unique_id, itm->bound); + fprintf(logfp,"%s - %d\t%c\t%hu,%d,%d,%hu,%hu,%hu,%hu,%s,'%" PRIu64 "',%d\n", timestring, id, log_picktype2char(type), itm->nameid, amount, itm->refine, itm->card[0], itm->card[1], itm->card[2], itm->card[3], map[m].name[0]?map[m].name:"", itm->unique_id, itm->bound); fclose(logfp); } } diff --git a/src/map/map.cpp b/src/map/map.cpp index 328ff77227..586ae0e23d 100644 --- a/src/map/map.cpp +++ b/src/map/map.cpp @@ -3728,7 +3728,7 @@ static int char_ip_set = 0; int parse_console(const char* buf){ char type[64]; char command[64]; - char mapname[64]; + char mapname[MAP_NAME_LENGTH]; int16 x = 0; int16 y = 0; int n; @@ -3737,7 +3737,7 @@ int parse_console(const char* buf){ memset(&sd, 0, sizeof(struct map_session_data)); strcpy(sd.status.name, "console"); - if( ( n = sscanf(buf, "%63[^:]:%63[^:]:%63s %6hd %6hd[^\n]", type, command, mapname, &x, &y) ) < 5 ){ + if( ( n = sscanf(buf, "%63[^:]:%63[^:]:%11s %6hd %6hd[^\n]", type, command, mapname, &x, &y) ) < 5 ){ if( ( n = sscanf(buf, "%63[^:]:%63[^\n]", type, command) ) < 2 ) { if((n = sscanf(buf, "%63[^\n]", type))<1) return -1; //nothing to do no arg } diff --git a/src/map/mob.cpp b/src/map/mob.cpp index 0b19a7842e..e3d81ad6d2 100644 --- a/src/map/mob.cpp +++ b/src/map/mob.cpp @@ -2732,7 +2732,7 @@ int mob_dead(struct mob_data *md, struct block_list *src, int type) drop_rate_bonus += sd->dropaddrace[md->status.race] + sd->dropaddrace[RC_ALL]; // Increase drop rate if user has SC_ITEMBOOST - if (&sd->sc && sd->sc.data[SC_ITEMBOOST]) + if (sd->sc.data[SC_ITEMBOOST]) drop_rate_bonus += sd->sc.data[SC_ITEMBOOST]->val1; drop_rate_bonus = (int)(0.5 + drop_rate * drop_rate_bonus / 100.); diff --git a/src/map/npc.cpp b/src/map/npc.cpp index 647a765952..8791eea156 100644 --- a/src/map/npc.cpp +++ b/src/map/npc.cpp @@ -2354,8 +2354,8 @@ static void npc_parsename(struct npc_data* nd, const char* name, const char* sta } if( (dnd=npc_name2id(nd->exname)) != NULL ) {// duplicate unique name, generate new one - char this_mapname[32]; - char other_mapname[32]; + char this_mapname[MAP_NAME_LENGTH_EXT]; + char other_mapname[MAP_NAME_LENGTH_EXT]; int i = 0; do { @@ -3935,11 +3935,11 @@ static const char* npc_parse_mob(char* w1, char* w2, char* w3, char* w4, const c static const char* npc_parse_mapflag(char* w1, char* w2, char* w3, char* w4, const char* start, const char* buffer, const char* filepath) { int16 m; - char mapname[32]; + char mapname[MAP_NAME_LENGTH_EXT]; int state = 1; // w1= - if( sscanf(w1, "%31[^,]", mapname) != 1 ) + if( sscanf(w1, "%15[^,]", mapname) != 1 ) { ShowError("npc_parse_mapflag: Invalid mapflag definition in file '%s', line '%d'.\n * w1=%s\n * w2=%s\n * w3=%s\n * w4=%s\n", filepath, strline(buffer,start-buffer), w1, w2, w3, w4); return strchr(start,'\n');// skip and continue @@ -4367,10 +4367,10 @@ int npc_parsesrcfile(const char* filepath, bool runOnInit) if( strcmp(w1,"-") !=0 && strcasecmp(w1,"function") != 0 ) {// w1 = ,,, - char mapname[MAP_NAME_LENGTH*2]; // TODO: Check why this does not use MAP_NAME_LENGTH_EXT + char mapname[MAP_NAME_LENGTH_EXT]; int count2; - count2 = sscanf(w1,"%23[^,],%6hd,%6hd[^,]",mapname,&x,&y); + count2 = sscanf(w1,"%15[^,],%6hd,%6hd[^,]",mapname,&x,&y); if ( count2 < 1 ) { ShowError("npc_parsesrcfile: Invalid script definition in file '%s', line '%d'. Skipping line...\n * w1=%s\n * w2=%s\n * w3=%s\n * w4=%s\n", filepath, strline(buffer,p-buffer), w1, w2, w3, w4); diff --git a/src/map/pc.cpp b/src/map/pc.cpp index 754c81bfa1..713807623a 100755 --- a/src/map/pc.cpp +++ b/src/map/pc.cpp @@ -1695,7 +1695,7 @@ void pc_calc_skilltree(struct map_session_data *sd) if (!(skill_id = skill_idx2id(i)) || skill_id < DC_HUMMING || skill_id > DC_SERVICEFORYOU) continue; - if( &sd->sc && sd->sc.count && sd->sc.data[SC_SPIRIT] && sd->sc.data[SC_SPIRIT]->val2 == SL_BARDDANCER ) { + if( sd->sc.count && sd->sc.data[SC_SPIRIT] && sd->sc.data[SC_SPIRIT]->val2 == SL_BARDDANCER ) { //Link Dancer skills to bard. if( sd->status.sex ) { if( sd->status.skill[i-8].lv < 10 ) @@ -5055,7 +5055,7 @@ int pc_useitem(struct map_session_data *sd,int n) /* Items with delayed consume are not meant to work while in mounts except reins of mount(12622) */ if( id->flag.delay_consume ) { - if( nameid != ITEMID_REINS_OF_MOUNT && &sd->sc && sd->sc.data[SC_ALL_RIDING] ) + if( nameid != ITEMID_REINS_OF_MOUNT && sd->sc.data[SC_ALL_RIDING] ) return 0; else if( pc_issit(sd) ) return 0; @@ -5403,7 +5403,7 @@ int pc_steal_item(struct map_session_data *sd,struct block_list *bl, uint16 skil struct item_data *i_data; char message[128]; i_data = itemdb_search(itemid); - sprintf (message, msg_txt(sd,542), (sd->status.name != NULL)?sd->status.name :"GM", md->db->jname, i_data->jname, (float)md->db->dropitem[i].p/100); + sprintf (message, msg_txt(sd,542), (sd->status.name[0])?sd->status.name :"GM", md->db->jname, i_data->jname, (float)md->db->dropitem[i].p/100); //MSG: "'%s' stole %s's %s (chance: %0.02f%%)" intif_broadcast(message, strlen(message) + 1, BC_DEFAULT); } @@ -6680,7 +6680,7 @@ static void pc_calcexp(struct map_session_data *sd, unsigned int *base_exp, unsi } // Give EXPBOOST for quests even if src is NULL. - if (&sd->sc && sd->sc.data[SC_EXPBOOST]) { + if (sd->sc.data[SC_EXPBOOST]) { bonus += sd->sc.data[SC_EXPBOOST]->val1; if (battle_config.vip_bm_increase && pc_isvip(sd)) // Increase Battle Manual EXP rate for VIP bonus += (sd->sc.data[SC_EXPBOOST]->val1 / battle_config.vip_bm_increase); @@ -6692,7 +6692,7 @@ static void pc_calcexp(struct map_session_data *sd, unsigned int *base_exp, unsi } // Give JEXPBOOST for quests even if src is NULL. - if (&sd->sc && sd->sc.data[SC_JEXPBOOST]) + if (sd->sc.data[SC_JEXPBOOST]) bonus += sd->sc.data[SC_JEXPBOOST]->val1; if (*job_exp) { @@ -9068,7 +9068,7 @@ void pc_setfalcon(struct map_session_data* sd, int flag) *------------------------------------------*/ void pc_setriding(struct map_session_data* sd, int flag) { - if( &sd->sc && sd->sc.data[SC_ALL_RIDING] ) + if( sd->sc.data[SC_ALL_RIDING] ) return; if( flag ){ @@ -10623,7 +10623,7 @@ bool pc_setstand(struct map_session_data *sd, bool force){ // Cannot stand yet // TODO: Move to SCS_NOSTAND [Cydh] - if (!force && &sd->sc && (sd->sc.data[SC_SITDOWN_FORCE] || sd->sc.data[SC_BANANA_BOMB_SITDOWN])) + if (!force && (sd->sc.data[SC_SITDOWN_FORCE] || sd->sc.data[SC_BANANA_BOMB_SITDOWN])) return false; status_change_end(&sd->bl, SC_TENSIONRELAX, INVALID_TIMER); @@ -12139,10 +12139,10 @@ void pc_cell_basilica(struct map_session_data *sd) { nullpo_retv(sd); if (!map_getcell(sd->bl.m,sd->bl.x,sd->bl.y,CELL_CHKBASILICA)) { - if (&sd->sc && sd->sc.data[SC_BASILICA]) + if (sd->sc.data[SC_BASILICA]) status_change_end(&sd->bl,SC_BASILICA,INVALID_TIMER); } - else if (!(&sd->sc) || !sd->sc.data[SC_BASILICA]) + else if (!sd->sc.data[SC_BASILICA]) sc_start(&sd->bl,&sd->bl,SC_BASILICA,100,0,-1); } diff --git a/src/map/skill.cpp b/src/map/skill.cpp index 31c5d17f14..e7b3c2cd3d 100755 --- a/src/map/skill.cpp +++ b/src/map/skill.cpp @@ -635,7 +635,7 @@ static int8 skill_isCopyable(struct map_session_data *sd, uint16 skill_idx) { return 1; //Reproduce can copy skill if SC__REPRODUCE is active and the skill is copyable by Reproduce - if (skill_db[skill_idx]->copyable.option&2 && pc_checkskill(sd,SC_REPRODUCE) && &sd->sc && sd->sc.data[SC__REPRODUCE] && sd->sc.data[SC__REPRODUCE]->val1) + if (skill_db[skill_idx]->copyable.option&2 && pc_checkskill(sd,SC_REPRODUCE) && sd->sc.data[SC__REPRODUCE] && sd->sc.data[SC__REPRODUCE]->val1) return 2; return 0; @@ -705,7 +705,7 @@ bool skill_isNotOk(uint16 skill_id, struct map_session_data *sd) return true; } - if( &sd->sc && sd->sc.data[SC_ALL_RIDING] ) + if( sd->sc.data[SC_ALL_RIDING] ) return true; //You can't use skills while in the new mounts (The client doesn't let you, this is to make cheat-safe) switch (skill_id) { @@ -2954,7 +2954,7 @@ static void skill_do_copy(struct block_list* src,struct block_list *bl, uint16 s if (!tsd || (!pc_checkskill(tsd,RG_PLAGIARISM) && !pc_checkskill(tsd,SC_REPRODUCE))) return; //If SC_PRESERVE is active and SC__REPRODUCE is not active, nothing to do - else if (&tsd->sc && tsd->sc.data[SC_PRESERVE] && !tsd->sc.data[SC__REPRODUCE]) + else if (tsd->sc.data[SC_PRESERVE] && !tsd->sc.data[SC__REPRODUCE]) return; else { uint16 idx; @@ -7191,7 +7191,7 @@ int skill_castend_nodamage_id (struct block_list *src, struct block_list *bl, ui case SL_KAUPE: if (sd) { if (!dstsd || !( - (&sd->sc && sd->sc.data[SC_SPIRIT] && sd->sc.data[SC_SPIRIT]->val2 == SL_SOULLINKER) || + (sd->sc.data[SC_SPIRIT] && sd->sc.data[SC_SPIRIT]->val2 == SL_SOULLINKER) || (dstsd->class_&MAPID_UPPERMASK) == MAPID_SOUL_LINKER || dstsd->status.char_id == sd->status.char_id || dstsd->status.char_id == sd->status.partner_id || @@ -7334,7 +7334,7 @@ int skill_castend_nodamage_id (struct block_list *src, struct block_list *bl, ui if(status_isimmune(bl) || !tsc) break; - if (sd && &sd->sc && sd->sc.data[SC_PETROLOGY_OPTION]) + if (sd && sd->sc.data[SC_PETROLOGY_OPTION]) brate = sd->sc.data[SC_PETROLOGY_OPTION]->val3; if (tsc && tsc->data[type]) { diff --git a/src/map/status.cpp b/src/map/status.cpp index 8aad0b4287..00a5347bd2 100644 --- a/src/map/status.cpp +++ b/src/map/status.cpp @@ -8576,7 +8576,7 @@ int status_change_start(struct block_list* src, struct block_list* bl,enum sc_ty return 0; break; case SC_ALL_RIDING: - if( !sd || !&sd->sc || sc->option&(OPTION_RIDING|OPTION_DRAGON|OPTION_WUGRIDER|OPTION_MADOGEAR) ) + if( !sd || sc->option&(OPTION_RIDING|OPTION_DRAGON|OPTION_WUGRIDER|OPTION_MADOGEAR) ) return 0; if( sc->data[type] ) { // Already mounted, just dismount. diff --git a/src/map/storage.cpp b/src/map/storage.cpp index 1186a271b2..87a005ee3b 100644 --- a/src/map/storage.cpp +++ b/src/map/storage.cpp @@ -43,7 +43,7 @@ const char *storage_getName(uint8 id) { if (storage_db && storage_count) { int i; for (i = 0; i < storage_count; i++) { - if (&storage_db[i] && storage_db[i].id == id && storage_db[i].name && storage_db[i].name[0] != '\0') + if (&storage_db[i] && storage_db[i].id == id && storage_db[i].name[0]) return storage_db[i].name; } } @@ -464,9 +464,6 @@ void storage_storagesave(struct map_session_data *sd) { nullpo_retv(sd); - if (!&sd->storage) - return; - intif_storage_save(sd, &sd->storage); } @@ -479,8 +476,7 @@ void storage_storagesaved(struct map_session_data *sd) if (!sd) return; - if (&sd->storage) - sd->storage.dirty = false; + sd->storage.dirty = false; if (sd->state.storage_flag == 1) { sd->state.storage_flag = 0; @@ -497,9 +493,6 @@ void storage_storageclose(struct map_session_data *sd) { nullpo_retv(sd); - if (!&sd->storage) - return; - if (sd->storage.dirty) { if (save_settings&CHARSAVE_STORAGE) chrif_save(sd, CSAVE_INVENTORY|CSAVE_CART); @@ -525,9 +518,6 @@ void storage_storage_quit(struct map_session_data* sd, int flag) { nullpo_retv(sd); - if (!&sd->storage) - return; - if (save_settings&CHARSAVE_STORAGE) chrif_save(sd, CSAVE_INVENTORY|CSAVE_CART); else @@ -1019,9 +1009,6 @@ void storage_guild_storage_quit(struct map_session_data* sd, int flag) void storage_premiumStorage_open(struct map_session_data *sd) { nullpo_retv(sd); - if (!&sd->premiumStorage) - return; - sd->state.storage_flag = 3; storage_sortitem(sd->premiumStorage.u.items_storage, sd->premiumStorage.max_amount); clif_storagelist(sd, sd->premiumStorage.u.items_storage, sd->premiumStorage.max_amount, storage_getName(sd->premiumStorage.stor_id)); @@ -1053,7 +1040,7 @@ bool storage_premiumStorage_load(struct map_session_data *sd, uint8 num, uint8 m return 0; } - if (!&sd->premiumStorage || sd->premiumStorage.stor_id != num) + if (sd->premiumStorage.stor_id != num) return intif_storage_request(sd, TABLE_STORAGE, num, mode); else { sd->premiumStorage.state.put = (mode&STOR_MODE_PUT) ? 1 : 0; @@ -1071,9 +1058,6 @@ bool storage_premiumStorage_load(struct map_session_data *sd, uint8 num, uint8 m void storage_premiumStorage_save(struct map_session_data *sd) { nullpo_retv(sd); - if (!&sd->premiumStorage) - return; - intif_storage_save(sd, &sd->premiumStorage); } @@ -1085,9 +1069,8 @@ void storage_premiumStorage_saved(struct map_session_data *sd) { if (!sd) return; - if (&sd->premiumStorage) { - sd->premiumStorage.dirty = 0; - } + sd->premiumStorage.dirty = 0; + if (sd->state.storage_flag == 3) { sd->state.storage_flag = 0; clif_storageclose(sd); @@ -1102,9 +1085,6 @@ void storage_premiumStorage_saved(struct map_session_data *sd) { void storage_premiumStorage_close(struct map_session_data *sd) { nullpo_retv(sd); - if (!&sd->premiumStorage) - return; - if (sd->premiumStorage.dirty) { if (save_settings&CHARSAVE_STORAGE) chrif_save(sd, CSAVE_INVENTORY|CSAVE_CART); @@ -1127,9 +1107,6 @@ void storage_premiumStorage_close(struct map_session_data *sd) { void storage_premiumStorage_quit(struct map_session_data *sd) { nullpo_retv(sd); - if (!&sd->premiumStorage) - return; - if (save_settings&CHARSAVE_STORAGE) chrif_save(sd, CSAVE_INVENTORY|CSAVE_CART); else diff --git a/src/map/unit.cpp b/src/map/unit.cpp index 354197c2e5..9645019a95 100644 --- a/src/map/unit.cpp +++ b/src/map/unit.cpp @@ -1158,7 +1158,7 @@ enum e_unit_blown unit_blown_immune(struct block_list* bl, uint8 flag) case BL_PC: { struct map_session_data *sd = BL_CAST(BL_PC, bl); // Basilica caster can't be knocked-back by normal monsters. - if( !(flag&0x4) && &sd->sc && sd->sc.data[SC_BASILICA] && sd->sc.data[SC_BASILICA]->val4 == sd->bl.id) + if( !(flag&0x4) && sd->sc.data[SC_BASILICA] && sd->sc.data[SC_BASILICA]->val4 == sd->bl.id) return UB_TARGET_BASILICA; // Target has special_state.no_knockback (equip) if( (flag&(0x1|0x2)) && sd->special_state.no_knockback )