Mirroristas/rathena
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed wrong double damage calculation for skills in renewal mode (#8260)

Browse Source 
Note by Playtester: In renewal the "battle_calc_skill_base_damage" function adds to the ATK values rather than resetting them, so calling it twice will cause the values to be doubled, so we can't easily use this system for renewal. Will do a follow-up cleanup later.
This commit is contained in:
munkrej 2024-04-20 15:50:27 +02:00 committed by GitHub
parent 3cbdcf999f
commit b5e3e5e69b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/map/battle.cpp
View File

@ -7335,11 +7335,13 @@ static struct Damage battle_calc_weapon_attack(struct block_list *src, struct bl
wd.dmg_lv = ATK_FLEE;
else if(!(infdef = is_infinite_defense(target, wd.flag))) { //no need for math against plants
#ifndef RENEWAL
// First call function with skill_id 0 to get base damage of a normal attack
battle_calc_skill_base_damage(&wd, src, target, 0, 0); // base damage
wd.basedamage = wd.damage;
// Now get actual skill damage
if (skill_id != 0)
#endif
battle_calc_skill_base_damage(&wd, src, target, skill_id, skill_lv); // base skill damage
int64 ratio = 0;