Mirroristas/rathena
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* Small update to the dgbhelpplug plugin:

Browse Source 
- fixed only half of wide character strings being printed
- fixed the memory validity check in Dhp__PrintDataValue being optimized out in release mode

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@12143 54d463be-8e91-2dee-dedb-b68131a5f0ec
This commit is contained in:
FlavioJS 2008-01-27 00:34:24 +00:00
parent b6520cbfd6
commit b605b6d722
4 changed files with 26 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Changelog-Trunk.txt
View File

@ -3,6 +3,11 @@ Date Added
AS OF SVN REV. 5091, WE ARE NOW USING TRUNK. ALL UNTESTED BUGFIXES/FEATURES GO INTO TRUNK. AS OF SVN REV. 5091, WE ARE NOW USING TRUNK. ALL UNTESTED BUGFIXES/FEATURES GO INTO TRUNK.
IF YOU HAVE A WORKING AND TESTED BUGFIX PUT IT INTO STABLE AS WELL AS TRUNK. IF YOU HAVE A WORKING AND TESTED BUGFIX PUT IT INTO STABLE AS WELL AS TRUNK.
2008/01/26
* Small update to the dgbhelpplug plugin: [FlavioJS]
- fixed only half of wide character strings being printed
- fixed the memory validity check in Dhp__PrintDataValue being optimized
out in release mode
2008/01/25 2008/01/25
* Updated conversion tools for mob_db & item_db * Updated conversion tools for mob_db & item_db
* Updated SQL Files (item & mobs) [Toms] * Updated SQL Files (item & mobs) [Toms]

BIN
plugins/dbghelpplug.dll
View File

Binary file not shown.

29
src/plugins/dbghelpplug.c
View File

@ -48,6 +48,7 @@
* + Variables/parameters: * + Variables/parameters:
* - structure members * - structure members
* - union members * - union members
* - globals
* - Portability to MinGW * - Portability to MinGW
* *
* $Id$ * $Id$
@ -673,7 +674,7 @@ Dhp__PrintTypeName(
LocalFree( pSymname ); LocalFree( pSymname );
} }
else else
fprintf(log_file, "<TODO typename of tag %d>", symtag); break; fprintf(log_file, "<TODO typename of symtag %d>", symtag); break;
} }
break; break;
} }
@ -687,7 +688,7 @@ Dhp__PrintTypeName(
/// ///
/// @param log_file Log file /// @param log_file Log file
/// @param p Pointer to the data /// @param p Pointer to the data
/// @param length Length of the data /// @param length Length of the data in bytes
static VOID static VOID
Dhp__PrintValueBytes( Dhp__PrintValueBytes(
FILE* log_file, FILE* log_file,
@ -709,7 +710,7 @@ Dhp__PrintValueBytes(
/// ///
/// @param log_file Log file /// @param log_file Log file
/// @param p Pointer to the value /// @param p Pointer to the value
/// @param length Length of the value /// @param length Length of the value in bytes
static VOID static VOID
Dhp__PrintValueWideChars( Dhp__PrintValueWideChars(
FILE* log_file, FILE* log_file,
@ -760,7 +761,7 @@ Dhp__PrintValueWideChars(
/// ///
/// @param log_file Log file /// @param log_file Log file
/// @param p Pointer to the value /// @param p Pointer to the value
/// @param length Length of the value /// @param length Length of the value in bytes
static VOID static VOID
Dhp__PrintValueChars( Dhp__PrintValueChars(
FILE* log_file, FILE* log_file,
@ -802,7 +803,7 @@ Dhp__PrintValueChars(
/// ///
/// @param log_file Log file /// @param log_file Log file
/// @param p Pointer to the value /// @param p Pointer to the value
/// @param length Length of the value /// @param length Length of the value in bytes
static VOID static VOID
Dhp__PrintValueFloat( Dhp__PrintValueFloat(
FILE* log_file, FILE* log_file,
@ -824,7 +825,7 @@ Dhp__PrintValueFloat(
/// ///
/// @param log_file Log file /// @param log_file Log file
/// @param p Pointer to the value /// @param p Pointer to the value
/// @param length Length of the value /// @param length Length of the value in bytes
static VOID static VOID
Dhp__PrintValueHex( Dhp__PrintValueHex(
FILE* log_file, FILE* log_file,
@ -850,7 +851,7 @@ Dhp__PrintValueHex(
/// ///
/// @param log_file Log file /// @param log_file Log file
/// @param p Pointer to the value /// @param p Pointer to the value
/// @param length Length of the value /// @param length Length of the value in bytes
static VOID static VOID
Dhp__PrintValueUnsigned( Dhp__PrintValueUnsigned(
FILE* log_file, FILE* log_file,
@ -876,7 +877,7 @@ Dhp__PrintValueUnsigned(
/// ///
/// @param log_file Log file /// @param log_file Log file
/// @param p Pointer to the value /// @param p Pointer to the value
/// @param length Length of the value /// @param length Length of the value in bytes
static VOID static VOID
Dhp__PrintValueSigned( Dhp__PrintValueSigned(
FILE* log_file, FILE* log_file,
@ -918,13 +919,13 @@ Dhp__PrintValueCWideString(
} }
__except( EXCEPTION_EXECUTE_HANDLER ) __except( EXCEPTION_EXECUTE_HANDLER )
{ {
if( length ) Dhp__PrintValueWideChars(log_file, str, length, TRUE); // print readable part if( length ) Dhp__PrintValueWideChars(log_file, str, length*sizeof(WCHAR), TRUE); // print readable part
fprintf(log_file, "<invalid memory>"); fprintf(log_file, "<invalid memory>");
return; return;
} }
// print string // print string
Dhp__PrintValueWideChars(log_file, str, length, TRUE); Dhp__PrintValueWideChars(log_file, str, length*sizeof(WCHAR), TRUE);
} }
@ -950,13 +951,13 @@ Dhp__PrintValueCString(
} }
__except( EXCEPTION_EXECUTE_HANDLER ) __except( EXCEPTION_EXECUTE_HANDLER )
{ {
if( length ) Dhp__PrintValueChars(log_file, str, length, TRUE); // print readable part if( length ) Dhp__PrintValueChars(log_file, str, length*sizeof(char), TRUE); // print readable part
fprintf(log_file, "<invalid memory>"); fprintf(log_file, "<invalid memory>");
return; return;
} }
// print string // print string
Dhp__PrintValueChars(log_file, str, length, TRUE); Dhp__PrintValueChars(log_file, str, length*sizeof(char), TRUE);
} }
@ -1003,9 +1004,9 @@ Dhp__PrintDataValue(
{ {
BYTE* p = (BYTE*)pVariable; BYTE* p = (BYTE*)pVariable;
ULONG i; ULONG i;
BYTE b; BYTE b = 0;
for( i = 0; i < length; ++i ) for( i = 0; i < length; ++i )
b = p[i]; b += p[i]; // add to make sure it's not optimized out in release mode
} }
__except( EXCEPTION_EXECUTE_HANDLER ) __except( EXCEPTION_EXECUTE_HANDLER )
{ {

8
src/plugins/dbghelpplug.rc
View File

@ -3,11 +3,11 @@
#include "winres.h" #include "winres.h"
#endif // !defined(__BORLANDC__) #endif // !defined(__BORLANDC__)
#define VER_FILEVERSION 1,0,0,1 #define VER_FILEVERSION 1,0,0,2
#define VER_FILEVERSION_STR "1.0.0.1\0" #define VER_FILEVERSION_STR "1.0.0.2\0"
#define VER_PRODUCTVERSION 1,0,0,1 #define VER_PRODUCTVERSION 1,0,0,2
#define VER_PRODUCTVERSION_STR "1.0.0.1\0" #define VER_PRODUCTVERSION_STR "1.0.0.2\0"
#if defined(DEBUG) || defined(_DEBUG) #if defined(DEBUG) || defined(_DEBUG)
#define VER_DEBUG 0 #define VER_DEBUG 0