From c9f075b8c6245fe002c1bc7aab18df3f9c352a0f Mon Sep 17 00:00:00 2001
From: Aleos <aleos89@users.noreply.github.com>
Date: Mon, 19 Sep 2022 16:17:45 -0400
Subject: [PATCH] Adds support for the new form for issues (#7278)

* Adds support for the new GitHub form templates for issues and feature requests.
* Makes hard requirements for details we need before being able to submit issues.
* Disables empty bug reports.
Thanks to @Lemongrass3110!
---
 .github/ISSUE_TEMPLATE/bug_report.md       | 74 --------------------
 .github/ISSUE_TEMPLATE/bug_report.yml      | 79 ++++++++++++++++++++++
 .github/ISSUE_TEMPLATE/config.yml          |  8 +++
 .github/ISSUE_TEMPLATE/feature_request.md  | 35 ----------
 .github/ISSUE_TEMPLATE/feature_request.yml | 32 +++++++++
 5 files changed, 119 insertions(+), 109 deletions(-)
 delete mode 100644 .github/ISSUE_TEMPLATE/bug_report.md
 create mode 100644 .github/ISSUE_TEMPLATE/bug_report.yml
 create mode 100644 .github/ISSUE_TEMPLATE/config.yml
 delete mode 100644 .github/ISSUE_TEMPLATE/feature_request.md
 create mode 100644 .github/ISSUE_TEMPLATE/feature_request.yml

diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
deleted file mode 100644
index 72094af8e5..0000000000
--- a/.github/ISSUE_TEMPLATE/bug_report.md
+++ /dev/null
@@ -1,74 +0,0 @@
----
-name: Bug report
-about: Create an Issue that details broken or unexpected behaviour
-title: ''
-labels: type:bug
-assignees: ''
-
----
-
-<!-- NOTE: Anything within these brackets will be hidden on the preview of the Issue. -->
-<!-- NOTE: Failure to fill out this template correctly may cause a repository maintainer to close your Issue. -->
-
-
-## Required Basic Information
-
-<!-- STEP 1 ~ Specify Github Hash
-Please specify the rAthena [GitHub hash](https://help.github.com/articles/autolinked-references-and-urls/#commit-shas) on which you encountered this issue. 
-How to get your GitHub Hash:
-1. cd your/rAthena/directory/
-2. git rev-parse --short HEAD
-3. Copy the resulting hash.
--->
-
-**rAthena Hash**: 
-
-
-<!-- STEP 2 ~ Specify the client date you are using when this Issue occured. -->
-
-**Client Date**: 
-
-
-<!-- STEP 3 ~ Specify the server-mode you are using when this Issue occured.
-Options: Pre-Renewal / Renewal -->
-
-**Server Mode**: 
-
- 
-
-## Required Detailed Information
-
-<!-- STEP 4 ~ Answer the following questions in as much detail as possible.
-The more information you provide, the easier it will be to confirm and fix an Issue.
-NOTE: Make sure you quote ``` `@atcommands` ``` just like this so that you do not tag uninvolved GitHub users!
-NOTE: When pasting code, you can use codeblocks through the editor, or by placing your code between three backticks like this: ``` code here ```
-TIP: When answering each question, you can remove the "help-comments" so you can type single-line answers.
-TIP: Above this box there is a "preview" tab which will show you what your Issue will look like after you submit it. Please use it.
--->
-
-<!-- Describe the issue that you experienced in detail. -->
-**Result**: 
-
-
-<!-- Describe what you would expect to happen in detail. -->
-**Expected Result**: 
-
-
-<!-- If you have not stated in the description of the result already, please give us a short guide how we can reproduce your issue. -->
-**How to Reproduce**: 
-
-
-<!-- If possible, provide information from official servers (kRO or other sources) which prove that the result is wrong. Please take into account that iRO (especially iRO Wiki) is not always the same as kRO. -->
-**Official Information**: 
-
-
-
-<!-- STEP 5 ~ If you are using any modifications, especially in /src/, you must type them here.
-Even the smallest changes can cause things to break. We need to know what you have customized.
-This can be either configurations you changed, database values you changed, or even external source modifications. -->
-
-**Modifications that may affect results**: 
-
-
-<!-- STEP 6 ~ Re-read your Issue above before submitting it, ensuring every question has been answered correctly. -->
-
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
new file mode 100644
index 0000000000..6639b991e7
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -0,0 +1,79 @@
+name: Bug Report
+description: Create an Issue that details broken or unexpected behaviour
+labels: ["type:bug"]
+body:
+  - type: input
+    id: hash
+    attributes:
+      label: rAthena Hash
+      description: Please specify the rAthena [GitHub hash](https://help.github.com/articles/autolinked-references-and-urls/#commit-shas) on which you encountered this issue.
+    validations:
+      required: true
+  - type: input
+    id: date
+    attributes:
+      label: Client Date
+      description: Specify the client date you are using when this Issue occured.
+      placeholder: YYYY-MM-DD
+    validations:
+      required: true
+  - type: dropdown
+    id: mode
+    attributes:
+      label: Server Mode
+      description: Specify the server-mode you are using when this Issue occured.
+      multiple: true
+      options:
+        - Pre-Renewal
+        - Renewal
+    validations:
+      required: true
+  - type: textarea
+    id: result
+    attributes:
+      label: Result
+      description: Describe the issue that you experienced in detail.
+      placeholder: |
+        1. In this environment...
+        2. With this config...
+        3. Trigger event '...'
+        4. See error...
+    validations:
+      required: true
+  - type: textarea
+    id: logs
+    attributes:
+      label: Relevant Log Output
+      description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks.
+      render: Shell
+    validations:
+      required: false
+  - type: textarea
+    id: expected
+    attributes:
+      label: Expected Result
+      description: Describe what you would expect to happen in detail.
+    validations:
+      required: true
+  - type: textarea
+    id: howto
+    attributes:
+      label: How to Reproduce
+      description: If you have not stated in the description of the result already, please give us a short guide how we can reproduce your issue.
+    validations:
+      required: true
+  - type: textarea
+    id: info
+    attributes:
+      label: Official Information
+      description: If possible, provide information from official servers (kRO or other sources) which prove that the result is wrong. Please take into account that iRO (especially iRO Wiki) is not always the same as kRO.
+    validations:
+      required: true
+  - type: textarea
+    id: modifications
+    attributes:
+      label: Modifications that may affect results
+      description: |
+        If you are using any modifications, especially in /src/, you must type them here.
+        Even the smallest changes can cause things to break. We need to know what you have customized.
+        This can be either configurations you changed, database values you changed, or even external source modifications.
diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml
new file mode 100644
index 0000000000..f2f1979d29
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/config.yml
@@ -0,0 +1,8 @@
+blank_issues_enabled: false
+contact_links:
+  - name: rAthena Community Support
+    url: https://rathena.org/board/forum/3-support-releases/
+    about: Please ask and answer questions here in our forum.
+  - name: rAthena Discord
+    url: https://rathena.org/board/discord/
+    about: Chat with us in the Discord support channel.
diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md
deleted file mode 100644
index 820adadf89..0000000000
--- a/.github/ISSUE_TEMPLATE/feature_request.md
+++ /dev/null
@@ -1,35 +0,0 @@
----
-name: Feature request
-about: Suggest an idea for this project
-title: ''
-labels: type:enhancement
-assignees: ''
-
----
-
-<!-- NOTE: Anything within these brackets will be hidden on the preview of the Feature Request. -->
-
-**Is your request related to a missing feature?**
-
-<!--
-  Provide a clear and concise description of what the feature pertains to.
--->
-
-**Describe the solution you'd like**
-
-<!--
-  Provide a clear and concise description of what you want to happen.
--->
-
-**Describe alternatives you've considered**
-
-<!--
-  Let us know about other solutions you've tried or researched.
--->
-
-**Additional context**
-
-<!--
-  Is there anything else you can add about the proposal?
-  You might want to link to related issues here if you haven't already.
--->
diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml
new file mode 100644
index 0000000000..d960ef1bbb
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/feature_request.yml
@@ -0,0 +1,32 @@
+name: Feature Request
+description: Suggest an idea for this project
+labels: ["type:enhancement"]
+body:
+  - type: dropdown
+    id: missing
+    attributes:
+      label: Is your request related to a missing official feature?
+      options:
+        - "Yes"
+        - "No"
+    validations:
+      required: true
+  - type: textarea
+    id: solution
+    attributes:
+      label: Describe the solution you'd like
+      description: Provide a clear and concise description of what you want to happen.
+    validations:
+      required: true
+  - type: textarea
+    id: alternatives
+    attributes:
+      label: Describe alternatives you've considered
+      description: Let us know about other solutions you've tried or researched.
+  - type: textarea
+    id: context
+    attributes:
+      label: Additional context
+      description: |
+        Is there anything else you can add about the proposal?
+        You might want to link to related issues here if you haven't already.