Mirroristas/rathena
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Added checks for the length of a skill's name and description

Browse Source
This commit is contained in:
Lemongrass3110 2024-03-11 00:27:36 +01:00
parent ddf9270967
commit ccb646d12c
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/map/skill.cpp
View File

@ -23938,18 +23938,28 @@ uint64 SkillDatabase::parseBodyNode(const ryml::NodeRef& node) {
if (!this->asString(node, "Name", name))
return 0;
if( name.length() > SKILL_NAME_LENGTH ){
this->invalidWarning( node["Name"], "Name \"%s\" exceeds maximum length of %d.\n", name.c_str(), SKILL_NAME_LENGTH );
return 0;
}
name.resize(SKILL_NAME_LENGTH);
memcpy(skill->name, name.c_str(), sizeof(skill->name));
}
if (this->nodeExists(node, "Description")) {
std::string name;
std::string desc;
if (!this->asString(node, "Description", name))
if (!this->asString(node, "Description", desc))
return 0;
name.resize(SKILL_DESC_LENGTH);
memcpy(skill->desc, name.c_str(), sizeof(skill->desc));
if( desc.length() > SKILL_DESC_LENGTH ){
this->invalidWarning( node["Description"], "Description \"%s\" exceeds maximum length of %d.\n", desc.c_str(), SKILL_DESC_LENGTH );
return 0;
}
desc.resize(SKILL_DESC_LENGTH);
memcpy(skill->desc, desc.c_str(), sizeof(skill->desc));
}
if (this->nodeExists(node, "MaxLevel")) {