8488 Commits

Author SHA1 Message Date
Cydh Ramdh
1210bca097 Moved hardcoded timestamp format for log files to conf/log_athena.conf::log_timestamp_format
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-10 11:38:00 +07:00
aleos89
cef2f9ea63 Bug Fixes
* Fixes #629 - Removed an extra costume check during action requests.
* Fixes #632 - Fixed long broadcast messages getting truncated.
* Fixes #635 - Fixed Elementals getting removed twice from a map during map_quit().
* Fixes #639 - Adjusted two checks from status_get_sc_def() so that tick_def2 is properly adjusted when pc_sc_def_rate is adjusted in battle config.
* Fixes #645 - Fixed atcommand 'iteminfo' displaying items not dropping from any monsters when battle flag 'mobinfo_type' is active.
* Fixes #652 - Don't call clif_scriptclose() on script command 'close' and script command 'end' when an NPC shop is active.
* Fixes #670 - Resolved a possible map crash when using the Lux Anima Runestone.
2015-10-09 18:22:35 -04:00
Lemongrass3110
982d6c1f87 Fixed a warning
(unused variable i)
2015-10-09 17:25:49 +02:00
Lemongrass3110
f110657034 Minor cleanup 2015-10-09 17:19:15 +02:00
Lemongrass3110
45e50a3d24 Fixed questlog display for clients from 2014-10-22 on 2015-10-09 00:24:25 +02:00
Cydh Ramdh
fd7d6c31fd Follow up 99783689, typos. Thank @WhySoSexyMate
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-08 15:41:33 +07:00
Lemongrass3110
bba5e4f425 Added compile time checks whether to enable or disable pincode system code 2015-10-07 20:57:37 +02:00
Lemongrass3110
c1623fd5dc Added an unsupported enum value for documentation reasons 2015-10-07 20:20:29 +02:00
Lemongrass3110
10c2dc10dc Pincode Functionality Extension
Added some options to allow or disallow certain combinations in the pincode as aegis has it.
In AEGIS it is not allowed to use pincodes like 0000 or 1111 where the pincode only contains 1 character. It is also not allowed to use sequences like 1234 or 5678.

In addition to the official check, which only disallows ascending sequences I also added descending ones.
2015-10-07 00:15:11 +02:00
Cydh Ramdh
c9c988abba * Fixed #654, TF_BACKSLIDE failed if player has 'no knock back' bonus.
* Clean up on buildin scripts, to use constant in return value.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-10-03 22:29:46 +07:00
Lemongrass3110
a597e7bd34 Some more pointer casts and enum fixes. 2015-10-03 01:46:47 +02:00
Lemongrass3110
a760e01c59 Follow up to 78b6c15
Fixed a possible buffer overflow in mapindex.c
2015-10-02 20:31:07 +02:00
Lemongrass3110
78b6c150d2 Added usage of enum values in script.c in some places. 2015-10-02 15:09:01 +02:00
Nova
7bc7b7e449 Magna Eruption Status Effects
This line makes the status effects actually apply. (Burning and Stun)
2015-10-01 09:28:36 -07:00
Cydh Ramdh
e112fc1c50 Fixed #647. Fail to get parameter value from readparam if the parameter given is constant as param-type value. So for an example, readparam(BaseLevel) will be fine now, the result same as like BaseLevel itself.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-27 21:44:54 +07:00
Cydh Ramdh
725903e3ce Fixed a typo
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-26 11:18:07 +07:00
Cydh Ramdh
230811c8ab Bug fixes:
* Fixed #651, now quest_db is separated between Renewal and Pre-Renewal to avoid non-existent monster/item (current missing monster/items are removed on Pre-Renewal). Thank @lordganja.
* Fixed #622, cast warning in script.c::get_val2. Thank @Litro .

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-24 07:41:02 +07:00
Cydh Ramdh
d0d14d04be Just spaces in cli.c
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-23 22:01:17 +07:00
Cydh Ramdh
2bb69a3c54 Follow up 039e1b65a3cae96d80b220f078814cac72846737. Fixed #644, fixed #643. Thank @ernestfegarido, @Dark8008
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-18 17:45:45 +07:00
aleos89
039e1b65a3 Quest System Update
* Added support for the new quests that grant item drops from mobs.
2015-09-17 13:24:42 -04:00
Cydh Ramdh
2fc20c460d Follow up f669072e854ae5b67606788b81e16a5f6b92d236 and fa40773e8222cb5d6ac66782f8136b9833c8760d
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-16 20:00:49 +07:00
Cydh Ramdh
f669072e85 Fixed #638
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-16 16:06:09 +07:00
Cydh Ramdh
631747bb07 * Fixed memleak when use @set command for string type variable.
* Removed `0x2715` and `logchrif_parse_updmail`, not being used that was duplicated by `logchrif_parse_reqchangemail` (`0x2722`).
* Changed packet header `0x2736` to `0x2b13` of `chrif_update_ip` from map-server to char-server. That was ambiguous with `0x2736` of `logchrif_parse_updcharip` that being used by char-server to login-server.
* Changed packet header `0x3804` to `0x2726`, the one that being used to send back global account reg from login-server to char-server. That was ambiguous with `0x3804` that being used by char-server (was inter actually) to map-server.
* Some indent clean up as result from char & login server refactor.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-14 20:17:12 +07:00
Napster
ecd0ccd652 Merge branch 'master' of https://github.com/rathena/rathena 2015-09-13 08:49:48 +07:00
Napster
e56f329d5d Follow up fa40773 :
* Revert change some code
2015-09-13 08:48:53 +07:00
Cydh Ramdh
b0f4595688 * Updated doc/packet_interserv.txt
* Added `skill_dummy2skill_id` in `battle_skill_damage`

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-13 08:10:59 +07:00
Napster
93666ce79a Follow up fa40773 :
* Fixed compile warning.
2015-09-12 22:40:43 +07:00
Napster
fa40773e82 * Fixed #630 Cart is not showing. 2015-09-12 21:51:03 +07:00
Cydh Ramdh
d301d1ecb3 * Fixed #633 compile warning. Thank @tmav94
* Move out `enum chrif_req_op` to socket.h so can be used too for `char_mapif.c`

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-12 10:18:32 +07:00
Cydh Ramdh
e933db556f Checked some preprocessors on mmo.h and core.h
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-09 21:05:07 +07:00
Cydh Ramdh
9cee995f3f Fixed variable type mismatch for autotraders
* `struct s_autotrader::id` was `uint16`, should be `uint32`.
* `struct s_autotrade_entry::cartinventory_id` was `uint16`, should be `uint32`.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-08 21:52:42 +07:00
Cydh Ramdh
fc2c6a34ff * Fixed #625, autocast state wasn't reseted on failed. Thank @Jeybla.
* A little check for timer id on map_clearflooritem.
* A little clean up for RL_FALLEN_ANGEL's flow.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-07 21:42:56 +07:00
Cydh Ramdh
997836897f Follow up 43068e1777d4b75baa3f36e1c5ff13ca5289e0f4:
* Eff_Crystalize on Sropho_Card (4522) has defined duration.
* Bonus added:
  * `bonus4 bAddEff,eff,n,y,t;`
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when attacking
    * Just like `bonus3 bAddEff,eff,n,y;` but with user-defined duration;
  * `bonus4 bAddEffWhenHit,eff,n,y,t;`
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when being hit by physical damage
    * Just like `bonus3 bAddEffWhenHit,eff,n,y;` but with user-defined duration;
  * bonus5 bAddEffOnSkill,sk,eff,n,y,t;
    * Adds a n/100% chance to cause status eff for t milliseconds on the target when using skill sk
    * Just like `bonus4 bAddEffOnSkill,sk,eff,n,y;` but with user-defined duration;

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-05 08:19:23 +07:00
Cydh Ramdh
31505d1423 * Fixed #607:
* Added array variable option in 3rd param of `getguildmember` and `getpartymember`, so the script will returns the result in reserved array instead using temporary global variable.
  * Also, the script returns the member found directly.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-04 00:32:38 +07:00
aleos89
df35f33480 Renewal Skill Cast Time Updates
* Updated a fair amount of skill cast times to official.
* Cold Slower will only give Freezing if the target wasn't given Frozen.
* Sound of Destruction will now Stun targets if a Performance/Chorus is removed for 5 seconds.
* Updated the Burning (15 seconds), Freezing (40 seconds), Bleeding (120 seconds), and Stun (5 seconds) durations for Tetra Vortex.
* Xeno Slasher will only cause Bleeding at SkillLevel%.
* Corrected a few issues with Reading Spell Book storage.
* Corrected Fire Walk and Electric Walk to only last for 12 seconds in a cell and the skill's duration to last for 30 seconds.
2015-09-03 12:46:25 -04:00
Cydh Ramdh
b5f2f0ae8f * Fixed #610, PR_IMPOSITIO: Lower levels of Impositio Manus will overwrite higher levels. For example, someone with level 5 IM activated will have +25 ATK from the skill, but if level 1 IM were used on them their ATK would drop to only +5. Therefore, this skill can be used offensively.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-03 23:09:13 +07:00
Cydh Ramdh
4a55439550 * Typo in const.txt for SC with ID 608, SC_HASTEATTACK_CASH -> SC_ATTHASTE_CASH.
* Move 'dummy' skill lookup to `skill_dummy2skill_id` so can be used for item bonus for revelant skill.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-09-02 23:02:13 +07:00
aleos89
ebaefc1476 Bug Fix
* Fixes #615 - Fixed script command 'query_sql' not returning any results.
2015-09-02 10:32:00 -04:00
Aleos
6295c77d39 Merge pull request #457 from rathena/feature/script_engine_upgrade
Script Engine Upgrade
* More information here: https://rathena.org/board/topic/102946-script-engine-upgrade/
2015-08-31 14:26:15 -04:00
aleos89
3452b931b9 Small Changes
* Renamed SQL upgrade file.
* Fixed a buffer overflow in 'set' atcommand.
2015-08-31 14:15:30 -04:00
aleos89
04d2ab7d1c Partial revert of eb0a79f
* Copying skill issue was previously fixed in c4da965.
2015-08-31 10:21:19 -04:00
aleos89
eb0a79f1bf Bug Fixes
* Fixes #587 - Corrected Amistr Defence to properly calculate VIT for renewal and DEF for pre-renewal.
* Fixes #588 - Fixed skills not being properly removed when being copied by Plagiarism or Reproduce.
* Fixes #589 - Blessing no longer gives stat bonuses when Curse is active.
* Fixes #599 - Fixed a possible crash by Praefatio.
* Fixes #601 - Exceed Break now cancels when switching weapons and is properly removed on misses.
2015-08-28 15:05:24 -04:00
Napster
e444270b0a Follow up to 53868d5
* Fixed #600, Hotkey Rotate Packet Implemented, Thank You @dastgir

Credits : Hercules 2b4b33b06a
2015-08-28 16:32:23 +07:00
Cydh Ramdh
c4da965ee6 Item DB Updates
* Added items from idRO patch 19/8

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-26 12:19:49 +07:00
aleos89
b8f6e16f9d Follow up to 9738c82
* Fixed some more memory leaks.
* Added a few checks that were left out/removed by mistake.
2015-08-25 13:23:23 -04:00
aleos89
9738c825cc Follow up to f53916e
* Fixed remaining memory leak.
* Cleaned up and optimized a few more ERS allocations.
2015-08-25 10:31:38 -04:00
Napster
53868d5850 Another follow up 3d9c6e7
* Added 'missing' packets for 2014-10-22, open roulette windows by short cut (ctrl+F12)
2015-08-24 09:51:29 +07:00
aleos89
f53916e060 Script Engine Fixes
* Cleaned up db_vdestroy errors at server shutdown.
* Expanded the ERS system. Thanks to Hercules.
* Added ERS to the database trees to speed up iterator memory allocation. Thanks to Hercules.
2015-08-21 15:16:52 -04:00
aleos89
3fbac9c8e4 Bug Fixes
* Fixes #586 - Resolved some compile warnings.
* Fixes #584 - Cleaned up the success rate and duration for Sling bombs.
- Banana Bomb now reduces LUK by 75.
- Throwing Cure Free now removes Poison, Orcish, Change Undead, Blind, Confusion, Deadly Poison, and heals a static 500 HP.
- Updated pre-renewal Genetic items to match renewal.
2015-08-21 10:45:46 -04:00
Cydh Ramdh
0574b22902 Fixed #583, some correction on skill_unit_group X skill_unit usage. Thank @theultramage
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-19 17:08:27 +07:00