8253 Commits

Author SHA1 Message Date
Aleos
75aef6a544
Corrected AutospellOnSkill (#3770)
* Fixes #3769.
* Added a missing reference call.
* Defaulted item bonus entries to 0/nullptr.
Thanks to @laziem!
2018-12-19 18:09:24 -05:00
Lemongrass3110
7c271d7edc
Disabled iterator sanity checks on VS (#3760)
Fixes #3750

Thanks to @teededung and @aleos89
2018-12-18 18:51:56 +01:00
Lemongrass3110
016d15b79a
Unified infinite tick usage (#3755)
Introducing a new constant INFINITE_TICK
Changed current usages in items, npcs and source to use the new and correct constant.
Replaced some invalid usages of INVALID_TIMER and replaced them with the new constant.
2018-12-18 17:46:56 +01:00
Lemongrass3110
e3dd6238b5
Removed deprecated SI constants from src (#3762)
Froze their values by hardcoding them into the script engine exports.
Removed commented ones.
Removed a leftover reference to SI_BLANK.
2018-12-18 15:54:54 +01:00
Aleos
570c07d50c
Corrected some Summoner skills (#3719)
* Fixes #3706.
* Resolved Blessing of Shrimp not boosting SP recovery properly.
* Resolved Tasty Shrimp Party not accounting for Fresh Shrimp level learned.
* Resolved Lope not placing the caster at the selected target location.
Thanks to @Everade and @exneval!
2018-12-17 21:51:50 -05:00
Lemongrass3110
742232d575
Fixed zero termination for bg messages (#3759)
Fixes #3104

Thanks to @Rolfxx and @vstumpf
2018-12-18 02:32:37 +01:00
Aleos
faee0cde45
Fixed CN Meteor and Lunatic Carrot Beat damage (#3746)
* Fixes #3734.
* Added missing battle cases.
Thanks to @teededung and @Playtester!
2018-12-17 19:47:34 -05:00
Lemongrass3110
7fa903ce22
Fixed SU_GROOMING while being frozen (#3756)
Fixes #3728

Thanks to @Everade
2018-12-17 14:14:58 +01:00
Lemongrass3110
9183a54a0d
Fixed homunculus auto feed for broken luas (#3758)
Fixes #3318

Thanks to @yoonjunho72, @AzarthMZintos and @admkakaroto
2018-12-17 13:53:37 +01:00
Lemongrass3110
e8a7daec9f
Fixed pre-renewal atk (#3752)
Follow up fe197bfa120aef5fd31c6896122b35fdc06774b4

Fixes #3623

Thanks to @mrjnumber1
2018-12-15 17:04:03 +01:00
Aleos
2d4a594948
Fixed Skill Damage Database parsing (#3747)
* Fixed Skill Damage Database parsing
* Fixes #3732.
* Resolved an issue with constants not being properly parsed for the caster type.
Thanks to @RadianFord, @reunite-ro, and @Lemongrass3110!
2018-12-14 16:05:58 -05:00
Lemongrass3110
18f9574a52
Fixed missing login date for guild members (#3744)
Fixes #3743
2018-12-12 00:23:08 +01:00
Jittapan Pluemsumran
4cff45b881 Fixed clearing of sp_vanish_race (#3729) 2018-12-08 20:03:58 +01:00
Aleos
32c68c73bf
Renewal bBaseAtk readparam returning wrong value (#3731)
* Corrects readparam returning the wrong value for bBaseAtk.
2018-12-07 10:23:46 -05:00
Lemongrass3110
5597105451 Fixed an issue with bonus recalculation
Fixes #3725

Thanks to @jester-frost and @laziem
2018-12-06 22:26:35 +01:00
rAthenaAPI
f233792f53 Mob and NPC Identity Update 2018-12-05 05:01:02 +01:00
Lemongrass3110
40a4edc4f8 Follow up to e02e85b
Fixes #3721

Thanks to @teededung
2018-12-01 11:19:08 +01:00
Aleos
6a49dc2b90
Corrected possible item loss during char login (#3714)
* Resolved a rare case if a player logs in and the server hasn't fully initialized all of the player's items that the auto-save timer fires off and saves the player with no items.
Thanks to @Tokeiburu!
2018-11-30 09:33:44 -05:00
Aleos
0bb279b64c
Corrected Stone Hard Skin Rune effects (#3713)
* Fixes #3693.
* Stone Hard Skin should not end after taking full damage.
Thanks to @slyx88 and @flamefury!
2018-11-30 09:06:36 -05:00
Aleos
5cc368a177
Corrected a potential overflow in item bonuses (#3709)
* Fixes #3703.
* Fixed bHealPower, bHealPower2, bSPGainValue, bHPGainValue, bMagicSPGainValue, and bMagicHPGainValue having a chance to potentially overflow from signed short limit.
Thanks to @Everade!
2018-11-29 18:54:59 -05:00
Aleos
e02e85b65e
Corrected White Imprison and reflected damage (#3685)
* Fixes #3634.
* Targets in White Imprison using reflect equipment or skills should not send damage back to those outside.
Thanks to @admkakaroto!
2018-11-29 18:13:06 -05:00
Aleos
a0d1087628
Corrected Electric Shocker versus MVP (#3660)
* Fixes #3649.
* Electric Shocker is able to stop MVP as well.
* Status should not stack with itself.
* Status should be cleared by normal means.
Thanks to @admkakaroto!
2018-11-29 17:51:00 -05:00
Aleos
9758a38f07
Updated CN Meteor and Lunatic CB behavior (#3603)
* Implements SU_CN_METEOR2 and SU_LUNATICCARROTBEAT2 skills.
* These skills are used as placeholders for the item requirements for skill bonuses.
Thanks to @Rytech2 and @exneval!
2018-11-29 17:23:09 -05:00
Lemongrass3110
bff89bd70e
Fixed possible string out of bounds in configurations (#3631)
Added safestrncpy to char's inter configurations
Added safestrncpy to map's inter configurations
Added safestrncpy to message configurations
Adjusted some char configurations
Cleaned up logging configurations

Fixes #3624 

Thanks to @mrjnumber1
2018-11-29 22:56:17 +01:00
Lemongrass3110
bde580fdbd
Add drop highlighting effect feature (#3710)
Fixes #3610

Thanks to @Balferian, @admkakaroto and credits to @Asheraf
2018-11-29 22:34:57 +01:00
Aleos
c71ef92fb0
Refactored item bonuses to utilize C++ features (#3235)
* Fixes #996 and fixes #3152.
* Refactored MAX_PC_BONUS item bonuses from static arrays to vectors.
* Increased MAX_PC_BONUS to 50.
* Frees up memory from players that may not ever utilize all their static MAX_PC_BONUS item bonuses.
* Expanded bonus ResEff to not be restricted to SC_COMMON* statuses.
* Removed old ERS usages.
* Removed code redundancy and general cleanups.
Thanks to @Angelic234, @Atemo, @Lemongrass3110, and @Everade!
2018-11-28 21:50:43 -05:00
Aleos
eafb1cb7f9
Corrected Absorb Spirit Sphere on self (#3689)
* Fixes #3534.
* Absorb Spirit Sphere should work on self on all map types.
Thanks to @FriggRM!
2018-11-28 13:11:35 -05:00
Aleos
47d76205c0
Resolved Small and Large Life Potion Healing (#3712)
* Fixes #3705.
* Heal rate was comparing battle status versus base status.
Thanks to @Everade!
2018-11-27 22:26:16 -05:00
Aleos
505a0cd888
Fixed a potential crash on change map events (#3699)
* Fixes #3687.
* When changing to an unknown map (or one on another map-server) the instance checks attempted to check null data.
Thanks to @lelouch22!
2018-11-27 09:46:20 -05:00
Aleos
16c2f22fed
Corrected Fire Charm and Exploding Dragon damage (#3700)
* Fixes #3695.
* Fire Charm was granting too much bonus damage when used with Exploding Dragon.
Thanks to @Balferian!
2018-11-27 09:26:43 -05:00
Aleos
7cc44e55ca
Corrected trap splash count (#3683)
* Fixes #3675.
* Corrected the trap splash count to be a minimum of 1 to prevent divide by 0 attempts.
Thanks to @crazystorm2017!
2018-11-17 08:57:30 -05:00
Aleos
a8f01ecc0b
Corrected Raid damage for renewal (#3648)
* Corrected Raid damage ratio for renewal.
* Raid does less damage vs Boss monsters.
Thanks to @mrjnumber1 and @Lemongrass3110!
2018-11-16 09:51:47 -05:00
Aleos
24dca1117e
Corrected Reins of Mount interaction with hiding (#3621)
* Fixes #3614.
* Reins of Mount should not be applied to players who are in some sort of hidden state.
* Item delay is still applied.
Thanks to @admkakaroto and @cydh!
2018-11-16 09:17:42 -05:00
Aleos
0c6b772dd2
Updated Hammer of God behavior (#3595)
* Fixes #3559.
* Updated the cast range to 6 + skill_lv.
* Added Crimson Marker target checks to determine placement.
* No longer removes Crimson Marker on targets.
* Properly displays client effect.
Thanks to @Rytech2, @admkakaroto, @Tokeiburu and @exneval!
2018-11-16 08:47:37 -05:00
Aleos
404973f621
Corrected script command setunitdata HP/Max HP (#3669)
* Fixes #3668.
* Resolves an issue with adjusting HP/Max HP not properly applying it to the proper unit status.
Thanks to @Joao1905!
2018-11-13 09:33:58 -05:00
Aleos
78cda50e3b Corrected Ignition Break animation (#3670)
Corrected Ignition Break animation on newer clients (2018-02-07 and newer).

Fixes #3664.

Thanks to @Rytech2, @syracuase and @Lemongrass3110!
2018-11-11 23:03:59 +01:00
Lemongrass3110
91c87969c4 Revert "SQL synchronization"
This reverts commit d0be16f6285231e59b8bb1589765722cd50a9df1.
2018-11-11 22:57:49 +01:00
rAthenaAPI
d0be16f628 SQL synchronization 2018-11-11 22:08:01 +01:00
Lemongrass3110
a4c8039c17
Added some additional guild loading checks (#3680)
Fixes #3591

Thanks to @Badarosk0, @laziem and @aleos89
2018-11-11 22:06:10 +01:00
Aleos
e8c116246e
Implemented official buy/sell amount restrictions (#3673)
* Fixes #3666.
* When purchasing items from a NPC shop, the minimum purchase price is always 1 Zeny.
* When selling items to a NPC shop, the minimum sell price is always 0 Zeny.
Thanks to @Balferian and @dastgirp!
2018-11-08 16:44:46 -05:00
Aleos
7045d585e4
Added constants for Castle Data manipulation (#3531)
* Fixes #3530.
* Added constants for script commands getcastledata and setcastledata.
* Adjusted the guardian constants to adjust based on MAX_GUARDIANS define value.
* Updated scripts to reflect changes.
Thanks to @keitenai, @Atemo, and @Lemongrass3110!
2018-11-08 16:27:03 -05:00
Atemo
78edf851a0
Suggestion of implementation of is_party_leader and is_guild_leader script commands. (#3617)
* Implemented is_party_leader and is_guild_leader script commands.

Thanks to @cydh !
2018-11-06 16:28:09 +01:00
rAthenaAPI
0bcd299311 Effect State Update 2018-11-06 04:06:04 +01:00
Aleos
13006e19a6 Corrected Concentration's status icon (#3647)
Corrected Lord Knight's Concentration status icon displaying the wrong one.

Thanks to @mrjnumber1!
2018-11-02 16:00:12 +01:00
Aleos
fc07588d60
Corrected Instance timers when entering a map (#3594)
* Fixes #3585.
* Resolves an issue when players change maps to instances (aside from script command instance_enter) and the active/idle timers are not adjusted.
* Cleaned up the entering and leaving checks for instances.
Thanks to @Atemo and @Lemongrass3110!
2018-11-01 20:10:29 -04:00
Aleos
ca1bd50465
Corrected renewal Steal formula (#3523)
* Fixes #3473.
* The steal bonus no longer modifies the item's drop rate but has it's own success chance into stealing an item.
Thanks to @mrjnumber1!
2018-11-01 19:40:24 -04:00
Aleos
f4acbd14de
Corrected warping and OnTouch events (#3638)
* Fixes #1658, fixes #3620.
* Fixed script command warp2 or OnTouch NPC attempting to trigger OnTouch events a second time for players in a hidden state while warping to the destination map resulting in them being sent to an invalid location.
Thanks to @exneval, @mgksrt8, @admkakaroto, and @Zeloss!
2018-11-01 19:36:17 -04:00
Lemongrass3110
88d83a3030
Fixed instance id being lost for guilds (#3592)
This happens on each change that causes the guild to be reloaded from the character server.

Fixes #3571

Thanks to @cydh
2018-11-02 00:28:40 +01:00
Lemongrass3110
a47e6cb427
Added multi level up level caps (#3646) 2018-11-01 23:47:45 +01:00
Aleos
a7d8fbae14
Corrected atcommand reloadscript and NPC dialogs (#3643)
* Corrected atcommand reloadscript and NPC dialogs
* Fixes #3637.
* Force atcommand reloadscript to send a close button if a NPC dialog is active to any attached players.
* Fixed cutin removal as well.
Thanks to @kukuasir1 and @Lemongrass3110!
2018-11-01 16:08:53 -04:00