115 Commits

Author SHA1 Message Date
Lemongrass3110
016d15b79a
Unified infinite tick usage (#3755)
Introducing a new constant INFINITE_TICK
Changed current usages in items, npcs and source to use the new and correct constant.
Replaced some invalid usages of INVALID_TIMER and replaced them with the new constant.
2018-12-18 17:46:56 +01:00
Lemongrass3110
742232d575
Fixed zero termination for bg messages (#3759)
Fixes #3104

Thanks to @Rolfxx and @vstumpf
2018-12-18 02:32:37 +01:00
Lemongrass3110
7fa903ce22
Fixed SU_GROOMING while being frozen (#3756)
Fixes #3728

Thanks to @Everade
2018-12-17 14:14:58 +01:00
Lemongrass3110
bde580fdbd
Add drop highlighting effect feature (#3710)
Fixes #3610

Thanks to @Balferian, @admkakaroto and credits to @Asheraf
2018-11-29 22:34:57 +01:00
Lemongrass3110
91c87969c4 Revert "SQL synchronization"
This reverts commit d0be16f6285231e59b8bb1589765722cd50a9df1.
2018-11-11 22:57:49 +01:00
rAthenaAPI
d0be16f628 SQL synchronization 2018-11-11 22:08:01 +01:00
Lemongrass3110
a4c8039c17
Added some additional guild loading checks (#3680)
Fixes #3591

Thanks to @Badarosk0, @laziem and @aleos89
2018-11-11 22:06:10 +01:00
Aleos
a7d8fbae14
Corrected atcommand reloadscript and NPC dialogs (#3643)
* Corrected atcommand reloadscript and NPC dialogs
* Fixes #3637.
* Force atcommand reloadscript to send a close button if a NPC dialog is active to any attached players.
* Fixed cutin removal as well.
Thanks to @kukuasir1 and @Lemongrass3110!
2018-11-01 16:08:53 -04:00
Lemongrass3110
c0793a8072
Adding LGTM to CI tools (#3636)
Thanks to @aleos89 for his help.
2018-10-29 21:25:36 +01:00
Jittapan Pluemsumran
2140722743
Fixed potential map server crash in clif_parse_Mail_setattach (#3609) 2018-10-26 13:51:50 +07:00
Cydh Ramdh
fe197bfa12
Renewal Monster Updates (#3541)
* Renewal Monster's ATK & MATK Calculation Updates
* Renewal Monster database updates
  * ATK1 is *base* ATK, the range 80%~120% is calculated in src
  * ATK2 is *base* MATK, the range 70%~130% is calculated in src
* Adjusted ATK range min~max in mobinfo atcommand
* Nothing was changed in pre-renewal system!
* Thanks to @aleos89, @slyx88 and Divine-Pride.net
2018-10-13 19:00:14 +07:00
Lemongrass3110
55acdb9863
Initial release of the guild storage log (#3365)
Thanks to @aleos89 and @Everade
2018-10-10 17:51:49 +02:00
Cydh Ramdh
3e1105b0cf
Updates Item Sell checks (#3491)
* Added config values for `allow_bound_sell`
  * 0x4 allows bound item to be sold at NPC Shops
  * 0x8 restrict only guild leader who can sell guild bound item at NPC Shops or Itemshops
* Added config to allow rental items can be sold at NPC `rental_transaction` (planned for more config values based on #3490). Default to `yes` allowed to be sold, still can be restricted by item_trade, item id based.
* Fixed itemshop which ignores another item stack in inventory even for same item currency
* Fixed exploit potential by using Itemshop & Pointshop
* Now equipped item cannot be sold at NPC
* Typo and grammar fixes. Thanks to @aleos89 and @secretdataz
2018-09-27 13:54:28 +07:00
Aleos
e6e0511cf7
Corrected a check for skill usage restrictions (#3472)
* Resolves an issue where the usage of self skills while a storage is open was causing the entire check to fail.
Thanks to @Tokeiburu!
2018-09-12 11:03:14 -04:00
Aleos
3569789ab0
Corrected server info display (#3434)
* Fixes #3431.
* Corrected the VIP EXP bonus amount being displayed incorrectly for the personal information packet.
Thanks to @hendra814!
2018-08-29 09:29:21 -04:00
Aleos
48ae1a1e05
Cleaned up map storage type (#3384)
* Fixes #3369, fixes #3370, and fixes #3382.
* Converted maps storage container back to static array.
* Converted mapflag storage containers to unordered_map.
* Removed a lot of redundancy and recursive lookups.
* Fixed a couple short-circuit checks to help with performance.
* Fixed multiple instance creation/destruction issues.
* Fixed PK Mode attempting to set PvP on flags that are already active.
* Getting MF_RESTRICTED will return the map's zone value instead of the state.
* Converted mapflag macros to inline functions.
Thanks to @teededung, @lelouch22, @mazvi, @Lemongrass3110, and @cydh!
2018-08-10 13:52:07 -04:00
Cydh Ramdh
83c8183a2e
Added IG_PRIVATE_AIRSHIP (#3378)
* Item group for Private Airship tickets
2018-08-06 08:06:30 +07:00
Lemongrass3110
8dea04a8b3
Initial release of private airship system (#3354)
Fixes #3314 

Thanks to @aleos89 for his help.
2018-07-29 20:11:15 +02:00
Aleos
584fcac43a Cleaned up map data storage (#3347)
Follow up to a942853.
Fixes #3336.
Moved map_data storage to std::map container.
Created map_getmapdata to obtain pointer to map_data.
Got rid of MAX_MAP_PER_SERVER define.
Resolved deletion of instances causing other instances to lose their intended map ID.
Refactored warp suggestions

Thanks to @teededung, @anacondaqq, @cydh and @Lemongrass3110!
2018-07-26 01:06:59 +02:00
Lemongrass3110
6b3f0717c7
Hotfix for issue 3277 (#3279)
Fixes #3277 

Thanks to @cydh and @aleos89
2018-07-24 22:55:17 +02:00
Lemongrass3110
95c3aed810 Fixing party death icon in newer clients
Fixes #2356

Thanks to @admkakaroto and @4144
2018-07-23 23:05:18 +02:00
Aleos
a942853d55
Cleaned up the mapflag system (#2943)
* Created setter and getter functions.
* Adjusted all calls to use these functions.
* Converted mapflags to C++ map container.
* Converted drop_list to vector.
* Converted skill_damage ERS into vector and increased limit from UINT8 to UINT16.
* Cleaned up several functions to be more dynamic to reduce redundancy that was all over the place.
* Renamed nosumstarmiracle to nosunmoonstarmiracle.
* Adjusted skill_damage mapflag to use proper defined constants.
* Refactored map index into a vector.
Thanks to @Lemongrass3110 for a lot of help and @secretdataz!
2018-07-18 20:00:33 -04:00
Aleos
b409936f8d
Updated max recovery weight to 70% for renewal (#3309)
* Fixes #2622.
* Added a new battle config for renewal.
* Adjusted the battle config to support dropping the recovery weight to 0.
* Added the new weight limit packet.
Thanks to @functor-x and @Lemongrass3110!
2018-07-17 16:18:39 -04:00
Lemongrass3110
a5588dd9ab
Initial Release of Attendance Feature (#3297)
Thanks to @secretdataz and @aleos89 for their help.
Thanks to @Haikenz and @admkakaroto for testing.
Thanks to @Daegaladh for his ideas.
2018-07-16 21:39:42 +02:00
Lemongrass3110
c4d7dc76d3
Hid timer function parameters in a macro (#3311) 2018-07-15 23:17:15 +02:00
Lemongrass3110
b2c026d4b0
Cleaned up Summer 2 code (#3294)
Fixes #3293

Thanks to @Everade for reporting.
2018-07-08 11:58:50 +02:00
Lemongrass3110
fe7c0a78ec
Refactored roulette system (#3271)
Fixes #2887 - thanks to @Everade
Fixes #3292 - thanks to @admkakaroto

Added a script command to open the roulette window from server side.
Added support for clients >= 2018-05-16
Fixed losing behavior for roulette
Enabled roulette system by default
Added a server side delay
Added missing sql log enum value 'Y'

Thanks to @Everade, @admkakaroto, @V0rr, @ecdarreola, @Haikenz and everyone else who contributed to this.
2018-07-06 22:39:58 +02:00
Lemongrass3110
cea5ad7199
Fixed a bug with warlock's spheres (#3288)
Fixes #3264

Thanks to @nornane for reporting this and coming up with a solution.
2018-07-06 07:52:04 +02:00
Lemongrass3110
91169d7ebc
Fixed a few compiler warnings on clang (#3263)
Mostly pointer-bool-conversion and autological-pointer-compare
2018-07-05 22:53:20 +02:00
Lemongrass3110
b3a51eaa35
Fixed broken guild notices (#3262)
Fixes #641

Thanks to @tmav94, @RadianFord, @Akkarinage and @vykimo
2018-07-01 23:22:22 +02:00
Lemongrass3110
9a7e27b690 Added clan name display
Clients that do not support this ignore this anyway.
Party name is not displayed when you are in a clan unlike with a guild.
You can use display_party_name if you want to show it.
2018-06-27 00:29:35 +02:00
Aleos
11b42569fc
Synchronized source file headers (#3212)
* Alphabetically sorted includes.
* Updated copyright and license text to match across all files.
* Removed pragma once define in header files in lieu of ifdef guards.
2018-06-20 18:08:30 -04:00
Lemongrass3110
801d3ed942
Moved common, config and mapcache to C++ (#3200)
Dropped BETA_THREAD_TEST and everything around it
Dropped mt19937
Replaced msinttypes with cinttypes
Removed IRC link and updated README name
2018-06-14 21:51:58 +02:00
Lemongrass3110
8202555514 Fixed client blocking mail deletion
Fixes #3144

Thanks to @kraaijmakers
2018-05-23 10:06:04 +02:00
Lemongrass3110
d16e7e6160
Added support for changedress command (#3109)
This adds support for /changedress and /nocosplay by adding an atcommand for it and redirecting the client command to it.

Thanks to @Everade for finding this.
2018-05-19 00:37:41 +02:00
Maytichai Saowa
a8fd92c6da Update/doc packet (#3111) 2018-05-18 20:12:37 +02:00
Lemongrass3110
3e269ace66
Added an option to disable homun autofeed notify (#3119)
Thanks to @haikenz for the suggestion.
2018-05-18 11:17:34 +02:00
Aleos
12c01b0b40
Cleaned up item broadcast code (#3117)
* Fixes #2847.
* Removed some unused variables.
Thanks to @anacondaqq!
2018-05-17 18:55:41 -04:00
Lemongrass3110
ce324ad13d
Added atcommand for limited sale (#3103)
Removed permission
Added state tracking instead to make sure player can use the atcommand

Thanks to @secretdataz for his idea.
2018-05-08 21:32:52 +02:00
Lemongrass3110
953f7cf47e Follow up to 5b13dc7
Added missing flag for npc sent mails.
This will prevent showing the reply button on supported clients.
2018-05-06 17:21:41 +02:00
Lemongrass3110
55bf142ab8 Follow up to d13d6a6
Thanks to @RadianFord
2018-04-20 22:53:09 +02:00
Lemongrass3110
aaffbaaa14 Added ZC_NPCACK_SERVERMOVE2
Thanks to @mrdiablo
2018-04-20 22:44:35 +02:00
Lemongrass3110
2c68db9faa
Fixed a few problems with homunculus autofeed (#3062) 2018-04-20 19:22:13 +02:00
Lemongrass3110
d13d6a6e19
Changed SI_ enum to the official EFST_ enum (#2995) 2018-04-20 18:24:20 +02:00
Vincent Stumpf
f948b9a665 No matter what MAX_ITEM_RDM_OPT is, send 5 random options (#3040)
Thanks to @syracuase for the hint with RODEX
2018-04-08 23:33:15 +02:00
Lemongrass3110
aff70f6482 Added support for homunculus autofeeding (#3007)
* Added support for homunculus autofeeding
This feature is available in 2017-09-20bRagexeRE or later

Credits to @Asheraf in HerculesWS/Hercules#1898
2018-04-04 13:55:51 +07:00
Lemongrass3110
f338d53c2c
Added support for clients up to 2018-03-07bRagexeRE (#2975)
Thanks to @4144 as always
Credits to @dastgir and the leaked 2015 dump for the quest packets
Thanks to @idamonli for testing and feedback
2018-03-14 23:05:01 +01:00
Jittapan Pluemsumran
1e766a7b4a
Converted pet_data::petDB into a getter function (#2901)
* Converted pet_data::petDB into a getter function
Fixed #2900
Thanks to @Lemongrass3110
2018-02-23 17:14:46 +07:00
Lemongrass3110
c16b7b1795
Fixed display of newly added pet eggs in storage (#2911)
Fixes #2864

Thanks to @talesofragnarok for reporting and @aleos89 for confirmation.
2018-02-23 01:46:27 +01:00
Aleos
4171cd1801
Updates Rolling Cutter counter behavior (#2837)
* Fixes #2835.
* Rolling Cutter counter should only be reset on physical click-walks, not by any other movement.
Thanks to @ecdarreola and @secretdataz!
2018-01-30 14:15:42 -05:00