8516 Commits

Author SHA1 Message Date
aleos89
9959c919dc VIP Drop calculation correction
* Fixes #2247.
* Adjusted the drop rate to properly float the value before converting to integer.
Thanks to @talesvalente!
2017-07-10 10:29:28 -04:00
aleos
0739275508 Cleaned up Hells Plant damage formula
* Fixes #2230.
Thanks to @RagnarokValor!
2017-07-08 13:18:04 -04:00
aleos
4dfeeade06 Resolve some compile warnings
* Fixes #2245.
Thanks to @lelouch22!
2017-07-08 11:42:53 -04:00
Lemongrass3110
b2aa7e698d Fixed thief's back sliding animation
Fixed #1914

Thanks to @zackdreaver for reporting and @aleos89 for his help!
2017-07-07 23:52:00 +02:00
aleos89
27a30ffa51 Removed an unused variable
* Follow up to bae5c31.
* Fixes #2241.
Thanks to @hazimjauhari90!
2017-07-07 08:36:30 -04:00
Aleos
bae5c31201 Miscellaneous atcommand parsing cleanups (#2238)
* Removed several typecasts.
* Adjusted atcommands that interpret character names to make use of atcmd_player_name.
* Added some missing comments.
* Adjusted a few return messages to match the appropriate scenario.
* Assume atcommand changeleader is successful after initial checks.
Thanks to @Lemongrass3110!
2017-07-06 17:15:45 -04:00
aleos
5462b08d28 Follow up to dc2c51c
* Added a missing break.
2017-07-06 16:43:21 -04:00
aleos
dc2c51cd83 Corrected Hell Inferno behavior
* Fixes #2236.
* Hell Inferno's shadow attack will now properly do elemental damage.
* Burning should only start when the fire attack successfully lands.
* Gave a slight delay to the shadow attack to mimic officials.
Thanks to @hartonox!
2017-07-06 16:38:45 -04:00
Aleos
5f7a143d3e Updated Summoner class (#1965)
* Fixes #1865.
* Updated and added new Summoner class skills.
* Information based on kRO patch notes.
- http://ro.gnjoy.com/news/devnote/View.asp?category=1&seq=1987966&curpage=1
* Updated previously implemented skills to better mimic official behavior.
Thanks to @RagnarokNova, Fyrus, and Jet for their hard work on gathering the information!
Thanks to @Grimfiend, @Atemo, @feltenc, @Lemongrass3110, @Felleonel, and @sanny1128 for the rapid test and reports!
2017-07-05 19:40:35 -04:00
Lemongrass3110
689a3ff9b3 Added a few missing cashpoint message comments 2017-07-03 22:25:14 +02:00
Lemongrass3110
f86ba2b6b8 Added a state check for the cash shop
If the cash shop is open you can not use the atcommands cash and points.
This is because no update packet exists and the cash shop only gets the current amount when you open the cash shop.
The second way to update the cash shop values is on a successful purchase.
2017-07-03 22:14:34 +02:00
Lemongrass3110
a3c0590508 Added some checks to guild leader change
Introduces two new configurations:
1) Allow guild leader changes in WoE (yes/no)
	Default: no
2) Delay between the changes (in minutes)
	Default: 1440 minutes = 1 day

Follow up to b51617c
2017-07-02 23:40:30 +02:00
Lemongrass3110
2072fe3643 Fixed unitwalk and unitwalkto label reset
Fixed #2222

Thanks to @zellkennedy
2017-07-02 18:21:33 +02:00
Lemongrass3110
045f4be573 Fixed getequipid returning 0 instead of -1
Fixed #2228 and updated the documentation a little

Thanks to @talesvalente
2017-07-02 15:39:35 +02:00
Lemongrass3110
2aefe6c188 Fixed 2 compilation warnings 2017-07-02 15:06:27 +02:00
hazimjauhari90
ad80914981 Follow up to 7351b88 (#2200)
Merged HerculesWS/Hercules@73db1e2

The exact client date for the implementation of new party ui window is actually 2017-05-02dRagexeRE

Thanks to @4144, @Asheraf and @dastgir
2017-07-02 14:18:08 +02:00
Jittapan Pluemsumran
fa24b2134d Expanded bg_get_data script command (#2179)
* Expanded bg_get_data script command.
* Now able accept type parameter of 1 to list account IDs of battleground members.
* Originally implemented by @AnnieRuru at https://rathena.org/board/topic/72571-b/
2017-06-30 14:06:04 -04:00
Aleos
ba242eb9ed Resolved function timers not being freed properly (#2223)
* Fixes #2216.
* Properly free a function's timer when reloading scripts.
* Renamed script_stop_instances to not confuse it with the Instance System.
Thanks to @Tokeiburu!
2017-06-30 12:43:20 -04:00
Lemongrass3110
45e91e2a3a Added clan emblems to the NPCs (#2221)
* Added clan emblems to the NPCs
* Partial merge of/based on idathena/trunk@1f84c5d
Thanks to @exneval
2017-06-30 12:31:06 -04:00
Atemo
a8e4c83ef1 Updated sleep2: (#2208)
* Updated sleep2:
Currently sleep2 is supposed to return 0 or 1 if the unit is still attached. Actually mapserv throws a warning and the script end if the timer is still running and unit offline. With this update the script ends if there is no unit attached for sleep2.
* Corrected comments / docs
Thanks @secretdataz, @Lemongrass3110
2017-06-30 10:25:14 -04:00
Lemongrass3110
9827bf6153 Fixed motd parsing
Fixed #2220

Thanks to @anacondaqq
2017-06-27 19:00:59 +02:00
Lemongrass3110
da036de523 Follow up to 4a2574c and 76786e2 2017-06-27 18:44:23 +02:00
Jittapan Pluemsumran
e87626cc76
Fixed compile error when ADJUST_SKILL_DAMAGE macro is defined 2017-06-27 16:45:19 +07:00
aleos89
20908ee9c0 Replaced some final uses of rand()
* Replaced some final left overs of rand() with rnd() from MT19937AR.
2017-06-26 14:36:31 -04:00
aleos89
a7c8751a10 Resolve an issue with script command strnpcinfo
* Resolved the NPC map name lookup for floating NPC returning arbitrary values.
2017-06-26 14:12:24 -04:00
Atemo
a5afb06979 Initial release of lasagna npcs (#2105)
* First release of lasagna npcs (playing conversion).

* Added a new parameter for npctalk script command
Target for <flag>:
- bc_all  : Broadcast message is sent server-wide (only in the chat window).
- bc_map  : Message is sent to everyone in the same map as the source of the npc.
- bc_area : Message is sent to players in the vicinity of the source (default value).
- bc_self : Message is sent only to player attached.

* Implemented doram food buffs

* Updated npctalk:
*npctalk "<message>"{,"<NPC name>",<flag>};
- Empty string for "<NPC name>" now means attached NPC

* Added flag parameter for unittalk script command
*unittalk <GID>,"<text>"{,<flag>};
flag: Specify target
   bc_area - Message is sent to players in the vicinity of the source (default).
   bc_self - Message is sent only to player attached.
 
* Updated classchange script command:
classchange(<view id>{,"<NPC name>",<flag>});
flag: Specify target
   bc_area - Data is sent to players in the vicinity of the source (default).
   bc_self - Data is sent only to player attached.

* Updated Time Limit for quests to allow HH:MM format

Thanks @secretdataz, @Lemongrass3110, @aleos89, @Jeybla, @anacondaqq, @jenkijo, @sikiro, @admkakaroto for contributing !
2017-06-26 00:54:25 +02:00
Jey
809fc35b0e
Follow up to 4a2574c.\r\nThanks to @Jeybla! 2017-06-26 01:24:54 +07:00
Jittapan Pluemsumran
4a2574c599 Migrate core source files to C++. Add yaml-cpp project as dependency (#2207)
By updating to this commit, Linux users have to regenerate Makefiles by re-running the configure script.

* Added yaml-cpp project as a 3rdparty library
* Migrated source files core to C++
* Updated configure scripts
* Make Linux installations compile *.cpp files
* Made server components' main source file C++
* Also made headers CPP-aware.

* Added basic C wrapper for yaml-cpp library
* YAML-node path is delimited by periods.
* Basic integer types and string are supported.
* Strings returned from this wrapper have to be freed with malloc.h::aFree
* Arrays (sequence) is supported with iterator wrapper.
* Remember to free every wrapper you create!

* Add yaml-cpp as dependency of common project
* Made the repo not ignore *.yml files

Thanks to @aleos89 and @Lemongrass3110.
2017-06-25 23:33:24 +07:00
Aleos
e804970c49 Added a config for Banana Bombs (#2211)
* Fixes #2095.
* Added a battle config banana_bomb_duration to allow people to adjust the default duration of Make Bomb - Banana Bomb.
2017-06-23 09:39:27 -04:00
aleos89
2a6277a3dc Adjusted NPC casted skill cast times
* Fixes #2045.
* NPC's that cast skills through script commands unitskilluseid or unitskillusepos with a given cast time will no longer be instant cast.
2017-06-22 14:39:05 -04:00
Jittapan Pluemsumran
6fc2399df1
Fixed compiler warnings
Thanks to @RadianFord
2017-06-21 22:31:01 +07:00
Lemongrass3110
3acf1aada3 Follow up to 58776da
Fixed a few compiler warnings.
Thanks to @RadianFord
2017-06-21 15:07:37 +02:00
Lemongrass3110
58776da1ac Basic RODEX support (#2186)
Adds basic support for the new mail UI RODEX.

Fixes #1567

Thanks to @RagnarokNova, @Atemo, @aleos89 and everyone else that helped me with this.
Additionally I would like to thank @jezznar and @hazimjauhari90 for their good testing in the pull request.
2017-06-21 00:00:29 +02:00
Lemongrass3110
76786e2977 Cleaned up visual studio project minicore (#2166)
Cleaned up leftover defines(PCRE_SUPPORT and FD_SETSIZE) in the projects
2017-06-20 22:25:24 +02:00
Lemongrass3110
d0ca637ddd Fixed vip_status command (#2184)
Fixed different return types for the same function call
Also introduced constants for better function usage.

Fixes #2183
Thanks to @anacondaqq
2017-06-20 19:22:46 +02:00
Ninja
6b8dbf9a82 Fix for Issue #2143 False Duplication of Items (#2157)
* Fixes #2143.
* Resolves the inventory looking like there are duplicate items when players use atcommand refresh during trades.
2017-06-16 10:17:02 -04:00
Atemo
6ce846883e Updated produce_db.txt to include Combination Kit
Thanks @anacondaqq
2017-06-15 21:14:56 +02:00
aleos
3093824bbe Updated atcommand changegm area name update
* Changing a guild's leader will now properly update the respective player names to the area.
Thanks to @anacondaqq!
2017-06-14 20:11:46 -04:00
Jeybla
05a778d6a3 Fixes damage skills which ignored walls. (#1453)
* Fixes damage skills which ignored walls.
* The following functions were adjusted for the battle config skill_wall_check.
* Changed map_foreachinrange behavior:
- map_foreachinallrange is now the old map_foreachinrange
- map_foreachinrange does not check for a wall
- map_foreachinshootrange always checks for a wall
* Changed map_foreachinarea behavior:
- map_foreachinallarea is now the old map_foreachinarea
- map_foreachinarea does not check for a wall
- map_foreachinshootarea always checks for a wall
2017-06-14 19:28:59 -04:00
Jittapan Pluemsumran
887efa4ea4 Item DB update and script command adjustment (#1739)
* Made getequipid script command accept EQI_COMPOUND_ON (-1) for current equipment slot when running in item script.
* Added new equipment index for current item in item script context.
* Fixed typo in Fulbuk_Card item script.
* Fixed typo in Lich_Lord_Card effect.
2017-06-14 13:35:32 -04:00
Jittapan Pluemsumran
264af55b42 Change some GvG checks (#2172)
* Fixes #1600.
* Adjusted various GvG checks to ignore the Agit mode check.
* Blocked Anodyne on GvG zones.
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2017-06-12 17:59:44 -04:00
aleos89
399d11cd78 Follow up to 6d962d7
* Corrected a missed constant rename which caused a compile error.
2017-06-12 13:18:41 -04:00
Atemo
ad82c6b790 Fixed color by default in questinfo script command
Thanks @anacondaqq
2017-06-12 18:59:37 +02:00
aleos89
6d962d73d1 Corrected enum constant naming convention.
Follow up to 6c266ae.
2017-06-12 12:13:02 -04:00
Jittapan Pluemsumran
6c266ae1f5 Item package and Aegis names updates (#2170)
* Item DB Updates
* Updated Item Packages that were added based on idRO's updates
* Added some Item Packages
* Corrected some Aegis item names
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2017-06-12 10:57:46 -04:00
aleos89
128259407c Corrected a SQL buffer type for bound items
* Resolves the equip value of bound items being truncated.
Thanks to @Tokeiburu!
2017-06-08 09:42:54 -04:00
Lemongrass3110
7351b88c14 Follow up to 816d8ab
Thanks to @admkakaroto

Source: http://ro.gnjoy.com/news/update/View.asp?seq=208
2017-06-06 21:26:28 +02:00
aleos89
b2d72ca625 Fixed Status Recovery's interaction with skills
* Fixes #2188.
* Poem of the Netherworld will now properly be removed with Status Recovery.
Thanks to @awayne910!
2017-06-06 08:45:49 -04:00
Lemongrass3110
816d8ab2d0 Fixed party window for 2017 clients
Thanks to @mrdiablo for his help again!
2017-06-05 23:07:09 +02:00
Lemongrass3110
b51617cb73 Added support for 2017's guild leader change 2017-06-03 17:03:56 +02:00