16 Commits

Author SHA1 Message Date
Jittapan Pluemsumran
9d730f3ba9
Item database update
Fixed #1433. Fixed #1434.
2016-07-18 23:27:53 +07:00
Cydh Ramdh
25dbd6eba4 Bug Fixes:
* Fixed #439, Sightrasher doesn't check target's status. Thank @reigneil.
* Fixed #476, Genetic Change Material ignored the created item if stackable or not. Thank @juanfus.
* Fixed compile warnings, unused `num` in getunitdata().
* Fixed wrong return value in BUILDIN_FUNC(questinfo).

Item Updates:
* Added items: C_Flying_Ljosalfar (20099), Protect_Feathers (19024), Sograt_Lucky_Scroll (17598).
* Corrected view_id for C_Coiledup_Snake (20110).
* Follow up 3f549cafb5570a67c046c5078cddbe3a95b772dc, wrong bonuses and revert 18575. Thank @zackdreaver.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-24 22:12:45 +07:00
Cydh Ramdh
3f549cafb5 * Revert some changes on 549f491fe6a0f879b5d4b647cac8307b8123e181
* Item bonus correction, ambiguous of 'HP/SP Gain' implementation.
  * Since no implementation for 'drain HP/SP from target', the bonus was removed but makes 'HP/SP Drain' bonuses act like 'drain HP/SP from target' that was totally wrong.
  * This also fixed #471, @AbuGosok
  * Removed HP/SP Gain bonuses that should be use HP/SP Drain:
    * `bonus bHPGainAttack,n;` is same as `bonus bHPDrainValue,n;`.
    * `bonus bSPGainAttack,n;` is same as `bonus bSPDrainValue,n;`.
    * `bonus2 bHPGainAttackRate,x,n;` is same as `bonus2 bHPDrainRate,x,n;`.
    * `bonus2 bSPGainAttackRate,x,n;` is same as `bonus2 bSPDrainRate,x,n;`.
    * `bonus2 bHPGainRaceAttack,r,n;` is same as `bonus2 bHPDrainValueRace,r,n;`.
    * `bonus2 bSPGainRaceAttack,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
    * `bonus2 bHPGainRaceAttackRate,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
    * `bonus2 bSPGainRaceAttackRate,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
    * `bonus bHPGainAttackRate,n;` none.
    * `bonus bSPGainAttackRate,n;` none.
* Fixed #454, thank @jeanroyce
* Item update & correction script from Aegis
  * Wunderkammer renamed to YinYang_Earring (18575).
  * Updated scripts for 7676, 18593, 18595, 18597, 18600, 18601, 18630, 18631, 18636, 18637, 18650, 18650, 18652, 18656, 18659, 18671, 20700, 20724, 28315, 28316, 28317, 28318.
  * Updated script for RCC2013 Combos 28315:28317 and 28316:28318.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-18 19:26:05 +07:00
Cydh Ramdh
b71ed05857 Bug Fixes
* Now coma triggered on every attack types (bugreport:3100)
  * Added bonuses `bonus2 bComaRace,r,n;` and `bonus2 bComaClass,c,n;`, replacing the current usages of `bWeaponComaRace` and `bWeaponComaClass`.
  * This bonus has no effect for GVG and BG monsters.
* Fixed Shockwave Trap (HT_SHOCKWAVE) SP reduction, should be % of MaxSP not % of 'current' SP.
* Fixed #462, failure in `setunitdata` for NPC. Thank a91323, @julia40124009
* Fixed #470, changed SO_ARRULLO target to BL_CHAR.
* Added skill flag INF2_HIT_TRAP (0x40000) to removed hardcoded 'skill that can hit traps'.
  * NOTE: Client-side's factor also determines that skill can be targeted to trap-type skill or not.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-17 00:33:08 +07:00
Cydh Ramdh
549f491fe6 Item Bonus Updates
* Added `bonus2 bSubSkill,sk,n;` -> Reduces n% damage received from skill sk.
* Added `bonus bHPGainAttack,n;` -> Heals +n HP with a normal attack.
* Added `bonus bSPGainAttack,n;` -> Heals +n SP with a normal attack.
* Added `bonus bHPGainAttackRate,n;` -> Heals +n% HP of inflicted damage on every hit when attacking an enemy.
* Added `bonus bSPGainAttackRate,n;` -> Heals +n% SP of inflicted damage on every hit when attacking an enemy.
* Added `bonus2 bHPGainAttackRate,n,x;` -> Has chance x/10% to heals +n% HP of inflicted damage on every hit when attacking an enemy.
* Added `bonus2 bSPGainAttackRate,n,x;` -> Has chance x/10% to heals +n% SP of inflicted damage on every hit when attacking an enemy.
* Replaced `bonus2 bHPDrainValue,n,x;` for x = 0 to `bonus bHPGainAttack,n;`. Since x = 1 is same as `bonus bHPDrainValue,n;` and if there are items with bonus with 'x' is different, the value will be sum'd but the type switched.
* Replaced `bonus2 bSPDrainValue,n,x;` for x = 0 to `bonus bSPGainAttack,n;`. Since x = 1 is same as `bonus bSPDrainValue,n;` and if there are items with bonus with 'x' is different, the value will be sum'd but the type switched.
* Replaced `bonus3 bSPDrainRate,n,x,y;` for y = 0 to `bonus2 bSPGainAttackRate,n,x;`. Since y = 1 is same as `bonus2 bSPDrainRate,x,n;` and if there are items with bonus with 'x' is different, the value will be sum'd but the type switched.
* Updated the documentations.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-07 19:00:24 +07:00
Cydh Ramdh
e83d69be57 Follow up 2d53a78:
* Added 'bonus2 bAddItemGroupHealRate' to replace 'bonus2 bAddItemHealRate' for Item Group ID usage. Since MAX_ITEMGROUP is removed, there is no identifier which entry that Item ID or Item Group. Previous check using 'if (type2 < MAX_ITEMGROUP)' (2d53a782fa (diff-08420bab8271f3965304fee42cf4b865L3220))
* bonus2 bAddItemHealRate,iid,n;
* bonus2 bAddItemGroupHealRate,ig,n;

Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
2014-05-23 21:17:01 +07:00
Lilith
40f70143d4 * Added RC_PLAYER race.
* Updated all item bonuses.
* Fixed Bug: http://rathena.org/board/tracker/issue-8420-pc-bonus2-unknow-type-0-3-1/
* Fixed Bug: http://rathena.org/board/tracker/issue-8451-whats-wrong-on-bonus-bdefratioatkclass/
* Fixed Visible part of Shadow Equipment when storage is open.
2014-01-09 08:19:18 -08:00
Lilith
dae81222a8 * Added AEGIS 'CLASS_' enum
- Removed RC_BOSS, RC_NONBOSS, RC_NONDEMIHUMAN.
 - Added CLASS_NORMAL, CLASS_BOSS, CLASS_GUARDIAN enum.
 - Added CLASS_ALL, RC_ALL, ELE_ALL, SZ_ALL.
 - Item bonuses 'bAddDefClass' and 'bAddMdefClass' replaced by 'bAddDefMonster' and 'bAddMdefMonster'.
 - Item bonuses 'bIgnoreMdefRate' and 'bIgnoreDefRate' replaced by 'bIgnoreMdefRaceRate' and 'bIgnoreDefRaceRate'.
 - Added new item bonuses: bIgnoreDefClass, bIgnoreMdefRaceRate, bDefRatioAtkClass, bAddClass, bSubClass, bMagicAddClass, bWeaponComaClass, bHpDrainValueClass, bSpDrainValueClass, bIgnoreMdefClassRate.
 - Updated doc/item_bonus.txt
 - Updated db/re/level_penalty.txt & 'pc_level_penalty_mod' function.
 - Updated 'battle_calc_cardfix' function.
 - 'md->class_' replaced by 'md->mob_id'
2013-12-30 08:46:24 -08:00
Euphy
20153af6e0 * Script updates:
- Added new Renewal warpers for Satan Morroc maps.
- Updated "Succession of the Prince" quest with some new cases, and fixed checkquests.
- Updated portions of Ecology quest in 13.1 quests with new checks and cases.
- Added some missing 'disable_items' commands to 2004 Headgear quests.

* Other changes:
- Changed some strnpcinfo(1) -> strnpcinfo(0) in 13.2 quests. (bugreport:7853)
- Moved Rune Knight Kafra into main Kafras file.
- Revised documentation for 'addrid'. (follow-up 6572a9f)
- 'instance_id()' no longer throws an error upon failure.
- Fixed Desert Twilight/Sandstorm combo. (bugreport:7897, credits: Playtester)

Signed-off-by: Euphy <euphy@rathena.org>
2013-07-27 16:36:00 -04:00
playtester
0b1a6970d6 - Fixed refine bonus on combo items, now we specify which position we take the refine bonus from just like Aegis
- Fixed Bloody Eater being equip-able by non-trans classes, it was an official bug, but it has been fixed even before renewal
- Fixed the bonus on a few headgears
- Fixed pre-renewal NPC_EMOTION monster skills, they had the wrong mode and were missing the detector bitsets, they are wrong in renewal too, however, I think renewal should be updated via converter

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17288 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-04-23 15:55:48 +00:00
euphyy
6aa1beed27 * Changed remaining bEquipmentMatk bonuses to bMatk in item_combo_db (follow-up r16981).
* Reverted r17116.
* Merged eAthena ea:15231, ea:15232 by ai4rei.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@17117 54d463be-8e91-2dee-dedb-b68131a5f0ec
2013-02-02 05:45:09 +00:00
euphyy
7fc959438d * Removed duplicate isequipped() entries from item_db already written in item_combo_db (bugreport:6924).
* Moved a few remaining isequipped() entries to item_combo_db.
* Follow-up r16940: applied change to SQL and pre-re files, and renamed Size constants to Size_ for consistency.
* Follow-up r16947: fixed mob modes.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16955 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-11-23 18:30:42 +00:00
kenpachi2k11
1b3cfdb4c2 Commented out combo 2369:2428:2533:5306 because item 2428 is commented out, too. And removed a spaced that should be the reason for a warning in sv_readdb(). (bugreport:6345)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16510 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-27 06:13:13 +00:00
kenpachi2k11
cea3d7e2be Added a missing curly bracket. (bugreport:6217)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16407 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-12 12:33:24 +00:00
kenpachi2k11
3fdc654e41 Commented out a combo that contained a commented out item (#5470). (bugreport:6213)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16406 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-12 07:26:36 +00:00
shennetsind
a7716f2267 Implementing Kenpachi's design of item_combo_db.txt
- Credits to Kenpachi and Masao for the db file edits.
- Credits to GreenBox for the parsing
- This commit might accidentally override a few item db entries, our db developers are expecting this and will work on the conflicting entries.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@16393 54d463be-8e91-2dee-dedb-b68131a5f0ec
2012-07-11 11:26:55 +00:00