Clean up something RENEWAL_CAST
* Moved additive bonuses (reducing/increasing) to first calculation before the rate adjustment
* Corrected `bonus(2) bFixedCastrate` shouldn't be stacked. Example between Puente_Robe (15012) is -3% and +10 Rafini_Staff (1649) is -10%, only -10% will be used not -13%.
* Reversed some value assignment, `-=` to `+=` and other part that affected by this change.
* Also as follow up c3e488e & 4f4d8fe, fixed `bonus2 bFixedCastrate,"sk",rate;` algorithm
* Corrected `bFixedCastrate` for Krieger_Knuckle2 (1827) only for skill `MO_EXTREMITYFIST`
* Moved default the 20% of fixed cast rate to conf/battle/skill.conf `default_fixed_castrate`
* 1 = 1%, 100 = 100%... previously 1 = 100%
* Increase calculation accuracy. Example for previous calculation of Concentrated_White_Potion_Z (12428) bonus to add 20% HP recovery rate always be fail, since "1*20/100" always be round down to 0, didn't add 20%!
* Vitata_500 (12436) has incomplete vals for SC
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
* Added newline at end of file
* Removed extra parenthesis. Thank @julia40124009
* Added constantan value, IT_SHADOWGEAR 12
* Corrected some item type, 11 -> 2
* Removed `set` from item_combo_db.txt to direct assignment
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
* Moved additive bonuses (reducing/increasing) to first calculation before the rate adjustment
* Corrected bFixedCastrate, shouldn't be stacked. Example between Puente_Robe (15012) is -3% and +10 Rafini_Staff (1649) is -10%, only -10% will be used not -13%.
* Reversed some value assignment, `-=` to `+=` and other part that affected by this changes.
* Also as follow up c3e488e & 4f4d8fe, fixed `bonus2 bFixedCastrate,"sk",rate;`
* Corrected `bFixedCastrate` for Krieger_Knuckle2 (1827) only for skill MO_EXTREMITYFIST
* Moved default the 20% of fixed cast rate to conf/battle/skill.conf `default_fixed_castrate`
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
(Seems something changed with the file attribute or what is it, changed a whole file lines and always be assumed unstaged files/uncommited changes)
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
- Autobonus3 will now also trigger when using ground skills (bugreport:6434)
- Fixed trigger chance of the Angelic Ring auto-bonuses (5% -> 10%) and that they didn't display any effect
* Changed `mr` values to use constantan value
* Added check for IT_SHADOWGEAR's script restriction before executing it
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
* Fixed Decoration of Music status when equipping the headgear. (bugreport:9342)
* Fixed Warg Dash giving Endure when it shouldn't. (bugreport:9337)
* Fixed Mado Gear skill item requirements. (bugreport:9335)
* Fixed Super Novice Spirit being able to be casted by all classes. (bugreport:9344)
* Fixed Masquerade - Ignorance to work on monsters. (bugreport:8099)
* Fixed Voice of Siren duration depending on level of character. (bugreport:9289)
* Fixed Spirit Sympathy SP requirement reduction when summoning an Element. (bugreport:9329)
* Changed type of some box-type items, from '11' to '18'
* Corrected some Aegis names
* Uncommented some item packages
* Updated item_db_re.sql file
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
- Some name changes.
- Enabled some previously disabled mobs (unused).
- Added mob IDs 2402~2403, 2924~2936.
Other changes:
- Changed 120 stat equality check to inequality for two items. (bugreport:9261)
http://rathena.org/board/tracker/issue-9261-bradium-brooch-bonus-if-agi-120/
- Follow-up 7cd82d0: updated data sizes in convert_sql tool.
Signed-off-by: Euphy <euphy.raliel@rathena.org>
- Commented some unnecessary log messages.
Bug fixes:
- M_DOPPELGANGER had too much HP. (Hercules 9cd3ec0)
- Huuma_Swirling_Petal should not have an element. (bugreport:9073)
http://rathena.org/board/tracker/issue-9073-huuma-swirling-petal/
Signed-off-by: Euphy <euphy.raliel@rathena.org>
-- Added itemstack check when init autotrader (bugreport:9077)
-- 'getitem' issue, gave unidentified item (bugreport:9075), follow up 62a2813
-- Invalid Def & Mdef reduction of SC_ARMORCHANGE & duration (NPC_STONESKIN & NPC_ANTIMAGIC), should be percentage (bugreport:9076)
-- Invalid Effect duration & Reflect chance of SC_MAGICMIRROR (NPC_MAGICMIRROR)
-- Wrong usage of script_isstring() for script commands: addspiritball, delspiritball, & countspiritball
* Misc:
-- Moved mail send progress to mail.c mail_send() from clif.c clif_parse_Mail_send()
-- Moved hardcoded flood protection when send a mail to 'mail_delay' in misc.conf
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
* Added 'bonus2 bAddItemGroupHealRate' to replace 'bonus2 bAddItemHealRate' for Item Group ID usage. Since MAX_ITEMGROUP is removed, there is no identifier which entry that Item ID or Item Group. Previous check using 'if (type2 < MAX_ITEMGROUP)' (2d53a782fa (diff-08420bab8271f3965304fee42cf4b865L3220))
* bonus2 bAddItemHealRate,iid,n;
* bonus2 bAddItemGroupHealRate,ig,n;
Signed-off-by: Cydh Ramdh <house.bad@gmail.com>
* Fixed Extremity Fist sliding issue getting players stuck in un-walkable cells. (bugreport:8949)
* Updated Cursed Circle against the target behavior.
* Updated Tinder Breaker snap behavior.
* Fixed Crush Strike to work with Auto Counter. (bugreport:6919)
* Fixed Fire Expansion - Acid skill animation.
* Fixed Spider Web not trapping targets. (bugreport:8958)
* Feint Bomb cannot be used on top of Land Protector.
* Fixed Slow Grace movement speed penalty. (bugreport:8946)
* Updated Camouflage to official effects.
* Fixed Beyond of Warcry decreasing critical rather than increasing.
* Fixed Zephyr flee bonus to be a solid 25 increase.
* Decrease Agi, Quagmire, Slow Grace, and Adoramus are no longer affected by SC_SPEEDUP1.
* Fixed Warg Strike to be a weapon attack type. (bugreport:8917)
* Fixed Explosion Spirits to double SP regen tick rather than halve SP regen rate. (bugreport:8936)
* Fixed Millennium Shield, Crush Strike, and Refresh having their cooldown values in the wrong field. (bugreport:8957)
* Cleaned up the status change table for 3rd class skills applying/removing SCB's that should/shouldn't be calculated.
* Updated Saturday Night Fever to official effects.
* Updated Berserk damage formula for renewal versus pre-renewal.
* Fixed Masquerade - Laziness not reducing movement speed.
* Updated the behavior of Frigg's Song.
* Updated Light of Regen, Xeno Slasher, and Silent Breeze skills.
* Updated several Homunculus S skill cast values.
* Deadly Infect will now only spread for short ranged attacks.
* Abundance and Guillotine Cross Poisons no longer overlap.
* Fixed Upheaval and Cursed Soil not giving their respective Max HP bonuses. (bugreport:8951)
* Fixed Solid Skin not giving DEF bonus.
* Fixed Stealth Field to properly hide players.
* Burning now reduces MDEF and has an icon.
* Updated the way skills that give equipment attack are calculated. Thanks to exneval.
* Updated the official item delay message.
* Cleaned up some other issues/left overs.
- Updated Job Stat Bonus tables.
- Updated Renewal Star Gladiator EXP table.
- Small changes to Renewal Stat Point table.
A few item database updates/fixes. (incl. Hercules 0604877)
Signed-off-by: Euphy <euphy.raliel@rathena.org>
