- Removed impossible condition in playBGM script command (from soundeffect).
- Removed unused code (retrieving of a bl) in playBGMall (from soundeffectall).
- Made playBGMall default to 'entire server' when both map name and coordinates are omitted instead of printing an error.
- Updated documentation for playBGM and playBGMall to match actual behavior.
- Removed unused parameter 'bl' in clif_playBGM.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14582 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed exp and drop rates (int) getting truncated (short) when sent to char-server.
- Removed `motd` from `ragsrvinfo` as it is not dynamically changed by the server and as such can be read by 3rd party applications directly from conf/motd.txt if required.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14579 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed a memory leak in getguildmasterid, when the guild leader was not online (bugreport:2743).
- Command getguildmasterid no longer requires the guild leader to be online.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14575 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed many script commands with fixed amount of optional parameters to no longer accept any amount of arguments (faulty declaration).
- Corrected use of dummy parameter for guildopenstorage in scripts.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14573 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Removed clif_guildstoragelist and adjusted clif_storagelist to be able to handle any kind of storage.
- Removed clif_guildstorageitemadded in favor of clif_storageitemadded.
- This also fixes clif_guildstorageitemadded sending old update packet for clients prior 20090603, although packet 0x1c4 (ZC_ADD_ITEM_TO_STORE2) was added before PACKETVER 5 (before 2003-11-03aSakexe, exact addition date unknown) (since r14286).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14571 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Updated description for 'next', 'return', 'attachrid', 'detachrid', 'itemskill', 'openstorage', 'skilleffect', 'donpcevent', 'day', 'night', 'atoi' and 'axtoi' to resolve inaccuracies, missing information or unverified behavior.
- Clarified the purpose of the 'jump_zero' and 'getelementofarray' script commands.
- Fixed 'changebase' stating, that it only works in item scripts (since r2402).
- Fixed 'kickwaitingroomall' stating, that it is not properly linked into the script engine, thus not working (since r13732).
- Updated the description for 'cutin' so that it does not give the impression, that the client is able to display multiple illustrations at once, and being less confusing about the maximum size of illustrations.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14570 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Added documentation for bUnbreakableGarment, bUnbreakableWeapon, bUnbreakableArmor, bUnbreakableHelm, bUnbreakableShield, bUnbreakableShoes, bBreakWeaponRate and bBreakArmorRate (follow up to r485, r915, r1116, r13819).
- Fixed bIgnoreDefEle having race constants listed instead of element constants (since r12804).
- Fixed bUnstripable* not mentioning, that the bonus parameter is meaningless (follow up to r1382).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14561 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Replaced item type literals with their appropriate constants.
- Added itemdb_typename to replace the ugly "BUG!" filled array in @iteminfo (since r1741, follow up to r14550).
- Made the item database parser verify item type for validity.
- Added item type constants to const.txt for use in scripts (getiteminfo).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14551 54d463be-8e91-2dee-dedb-b68131a5f0ec
* Updated the item types for several of the cash item boxes to 18.
* Fixed the Exorcism_Bible bonus, missing {}'s for who knows how long. (bugreport:4342)
* Updated Brasilis monsters stats again, care of Playtester.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14549 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Fixed clif_homskillup using sd before nullpo check (since r9297 and r9307).
- Merged code responsible for disabling pets in GvG and spawning them as per TODO (related r12002).
- Fixed base and job exp not being sent to the client for new connections (follow to r14505).
- Fixed Magnifier (item) and Identify (skill) attempting to identify an item, even when cancel is pressed, causing skill failed message.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14545 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Added documentation for bonus bAutoSpellOnSkill (follow up to r13596).
- Added documentation for script command progressbar (follow up to r14024).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14527 54d463be-8e91-2dee-dedb-b68131a5f0ec
- NOTE: Any MAX_LEVEL (map.h) increase requires at least same increase of SV_READDB_MAX_FIELDS as well.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14526 54d463be-8e91-2dee-dedb-b68131a5f0ec
- Added define for skill entry requirements.
- Reports duplicate skills within same job class.
- Updated comments for skill Berserk in skill_tree.txt, among others because they would cause errors the way they are read now.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@14524 54d463be-8e91-2dee-dedb-b68131a5f0ec