3263 Commits

Author SHA1 Message Date
nanakiwurtz
21cdd8099f Fixed #562
* Thanks to @Playtester

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-08-07 00:09:12 +07:00
nanakiwurtz
1c73d70c4d Item DB Update
* kRO 2015-02-11

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-08-06 01:26:00 +07:00
Cydh Ramdh
e1b658e462 * Item GUID Updates:
* Removed `ENABLE_ITEM_GUID` from src/config/core.h, after long time introduction it's worth to be enabled by default. Just remove all items with GUID flag if want to remove it generates GUID .
  * Implemented client interface to merge the items. Packet struct credits: 856b6f1feb
  * Edited `mergeitem` script command to use the interface, moved the 'old' `mergeitem` to `mergeitem2`.
  * Fixed the behavior to add GUID'd item to inventory in Cash Shop.
  * Updated item_flag.txt for listing `IT_CASH` items (item type 18).
  * NOTE: `IT_CASH` items which defined in item_flag.txt with flag `4`, cannot be merged.
  * NOTE: Please check the packets for older clients. Tested work on 2012-04-10, 2013-08-07 and 2014-10-22.
  * NOTE: Please import 'upgrade_20150804.sql' for MySQL Log Database.
* Removed duplicate clif functions:
  * `clif_msgtable()` -> `clif_msg()`
  * `clif_msgtable_num()` -> `clif_msg_value()`
* Item DB Updates:
  * Indonesia_Box2 (17079) should gives 5x Wing_Of_Butterfly (602).
  * Changed some item types to 18.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-04 20:57:49 +07:00
Atemo
031c522c8a - Fixed F_CashSiegeTele typo in item_db.
- Moved VIP_Third_Class function from other/CashShop_Functions into other/re/CashShop_Functions (only used in re folder).
- Fixed a mistake in quests/quests_nameless.txt blame me  36f337ea41a876ef471bfbb78128e35fa0d9aa56
- re/quest/quests_eclage clean-up and bug fix

Signed-off-by: Atemo <capucrath@gmail.com>
2015-08-04 15:16:56 +02:00
nanakiwurtz
2c3a5eefef Follow up to 356d0a4
* Added Reload shadow equipments

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-08-04 04:05:46 +07:00
Cydh Ramdh
64cb02e5f1 * Introducing Item Reuse Limit Group
* By expanding current item_delay.txt's function to implement official item reuse limit.
  * There's the 3rd optional column, put SC ID value to add reuse limit. The reuse delay will be acknowledged as status change. Ignoring this column will use 'normal' item delay.
  * Added some items to their reuse limit group.
* Item DB Updates
  * Added effect for ASPD_Potion (12684).
  * Added effect and delay for Para_Team_Mark_ (22508).

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-08-03 20:48:35 +07:00
nanakiwurtz
356d0a4bad Item DB Update
* kRO 2015-02-04

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-08-03 01:48:55 +07:00
nanakiwurtz
91b0d27a72 Reverted 224201f
* Thanks to @zackdreaver, @exneval, @cydh

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-08-02 01:43:47 +07:00
nanakiwurtz
ab74684978 Follow up to 568683b
Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-08-02 01:40:41 +07:00
nanakiwurtz
224201f5df Fixed #540
* Thanks to @reunite-ro
* Added slots to Aqua equipments - Thanks to @raynra

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-08-01 15:30:48 +07:00
nanakiwurtz
458772ba2d Fixed #539
* Thanks to @FrFrMako and @cydh

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-31 00:54:46 +07:00
nanakiwurtz
568683ba9c Item DB Update
* kRO 2015-01-28

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-30 03:54:24 +07:00
nanakiwurtz
48c2cf2dec Fixed #534
* Thanks to @FrFrMako and @aleos89

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-29 00:48:26 +07:00
nanakiwurtz
ff96db5cf1 Follow up to 80c486c
Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-28 01:01:31 +07:00
nanakiwurtz
80c486c217 Item DB Update
* kRO 2015-01-21

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-28 00:52:17 +07:00
nanakiwurtz
32d868dcf8 Item DB Update
* kRO 2015-01-14

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-27 01:19:55 +07:00
nanakiwurtz
edc4328728 Item DB Update
* Crimson Weapons changed to [2] - Thanks to @RagnarokNova
* Reverted 3814b3c - RL_P_ALTER to work with all type of bullets again (Refer to commit dd67f9d)

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-26 01:59:55 +07:00
nanakiwurtz
3814b3cc49 [Fix] RL_P_ALTER skill requires Platinum Bullet to cast
* Thanks to @raynra

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-25 13:45:51 +07:00
nanakiwurtz
f8ff16ae80 Item DB Update
* Follow up to 97e51884 + 51f64657

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-24 01:01:26 +07:00
aleos89
ae6b8f2613 Merge branch 'master' of https://github.com/rathena/rathena 2015-07-22 17:47:05 -04:00
aleos89
51f6465709 Bug Fixes
* Fixes #479 - Fixed the unique item ID system not giving new items their unique ID. Blame 7295bdc.
* Fixes #488 - Fixed Water Barrier, Zephyr, and Power of Gaia not being applied to targets walking into the area of effect.
* Fixes #500 - Cursed Circle will now properly release targets if the caster moves out of AREA_SIZE.
* Fixes #501 - Reverberation can be placed an unlimited amount of times. The magic part now only deals neutral damage.
* Fixes #506 - Magnetic Field will now affect others in PvP maps, except for the caster. Thanks to @exneval.
* Fixes #527 - The Roulette item database will not be loaded at all if the feature is disabled.
* Fixed a small typo for 'unitwalk' and 'unitwalkto' script commands.
2015-07-22 17:46:38 -04:00
nanakiwurtz
97e51884ae Item DB Update
* Follow up to 101abad

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-23 02:22:37 +07:00
nanakiwurtz
101abad679 Item DB Update
* kRO 2015-01-07 [New Year Shadow Cube]

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-22 04:06:34 +07:00
nanakiwurtz
effbfc831a Follow up to b706f002
*Thanks to @lelouch22

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-21 03:09:21 +07:00
nanakiwurtz
b706f0026e Item DB Update
* kRO 2015-01-01 [Ore Box IX - New Year Event 2015]

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-21 02:58:45 +07:00
Cydh Ramdh
7a77e6965d Item DB Updates: Lucky Eggs
* Ref: idRO, you can see the item list on its forum. TODO: Rates, and othe package's params

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-07-19 19:46:15 +07:00
nanakiwurtz
fcf7a939a5 Item DB Update
* kRO 2014-12-17 [Christmas Event 2014]

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-19 03:09:52 +07:00
nanakiwurtz
2354038721 Item DB Update
* kRO 2014-12-24 [Calendar Rewards Event]

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-18 02:18:47 +07:00
nanakiwurtz
9e9f5157d6 Fixed #504
* Thanks to @Stolao

Signed-off-by: nanakiwurtz <nanakiwurtz240@gmail.com>
2015-07-07 23:54:23 +07:00
Cydh Ramdh
43792bc775 Merge branch rathena/cleanup/mob_random
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-30 05:10:38 +07:00
Cydh Ramdh
d8da4dd2dc Follow up 9b87ca2b7cd826b42d9a1753da055e2c9e7adf33, added mob_random_db.txt in db/import-tmpl
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-30 05:10:04 +07:00
icxbb-xx
a6118425d9 Another follow up 3d9c6e7
*Fixed #489, Added 'missing' packets for 2014-10-22
2015-06-28 22:45:23 +07:00
Cydh Ramdh
9b87ca2b7c Clean up Monster Random List
* Now using db/[pre-]re/mob_random_db.txt as main file.
* Removed hardcoded limit for random monster group.
* Introduce contants for monster random group, MOBG_*. Usage in `monster` script can be '-1-MOBG_ID' to determines 'summon monster from random summon list'.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-27 13:11:49 +07:00
Cydh Ramdh
474af274a6 A typo in item_package.txt
Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-26 08:57:00 +07:00
Cydh Ramdh
25dbd6eba4 Bug Fixes:
* Fixed #439, Sightrasher doesn't check target's status. Thank @reigneil.
* Fixed #476, Genetic Change Material ignored the created item if stackable or not. Thank @juanfus.
* Fixed compile warnings, unused `num` in getunitdata().
* Fixed wrong return value in BUILDIN_FUNC(questinfo).

Item Updates:
* Added items: C_Flying_Ljosalfar (20099), Protect_Feathers (19024), Sograt_Lucky_Scroll (17598).
* Corrected view_id for C_Coiledup_Snake (20110).
* Follow up 3f549cafb5570a67c046c5078cddbe3a95b772dc, wrong bonuses and revert 18575. Thank @zackdreaver.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-24 22:12:45 +07:00
Cydh Ramdh
44f5925cbf Another follow up 3d9c6e7763c3d257593ba159a18dffc435b5ff06
* Player's Roulette variables aren't saved.
* Fixed client crash because of wrong packets sent by Roulette.
* Changed item
* Added a little check on `char` table for PACKETVER >= 20141016.
* Thank @aleos89, @icxbb-xx

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-24 01:12:32 +07:00
Cydh Ramdh
1278f6bcb3 Another follow up 3d9c6e7763c3d257593ba159a18dffc435b5ff06
* Not commas! Thank @samurairukasu

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-20 12:05:42 +07:00
Cydh Ramdh
e6d5b09b06 Follow up 3d9c6e7763c3d257593ba159a18dffc435b5ff06
* Added 'missing' packets for 2015-10-22 (51).
* Packet keys for packet_ver 50 and 51.
* Fixed memleak from Roulette items.
* Corrected date2version cases.
* Doc update, packet_interserv.txt.

Fixed wrong constant value for bSubSkill and bSubDefEle

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-20 11:59:29 +07:00
aleos89
3d9c6e7763 2014 Client Support
* Implemented the Roulette Game feature.
* Implemented per-character sex change feature.
* More info: https://rathena.org/board/topic/102247-2014-client-support/
- Special thanks to HerculesWS/Hercules@239d480 for the base.
2015-06-19 14:07:34 -04:00
aleos89
583d079b0f Damage Macro Cleanup
* Removed DAMAGE_RATE(), DAMAGE_SUBRATE(), and DAMAGE_ADDRATE() macros.
* Adjusted ATK_RATE*(), ATK_ADDRATE*(), ATK_ADD*(), RE_ALLATK*() macros so we don't produce over complicated ternary operations.
* Adjusted formulas to properly take into account the 'ratio' aspect.
* Cleaned up a few incorrect damage formulas.
* Cleaned up some type casting.
* Implemented renewal effects for Magical Bullet.
2015-06-18 14:01:34 -04:00
Cydh Ramdh
6ad4ed13d1 * Added script command showscript "<message>"{,<GID>}; by using clif_showscript.
* Removed hardcoded message that displayed clif_showscript for `transform` script, replaced its usage for item script by using `showscript`.
* Changed unittalk usage on `F_Cat_Hard_Biscuit` and `F_Rice_Weevil_Bug` function in quests_malangdo.txt.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-19 00:37:48 +07:00
Cydh Ramdh
3f549cafb5 * Revert some changes on 549f491fe6a0f879b5d4b647cac8307b8123e181
* Item bonus correction, ambiguous of 'HP/SP Gain' implementation.
  * Since no implementation for 'drain HP/SP from target', the bonus was removed but makes 'HP/SP Drain' bonuses act like 'drain HP/SP from target' that was totally wrong.
  * This also fixed #471, @AbuGosok
  * Removed HP/SP Gain bonuses that should be use HP/SP Drain:
    * `bonus bHPGainAttack,n;` is same as `bonus bHPDrainValue,n;`.
    * `bonus bSPGainAttack,n;` is same as `bonus bSPDrainValue,n;`.
    * `bonus2 bHPGainAttackRate,x,n;` is same as `bonus2 bHPDrainRate,x,n;`.
    * `bonus2 bSPGainAttackRate,x,n;` is same as `bonus2 bSPDrainRate,x,n;`.
    * `bonus2 bHPGainRaceAttack,r,n;` is same as `bonus2 bHPDrainValueRace,r,n;`.
    * `bonus2 bSPGainRaceAttack,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
    * `bonus2 bHPGainRaceAttackRate,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
    * `bonus2 bSPGainRaceAttackRate,r,n;` is same as `bonus2 bSPDrainValueRace,r,n;`.
    * `bonus bHPGainAttackRate,n;` none.
    * `bonus bSPGainAttackRate,n;` none.
* Fixed #454, thank @jeanroyce
* Item update & correction script from Aegis
  * Wunderkammer renamed to YinYang_Earring (18575).
  * Updated scripts for 7676, 18593, 18595, 18597, 18600, 18601, 18630, 18631, 18636, 18637, 18650, 18650, 18652, 18656, 18659, 18671, 20700, 20724, 28315, 28316, 28317, 28318.
  * Updated script for RCC2013 Combos 28315:28317 and 28316:28318.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-18 19:26:05 +07:00
Cydh Ramdh
1ea4655140 Bug Fixes:
* Fixed #433, fixed SR_TIGERCANNON splash damage.
* Fixed #458, fixed SR_TIGERCANNON behavior as auto-cast by SR_FLASHCOMBO. SR_TIGERCANNON consumes no HP/SP anymore, deal damage WITHOUT the SR_FALLENEMPIRE combo bonus.

Thank @aleos89, @jeanroyce, @SuezoSilver, @firecroll

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-18 01:10:51 +07:00
Cydh Ramdh
b71ed05857 Bug Fixes
* Now coma triggered on every attack types (bugreport:3100)
  * Added bonuses `bonus2 bComaRace,r,n;` and `bonus2 bComaClass,c,n;`, replacing the current usages of `bWeaponComaRace` and `bWeaponComaClass`.
  * This bonus has no effect for GVG and BG monsters.
* Fixed Shockwave Trap (HT_SHOCKWAVE) SP reduction, should be % of MaxSP not % of 'current' SP.
* Fixed #462, failure in `setunitdata` for NPC. Thank a91323, @julia40124009
* Fixed #470, changed SO_ARRULLO target to BL_CHAR.
* Added skill flag INF2_HIT_TRAP (0x40000) to removed hardcoded 'skill that can hit traps'.
  * NOTE: Client-side's factor also determines that skill can be targeted to trap-type skill or not.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-17 00:33:08 +07:00
Cydh Ramdh
5a4cd7426e Bug Fixes:
* Fixed #445, fixed Health Conversion cast time & cooldown.
* Fixed #404:
  * Added new item bonus `bonus2 bSubDefEle,e,x;` to reduce x% damage received from monster with element e.
  * Fixed item script for item 4442 until 4449.
  * Added config `subdef_ele` in conf/battle/items.conf to change bSubDefEle behavior.
* Follow up 111eb0c1c1a048219cb7c908cf8be0b0a24afdde, added state requirement for skill 'elementalspirit2' for skill that need summoned Elemental Spirit and removes it.
* Fixed monster that `is_infinite_defense` ignored Safety Wall && Pneuma effect.
  * Also fixed bugreport:6741.
  * But the effects are still ignored for Emperium when WOE time, and BG monsters in BG Arena (like previous).
* Item Updates:
  * Transformation chance to becomes Atroce as combo of Fidelity_Necklace (2959) and Black_Shiba_Inu_Hat (18756).
  * Transformation chance to becomes Eddga as bonus of King_Tiger_Doll_Hat (5497) and W_King_Tiger_Doll_Hat (18856).
  * Cooldown reduction for skill WL_RECOGNIZEDSPELL in Naqsh (2904).
  * Fixed bonus damage for WS_CARTTERMINATION as combo of Gigant_Helm (19021) and Giant_Axe (1387).
  * Changed `bonus3 bSPDrainRate` to `bonus2 bSPGainAttackRate` and `bonus3 bHPDrainRate` to `bonus2 bHPGainAttackRate` in db/re/pet_db.txt.
* Corrected calculation in `battle_calc_cardfix` for BF_MISC, it's should be `if( cardfix != 1000 )`!.
* Source documentation updates for `battle_calc_cardfix`.
* Typo at MOBID_GUARIDAN1 and MOBID_GUARIDAN2.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-10 12:03:52 +07:00
Cydh Ramdh
851ed7fbee * Fixed #440, forgot to made changes on Pre-Renewal items
* Added item bonus for Sarah Card (4610)

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-09 00:57:52 +07:00
aleos89
2a04748bf4 Fixes #261
* Corrected the skill behavior of Elemental Shield to match official.
- Thanks to @exneval and @Barigas.
2015-06-08 10:53:41 -04:00
Cydh Ramdh
087d911354 Fixed #418, Magma Eruption behavior
* First hit damage: [450 + 50 * skill_lv]%, 90& causing Stun.
* Damage iteration: [800 + 200 * skill_lv] in every 0.5 second for 5 seconds, has chance to inflict Burning efect.
* Thanks to @reigneil and Rytech

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-08 20:28:54 +07:00
Cydh Ramdh
290bd622f3 * Corrected 'rate' value in documentation for autobonuses.
* Follow up 9d389f4de42840b8d05244ad48c214100c7c7d05
  * Reduce the succes rate for 19020 combos and 18934. Because of misread the autobonus doc.
  * Completed bonus for 18934,Fox_Ears_Bell_Ribbon (the critical and long ranged attack bonus)
* Fixed item bonus for 18857,Curupira_Hat, somehow it was using 18856,W_King_Tiger_Doll_Hat effect.

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-08 12:45:48 +07:00
Cydh Ramdh
9d389f4de4 * Item Updates:
* Added items from idRO. Was compared until last idRO patch on June 3rd.
* Follow up 549f491fe6a0f879b5d4b647cac8307b8123e181
  * Type on subskill's array check

Signed-off-by: Cydh Ramdh <cydh@pservero.com>
2015-06-07 22:35:17 +07:00