8031 Commits

Author SHA1 Message Date
Inkfish
96635c8c81 * Update Waterball code due to info updated
* A piece of GX casttime def reduction code I forgot to merge

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13737 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 12:43:37 +00:00
Inkfish
0595535167 * Fixed splash damage from Baphomet Card might miss. [Inkfish]
* Check if group unit is expired before processing it. (bugreport:3054) [Inkfish]
* Fixed Grand Corss outdated behavior (bugreport:1590) [Inkfish]
- use new damage formula
- DEF is reduced to 2/3 during cast time
- block shields switching within attack duration
- monsters don't damage themselves any more
- intervals between hits are 300ms

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13736 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 12:15:14 +00:00
Inkfish
ed83c8817d * Added check on stackable items to 'checkweight' (bugreport:1569, bugreport:2756, bugreport 2994) [Inkfish]
* Fixed flee penalty wasn't applied for battleground and wouldn't be restored on map change [Inkfish]

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13735 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 10:38:00 +00:00
brianluau
9148464d0a - Fixed a "player not attached" error in the Moscovia quest. (bugreport:3041)
- Fixed a race condition in the Arunafeltz quest blocking progress. (bugreport:2782)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13734 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 09:57:15 +00:00
Inkfish
68a983ce4b * Fixed players can pull water from ME cell (follow up to r13730)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13733 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 09:19:58 +00:00
brianluau
8c09676863 - Removed a duplicate entry in item_trade.txt (bugreport:2720)
- Documented more script commands and fixed some typos. 
(bugreport:1554, bugreport:2619, bugreport:2692, bugreport:3034)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13732 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-07 09:07:22 +00:00
brianluau
09914e3ce6 - Fixed an uninitialized variable in r13724. (bugreport:3052)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13731 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-06 23:14:06 +00:00
Inkfish
afaf28a4fa * Players now are allowed to copy the skills the level which is beyond the skill_db max. [Inkfish]
* Fixed some behaviors for Waterball (bugreport:3024) [Inkfish]
- High level Waterball used by players doesn't increase the number of balls.
- Monsters can't pull water from cells with Magnetic Earth.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13730 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-04 13:34:31 +00:00
ultramage
bae7ecf012 Reverted the "The md5() of their kafra code is now stored in #kafra_code$" change from r13728.
Added md5calc to vs8/vs7/vs6 project files.
Applied svn:eol-style to the new sql upgrade file.

Note that if you already applied the sql upgrade, your kafra passwords are lost.
Also note that txt users will still have to implement their own migration code into the kafra scripts since it was omitted in the previous commits.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13729 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-04 12:29:54 +00:00
brianluau
53998c9f3d * Added the md5() script command. (follow up to r13719)
- Changed kafra storage password to be stored as md5 hash in #kafra_code$.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13728 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-04 08:22:53 +00:00
brianluau
1b588722ad - Added a missing zeny check in the Jawaii Bartender. (bugreport:2897)
- Added a missing 'close' in the Mage quest Bookshelf. (bugreport:2873)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13727 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-04 04:24:50 +00:00
jmanfffreak
072ee7a90b Updated item_db.sql and mob_db.sql from recent changes to both. Thanks to Peter once again!
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13726 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-04 01:25:17 +00:00
Playtester
3be7f00bd6 * Snatch now works with all weapons (including bow!)
- range doesn't depend on weapon range anymore and is always 1 even with bows

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13725 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 18:40:04 +00:00
Inkfish
f02ea5bfd1 * Block equipments switching for some skills (bugreport:2900)
- cannot change equipments during Arrow Vulcan's cast time
- cannot change equipments within Desperado's attack duration

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13724 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 10:20:13 +00:00
brianluau
ed034c17f5 - Fixed a variable in refine.txt not being used. (bugreport:2882)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13723 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 05:26:59 +00:00
Inkfish
ffa383b768 *Sorry, something I forgot to merge from my own code.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13722 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 05:05:47 +00:00
brianluau
549f88d633 - Switched the slot enchanter's checks so they come AFTER the final 'next' pause. (bugreport:2664)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13721 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 04:45:11 +00:00
Inkfish
8704a43725 * Players now cannot be revived during pvp respawn delay
* Fix a logical problem on my last commit

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13720 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 04:41:04 +00:00
brianluau
791429c7b0 * Removed the obfuscation of the #kafra_code password. (bugreport:2323)
TODO: add a 'md5()' script command and use that instead.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13719 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 04:30:20 +00:00
Inkfish
a43c9e581b * Fix several npctimer issues (bugreport:1619, bugreport:1730)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13718 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 04:06:53 +00:00
Inkfish
8cd8f32c78 * Fix 'awake' not working (bugreport:2580)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13717 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 02:59:53 +00:00
Inkfish
39b15f37c8 * Do not log damage if it's done by mob itself (bugreport:2933) [Inkfish]
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13716 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-03 02:12:57 +00:00
ultramage
8e3102cfc1 svn:eol-style native for char_sql's int_mercenary code (missing in r13166).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13715 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 23:46:36 +00:00
Playtester
dd635a835a * Spirit of Bard and Dancer now only works for mastered skills (bugreport:3037)
- also fixed an outdated comment in the source code

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13714 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 20:33:41 +00:00
brianluau
a11e789e0a - Fixed some typos in the script command documentation. (bugreport:2547)
- Fixed a misleading message in the custom Job Changer. (bugreport:682)
- Updated some NPC's facing directions. (bugreport:3030)
- Added missing newline in some ShowWarning(). (bugreport:2940)
- Fixed SC_BOSSMAPINFO time being off by 1 minutes (bugreport:3035)
Now, the seconds are rounded up to the next whole minute.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13713 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 20:23:30 +00:00
Playtester
661b7d5b3a Applied timexy's pvp warp name fix (bugreport:2938)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13712 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 11:04:46 +00:00
Playtester
9cae06edcb * Re-added Kasa's missing Shield Reflect (bugreport:3039)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13711 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-05-02 11:01:01 +00:00
Playtester
710ef546a1 * Fixed various typos in the Moscovia quests thanks to Ihades (bugreport:3036)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13710 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-30 21:15:56 +00:00
ultramage
23bd309798 Added missing case SC_ONEHAND (from r5227) and case SC_MERC_QUICKEN (from r13203) to function status_change_start.
Added missing case SC_AURABLADE (from r13693) to function status_change_end.
Added symbolic names for all OPT3 values and replaced the OPT1/OPT2/OPT3/OPTION defines with corresponding enums.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13709 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-30 02:26:04 +00:00
Playtester
c403efcd22 * Incarnation of Morroc (Angel) is now Shadow 1 instead of Holy 1
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13708 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-29 17:25:16 +00:00
Paradox924X
a3f4dde58c Updated ASSIN_Q2 variable range check from < 1 to < 3 to defend against the variable being stuck at an incorrect value of 1 or 2, caused by logging out or pressing cancel on choices list at an inappropriate time thus rendering the player unable to complete the Assassin Quest. Thanks to Chibi for Report.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13707 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-29 08:19:09 +00:00
skotlex
a047b057df - Avoid setting the canwalk delay after being hit if the target is already unable to move.
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13706 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-28 16:48:46 +00:00
Playtester
f48717a3c0 * Removed unnecessary text and fixed a goto in the Hunter Jobquest (bugreport:3014)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13705 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-28 16:28:10 +00:00
Playtester
da39fb587d * A few quest updates due to bugreports
- added a missing close in the Kiel Hyre Quest (bugreport:2885)
- added L0ne_W0lf's Cool Event Corp script + a few fixes to it (bugreport:3019)
- fixed a small typo in rachel.txt (bugreport:3029)

Also I really have to ask the developers again to document all the changes they do on item bonuses!

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13704 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-28 16:16:11 +00:00
Playtester
33911a7594 * Fixed break equipment debuff working on bosses (bugreport:3023)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13703 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-27 16:53:12 +00:00
Playtester
96a0560b11 * Fixed Monster Spiral Pierce not being reduced by Ghostring Card
- it is forced neutral as its a MISC skill for monsters and doesn't take weapon element

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13702 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-25 13:15:45 +00:00
Playtester
7a215a7119 * First attempt to fix up the strip skills, please make sure these fixes work (bugreport:3011)
- the minimum rate of strip skills is now 5% for all levels
- duration of strip skills depends on the dex difference between target and caster and can be reduced to 0
- strip skills can now affect bosses (if duration doesn't get reduced to 0 due to their high dex)
- strip skills do a fixed -25% ATK, -15% DEF, -40% VIT or -40% INT independant of skill level
- autocasting Full Strip has a duration now (if dex is high enough)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13701 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-25 10:40:40 +00:00
ultramage
7c730e4fbd Added an int64 typecast to both the acid demonstration equation (which couldn't handle 1000-ish stats), and the misc damage reduction code (followup to r13694).
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13700 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-25 10:03:23 +00:00
ultramage
7d85415214 Filled in missing SI_ (status icon) names based on official info.
This is just for completeness, since nothing will display on the client until icon files are associated with these ids.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13699 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-25 07:34:47 +00:00
ultramage
ff21daafa2 Correction to some status icons based on official information
- Added SI_S_LIFEPOTION and SI_L_LIFEPOTION and their corresponding new status changes to deal with the fact that Small_Life_Potion and Med_Life_Potion each use a different status icon.
- Left the duplicate SC_HPREGEN status in fof backwards compatibility, but removed its icon.
- Corrected the status icon id for SC_INCCRI from 292 to 295.
- Corrected the status icon id for SC_INCHEALRATE from 293 to 292.
- Added status icons for SC_INCFLEE2, SC_SPCOST_RATE and SC_COMMONSC_RESIST.
- Removed icon from SC_ARMOR_RESIST since officially it is a bonus, not a status, and thus doesn't (and can't) have an icon.
- Renamed the status icon name of SC_ELEMENTALCHANGE from SI_ARMOR_RESIST to SI_ARMOR_PROPERTY.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13698 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-25 07:25:50 +00:00
Playtester
a223cdcba8 Fixed a small typo I did in my last Spiral Pierce fix, thanks to Inkfish for pointing it out (bugreport:3013)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13697 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-24 15:30:24 +00:00
akrus
5a35f1c88e * Lil fix for my last commit. Sorry :)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13696 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-24 12:58:35 +00:00
ultramage
c17d002e07 Renamed Happy Break's status name from SC_TKREST to SC_EARTHSCROLL, since that's its official purpose and it doesn't do anything else.
Also removed the associated SI_TKREST since this status doesn't actually have an icon.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13695 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-24 09:37:08 +00:00
akrus
97f947bb63 * Fixed Acid Demonstration (and probably some other skills) working wrong on high-rate servers (thanks to [Funt] for the idea)
git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13694 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-24 07:56:29 +00:00
ultramage
26736bf2a8 Filled in missing OPT3 change for LK's Aura Blade.
Added comments for OPT3 values 0x100 and 0x20000, which are currently unused.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13693 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-24 05:52:34 +00:00
Playtester
dbb95438b0 * Fixed wrong coordinates of the Prontera Bartender (bugreport:3000)
* Fixed a chat window not being closeable in the Training Grounds (bugreport:3009)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13691 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-23 19:29:52 +00:00
ultramage
22b2671e0f Added length check to functions clif_parse_CreateChatRoom and clif_parse_ChatRoomStatusChange (bugreport:2999).
This prevents a signed/unsigned integer overflow when calling the safestrncpy function.
Also added a note regarding a potential out-of-bounds access issue in these functions.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13690 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-23 15:09:17 +00:00
ultramage
cd82016586 Fixed several occurences of map_freeblock() being used before map_deliddb() (caused by r13503, r13505 and r13508) (bugreport:2959).
This would cause object ids (chatrooms / ground items) to never be removed when DEBUG_MEMMGR was turned on, ultimately causing a 'no free object id' fatal error.

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13689 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-23 14:05:20 +00:00
ultramage
d6ca23f16f Made some adjustments to the land skill code, based on official information:
- Expanded and corrected the land skill view id enum in skill.h
- Renamed UNT_ATTACK_SKILLS to UNT_DUMMYSKILL and UNT_KAENSIN to UNT_KAEN (official terminology)
- changed GS_DESPERADO to use the UNT_DUMMYSKILL view id instead of UNT_KAENSIN (and is it supposed to be a land skill at all?)

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13688 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-23 13:57:22 +00:00
Playtester
87120da836 * Fixed items that use the "AddSPAmount_Action" bonus on aegis
- Guillotine gives you 2 SP each time you attack something with a normal attack (only worked with DemiHuman)
- Tjungkuletti gives you 1 SP each time you attack something with a normal attack (before it drained 1 SP from the target instead)
- Dark Priest Card gives Sages 1 SP each time you attack something with a normal attack (before it was per kill)
- also added the bSPDrainValue bonus to the documentation again

git-svn-id: https://svn.code.sf.net/p/rathena/svn/trunk@13686 54d463be-8e91-2dee-dedb-b68131a5f0ec
2009-04-21 16:59:36 +00:00