Syntax Fix

appveyor.yml

@@ -1,4 +1,5 @@
 image: Visual Studio 2013
+
 # This is the default location, but we put it here for safety reasons, since we use it in our test script
 clone_folder: c:\projects\rathena
 # We do not need the git history for our integration tests
@@ -6,23 +7,43 @@ clone_depth: 50
 version: '{branch}-{build}'
 pull_requests:
   do_not_increment_build_number: true
+  
 environment:
   matrix:
   - VisualStudioVersion: 14.0
     Defines: "\"BUILDBOT\""
   - VisualStudioVersion: 14.0
     Defines: "\"BUILDBOT;PRERE\""
+  - APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
+    VisualStudioVersion: 15.0
+    Defines: "\"CODEANALYSIS\""
+
 platform:
   - Win32
   - x64
+  
 configuration:
   - Debug
 # Disable Release for now, since do not want to have any optimization and have access to debug infos on crash
 #  - Release
+
 matrix:
+  # Minimizing CI time. Should be enough to check guidelines only for one platform.
+  exclude:
+    - platform: x64
+      APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
   fast_finish: true
+  
 build_script:
-- cmd: msbuild rAthena.sln /p:DefineConstants=%Defines%
+- cmd: msbuild rAthena.sln /p:DefineConstants=%Defines% | tee result.txt
+
+after_build:
+- ps: >-
+    if ($env:Defines -eq "CODEANALYSIS") {
+        $warnings =  tail -n 5  result.txt | head -n 1
+        Add-AppveyorMessage -Message $warnings -Category Information
+    }
+
 services: mysql
 test_script:
 - cmd: >-

src/char/char-server.vcxproj

@@ -66,6 +66,10 @@
     <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
   </ImportGroup>
   <PropertyGroup Label="UserMacros" />
+  <PropertyGroup Condition="'$(DefineConstants)'=='CODEANALYSIS'">
+    <CodeAnalysisRuleSet>CppCoreCheckRules.ruleset</CodeAnalysisRuleSet>
+    <RunCodeAnalysis>true</RunCodeAnalysis>
+  </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <LinkIncremental>true</LinkIncremental>
     <OutDir>$(SolutionDir)</OutDir>
@@ -213,4 +217,4 @@
     <Copy SourceFiles="$(SolutionDir)tools\charserv.bat" DestinationFolder="$(SolutionDir)" ContinueOnError="true" Condition="!Exists('$(SolutionDir)charserv.bat')" />
     <Copy SourceFiles="$(SolutionDir)tools\runserver.bat" DestinationFolder="$(SolutionDir)" ContinueOnError="true" Condition="!Exists('$(SolutionDir)runserver.bat')" />
   </Target>
-</Project>
+</Project>

src/login/login-server.vcxproj

@@ -66,6 +66,10 @@
     <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
   </ImportGroup>
   <PropertyGroup Label="UserMacros" />
+  <PropertyGroup Condition="'$(DefineConstants)'=='CODEANALYSIS'">
+    <CodeAnalysisRuleSet>CppCoreCheckRules.ruleset</CodeAnalysisRuleSet>
+    <RunCodeAnalysis>true</RunCodeAnalysis>
+  </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <LinkIncremental>true</LinkIncremental>
     <OutDir>$(SolutionDir)</OutDir>
@@ -187,4 +191,4 @@
     <Copy SourceFiles="$(SolutionDir)tools\logserv.bat" DestinationFolder="$(SolutionDir)" ContinueOnError="true" Condition="!Exists('$(SolutionDir)logserv.bat')" />
     <Copy SourceFiles="$(SolutionDir)tools\runserver.bat" DestinationFolder="$(SolutionDir)" ContinueOnError="true" Condition="!Exists('$(SolutionDir)runserver.bat')" />
   </Target>
-</Project>
+</Project>

src/map/map-server.vcxproj

@@ -66,6 +66,10 @@
     <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
   </ImportGroup>
   <PropertyGroup Label="UserMacros" />
+  <PropertyGroup Condition="'$(DefineConstants)'=='CODEANALYSIS'">
+    <CodeAnalysisRuleSet>CppCoreCheckRules.ruleset</CodeAnalysisRuleSet>
+    <RunCodeAnalysis>true</RunCodeAnalysis>
+  </PropertyGroup>
   <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">
     <LinkIncremental>true</LinkIncremental>
     <OutDir>$(SolutionDir)</OutDir>
@@ -372,5 +376,4 @@
     <Copy SourceFiles="$(SolutionDir)db\import-tmpl\statpoint.txt" DestinationFolder="$(SolutionDir)db\import\" ContinueOnError="true" Condition="!Exists('$(SolutionDir)db\import\statpoint.txt')" />
     <Copy SourceFiles="$(SolutionDir)db\import-tmpl\status_disabled.txt" DestinationFolder="$(SolutionDir)db\import\" ContinueOnError="true" Condition="!Exists('$(SolutionDir)db\import\status_disabled.txt')" />
   </Target>
-</Project>
+</Project>
-