Explicitly closing model file after reading it (#630)

This commit is contained in:
Paul Harter 2022-12-06 17:07:19 +00:00 committed by GitHub
parent 4179ed2475
commit fd8f80c8b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -39,7 +39,8 @@ def _download(url: str, root: str, in_memory: bool) -> Union[bytes, str]:
raise RuntimeError(f"{download_target} exists and is not a regular file")
if os.path.isfile(download_target):
model_bytes = open(download_target, "rb").read()
with open(download_target, "rb") as f:
model_bytes = f.read()
if hashlib.sha256(model_bytes).hexdigest() == expected_sha256:
return model_bytes if in_memory else download_target
else: