From 4ed9dd25c72a3fa0902495cc5dd279c2b61b5428 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Sat, 9 Feb 2019 14:36:17 +0100 Subject: [PATCH 01/15] remove for Yunohost to comply YEP-1.9 --- manifest.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/manifest.json b/manifest.json index d479897..e993e0d 100644 --- a/manifest.json +++ b/manifest.json @@ -3,8 +3,8 @@ "id": "wikijs", "packaging_format": 1, "description": { - "en": "An open source, modern and powerful wiki app built on Node.js, Git and Markdown for YunoHost.", - "fr": "Un wiki moderne et open source propulsé Node.js, Git et Markdown pour YunoHost." + "en": "An open source, modern and powerful wiki app built on Node.js, Git and Markdown.", + "fr": "Un wiki moderne et open source propulsé Node.js, Git et Markdown." }, "version": "2.0.0-beta.13~ynh1", "url": "https://wiki.js.org/", From 5805688d1dd22c29820540b896fe3820bbf75193 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Sun, 10 Feb 2019 05:42:15 +0100 Subject: [PATCH 02/15] force the path --- scripts/change_url | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/change_url b/scripts/change_url index f71fc77..4775517 100644 --- a/scripts/change_url +++ b/scripts/change_url @@ -17,7 +17,7 @@ old_domain=$YNH_APP_OLD_DOMAIN old_path=$YNH_APP_OLD_PATH new_domain=$YNH_APP_NEW_DOMAIN -new_path=$YNH_APP_NEW_PATH +new_path="/" app=$YNH_APP_INSTANCE_NAME From a32941971635b4db984537d09deac1aefab9a591 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 06:05:30 +0100 Subject: [PATCH 03/15] Update to last example_ynh --- check_process | 2 +- conf/nginx.conf | 21 +---------- conf/php-fpm.conf | 93 ++++++++++++++++++++++++++++++---------------- manifest.json | 2 +- scripts/_common.sh | 22 +++++------ scripts/backup | 15 +++++++- scripts/change_url | 11 ++++++ scripts/install | 24 +++++++++++- scripts/remove | 26 +++++++++---- scripts/restore | 34 +++++++++++------ scripts/upgrade | 20 +++++++++- 11 files changed, 183 insertions(+), 87 deletions(-) diff --git a/check_process b/check_process index 29b5d6d..62f1ad6 100644 --- a/check_process +++ b/check_process @@ -26,7 +26,7 @@ Level 3=auto # Level 4: If the app supports LDAP and SSOwat, turn level 4 to '1' and add a link to an issue or a part of your code to show it. # If the app does not use LDAP nor SSOwat, and can't use them, turn level 4 to 'na' and explain as well. -#LDAP not available for now + #LDAP not available for now Level 4=na Level 5=auto Level 6=auto diff --git a/conf/nginx.conf b/conf/nginx.conf index 82527a6..7bb27c3 100644 --- a/conf/nginx.conf +++ b/conf/nginx.conf @@ -2,7 +2,7 @@ location / { # Path to source - # alias __FINALPATH__/ ; + #alias __FINALPATH__/ ; # Force usage of https if ($scheme = http) { @@ -16,25 +16,6 @@ location / { proxy_set_header Connection "upgrade"; proxy_next_upstream error timeout http_502 http_503 http_504; -### Example PHP configuration (remove it if not used) - #index index.php; - - # Common parameter to increase upload size limit in conjunction with dedicated php-fpm file - #client_max_body_size 50M; - - #try_files $uri $uri/ index.php; - #location ~ [^/]\.php(/|$) { - #fastcgi_split_path_info ^(.+?\.php)(/.*)$; - #fastcgi_pass unix:/var/run/php5-fpm-__NAME__.sock; - - #fastcgi_index index.php; - #include fastcgi_params; - #fastcgi_param REMOTE_USER $remote_user; - #fastcgi_param PATH_INFO $fastcgi_path_info; - #fastcgi_param SCRIPT_FILENAME $request_filename; - #} -### End of PHP configuration part - # Include SSOWAT user panel. include conf.d/yunohost_panel.conf.inc; } diff --git a/conf/php-fpm.conf b/conf/php-fpm.conf index 58ab5e2..ab5dca9 100644 --- a/conf/php-fpm.conf +++ b/conf/php-fpm.conf @@ -1,10 +1,11 @@ ; Start a new pool named 'www'. -; the variable $pool can we used in any directive and will be replaced by the +; the variable $pool can be used in any directive and will be replaced by the ; pool name ('www' here) [__NAMETOCHANGE__] ; Per pool prefix ; It only applies on the following directives: +; - 'access.log' ; - 'slowlog' ; - 'listen' (unixsocket) ; - 'chroot' @@ -24,28 +25,35 @@ group = __USER__ ; The address on which to accept FastCGI requests. ; Valid syntaxes are: -; 'ip.add.re.ss:port' - to listen on a TCP socket to a specific address on +; 'ip.add.re.ss:port' - to listen on a TCP socket to a specific IPv4 address on ; a specific port; -; 'port' - to listen on a TCP socket to all addresses on a -; specific port; +; '[ip:6:addr:ess]:port' - to listen on a TCP socket to a specific IPv6 address on +; a specific port; +; 'port' - to listen on a TCP socket to all addresses +; (IPv6 and IPv4-mapped) on a specific port; ; '/path/to/unix/socket' - to listen on a unix socket. ; Note: This value is mandatory. -listen = /var/run/php5-fpm-__NAMETOCHANGE__.sock +listen = /var/run/php/php7.0-fpm-__NAMETOCHANGE__.sock -; Set listen(2) backlog. A value of '-1' means unlimited. -; Default Value: 128 (-1 on FreeBSD and OpenBSD) -;listen.backlog = 128 +; Set listen(2) backlog. +; Default Value: 511 (-1 on FreeBSD and OpenBSD) +;listen.backlog = 511 ; Set permissions for unix socket, if one is used. In Linux, read/write ; permissions must be set in order to allow connections from a web server. Many -; BSD-derived systems allow connections regardless of permissions. +; BSD-derived systems allow connections regardless of permissions. ; Default Values: user and group are set as the running user ; mode is set to 0660 listen.owner = www-data listen.group = www-data ;listen.mode = 0660 - -; List of ipv4 addresses of FastCGI clients which are allowed to connect. +; When POSIX Access Control Lists are supported you can set them using +; these options, value is a comma separated list of user/group names. +; When set, listen.owner and listen.group are ignored +;listen.acl_users = +;listen.acl_groups = + +; List of addresses (IPv4/IPv6) of FastCGI clients which are allowed to connect. ; Equivalent to the FCGI_WEB_SERVER_ADDRS environment variable in the original ; PHP FCGI (5.2.2+). Makes sense only with a tcp listening socket. Each address ; must be separated by a comma. If this value is left blank, connections will be @@ -59,7 +67,13 @@ listen.group = www-data ; - The pool processes will inherit the master process priority ; unless it specified otherwise ; Default Value: no set -; priority = -19 +; process.priority = -19 + +; Set the process dumpable flag (PR_SET_DUMPABLE prctl) even if the process user +; or group is differrent than the master process user. It allows to create process +; core dump and ptrace the process for the pool user. +; Default Value: no +; process.dumpable = yes ; Choose how the process manager will control the number of child processes. ; Possible Values: @@ -96,7 +110,7 @@ pm = dynamic ; forget to tweak pm.* to fit your needs. ; Note: Used when pm is set to 'static', 'dynamic' or 'ondemand' ; Note: This value is mandatory. -pm.max_children = 10 +pm.max_children = 5 ; The number of child processes created on startup. ; Note: Used only when pm is set to 'dynamic' @@ -117,12 +131,12 @@ pm.max_spare_servers = 3 ; Note: Used only when pm is set to 'ondemand' ; Default Value: 10s ;pm.process_idle_timeout = 10s; - + ; The number of requests each child process should execute before respawning. ; This can be useful to work around memory leaks in 3rd party libraries. For ; endless request processing specify '0'. Equivalent to PHP_FCGI_MAX_REQUESTS. ; Default Value: 0 -pm.max_requests = 500 +;pm.max_requests = 500 ; The URI to view the FPM status page. If this value is not set, no URI will be ; recognized as a status page. It shows the following informations: @@ -170,7 +184,7 @@ pm.max_requests = 500 ; ; By default the status page only outputs short status. Passing 'full' in the ; query string will also return status for each pool process. -; Example: +; Example: ; http://www.foo.bar/status?full ; http://www.foo.bar/status?json&full ; http://www.foo.bar/status?html&full @@ -215,7 +229,7 @@ pm.max_requests = 500 ; last request memory: 0 ; ; Note: There is a real-time FPM status monitoring sample web page available -; It's available in: ${prefix}/share/fpm/status.html +; It's available in: /usr/share/php/7.0/fpm/status.html ; ; Note: The value must start with a leading slash (/). The value can be ; anything, but it may not be a good idea to use the .php extension or it @@ -275,7 +289,7 @@ pm.max_requests = 500 ; - %{megabytes}M ; - %{mega}M ; %n: pool name -; %o: ouput header +; %o: output header ; it must be associated with embraces to specify the name of the header: ; - %{Content-Type}o ; - %{X-Powered-By}o @@ -283,7 +297,7 @@ pm.max_requests = 500 ; - .... ; %p: PID of the child that serviced the request ; %P: PID of the parent of the child that serviced the request -; %q: the query string +; %q: the query string ; %Q: the '?' character if query string exists ; %r: the request URI (without the query string, see %q and %Q) ; %R: remote IP address @@ -291,47 +305,51 @@ pm.max_requests = 500 ; %t: server time the request was received ; it can accept a strftime(3) format: ; %d/%b/%Y:%H:%M:%S %z (default) +; The strftime(3) format must be encapsuled in a %{}t tag +; e.g. for a ISO8601 formatted timestring, use: %{%Y-%m-%dT%H:%M:%S%z}t ; %T: time the log has been written (the request has finished) ; it can accept a strftime(3) format: ; %d/%b/%Y:%H:%M:%S %z (default) +; The strftime(3) format must be encapsuled in a %{}t tag +; e.g. for a ISO8601 formatted timestring, use: %{%Y-%m-%dT%H:%M:%S%z}t ; %u: remote user ; ; Default: "%R - %u %t \"%m %r\" %s" ;access.format = "%R - %u %t \"%m %r%Q%q\" %s %f %{mili}d %{kilo}M %C%%" - + ; The log file for slow requests ; Default Value: not set ; Note: slowlog is mandatory if request_slowlog_timeout is set -slowlog = /var/log/nginx/__NAMETOCHANGE__.slow.log - +;slowlog = log/$pool.log.slow + ; The timeout for serving a single request after which a PHP backtrace will be ; dumped to the 'slowlog' file. A value of '0s' means 'off'. ; Available units: s(econds)(default), m(inutes), h(ours), or d(ays) ; Default Value: 0 -request_slowlog_timeout = 5s - +;request_slowlog_timeout = 0 + ; The timeout for serving a single request after which the worker process will ; be killed. This option should be used when the 'max_execution_time' ini option ; does not stop script execution for some reason. A value of '0' means 'off'. ; Available units: s(econds)(default), m(inutes), h(ours), or d(ays) ; Default Value: 0 request_terminate_timeout = 1d - + ; Set open file descriptor rlimit. ; Default Value: system defined value ;rlimit_files = 1024 - + ; Set max core size rlimit. ; Possible Values: 'unlimited' or an integer greater or equal to 0 ; Default Value: system defined value ;rlimit_core = 0 - + ; Chroot to this directory at the start. This value must be defined as an ; absolute path. When this value is not set, chroot is not used. ; Note: you can prefix with '$prefix' to chroot to the pool prefix or one ; of its subdirectories. If the pool prefix is not set, the global prefix ; will be used instead. -; Note: chrooting is a great security feature and should be used whenever +; Note: chrooting is a great security feature and should be used whenever ; possible. However, all PHP paths will be relative to the chroot ; (error_log, sessions.save_path, ...). ; Default Value: not set @@ -347,16 +365,25 @@ chdir = __FINALPATH__ ; Note: on highloaded environement, this can cause some delay in the page ; process time (several ms). ; Default Value: no -catch_workers_output = yes +;catch_workers_output = yes + +; Clear environment in FPM workers +; Prevents arbitrary environment variables from reaching FPM worker processes +; by clearing the environment in workers before env vars specified in this +; pool configuration are added. +; Setting to "no" will make all environment variables available to PHP code +; via getenv(), $_ENV and $_SERVER. +; Default Value: yes +;clear_env = no ; Limits the extensions of the main script FPM will allow to parse. This can ; prevent configuration mistakes on the web server side. You should only limit ; FPM to .php extensions to prevent malicious users to use other extensions to -; exectute php code. +; execute php code. ; Note: set an empty value to allow all extensions. ; Default Value: .php -;security.limit_extensions = .php .php3 .php4 .php5 - +;security.limit_extensions = .php .php3 .php4 .php5 .php7 + ; Pass environment variables like LD_LIBRARY_PATH. All $VARIABLEs are taken from ; the current environment. ; Default Value: clean env @@ -370,7 +397,7 @@ catch_workers_output = yes ; overwrite the values previously defined in the php.ini. The directives are the ; same as the PHP SAPI: ; php_value/php_flag - you can set classic ini defines which can -; be overwritten from PHP call 'ini_set'. +; be overwritten from PHP call 'ini_set'. ; php_admin_value/php_admin_flag - these directives won't be overwritten by ; PHP call 'ini_set' ; For php_*flag, valid values are on, off, 1, 0, true, false, yes or no. diff --git a/manifest.json b/manifest.json index e993e0d..935bdfb 100644 --- a/manifest.json +++ b/manifest.json @@ -13,7 +13,7 @@ "name": "yalh76" }, "requirements": { - "yunohost": ">= 2.7.14" + "yunohost": ">= 3.4" }, "multi_instance": true, "services": [ diff --git a/scripts/_common.sh b/scripts/_common.sh index bb04a03..4a6deae 100644 --- a/scripts/_common.sh +++ b/scripts/_common.sh @@ -1,13 +1,13 @@ #!/bin/bash -# ============= FUTURE YUNOHOST HELPER ============= -# Delete a file checksum from the app settings -# -# $app should be defined when calling this helper -# -# usage: ynh_remove_file_checksum file -# | arg: file - The file for which the checksum will be deleted -ynh_delete_file_checksum () { - local checksum_setting_name=checksum_${1//[\/ ]/_} # Replace all '/' and ' ' by '_' - ynh_app_setting_delete $app $checksum_setting_name -} \ No newline at end of file +#================================================= +# PERSONNAL HELPERS +#================================================= + +#================================================= +# EXPERIMENTAL HELPERS +#================================================= + +#================================================= +# FUTUR OFFICIAL HELPERS +#================================================= diff --git a/scripts/backup b/scripts/backup index 93302d7..2c0e922 100644 --- a/scripts/backup +++ b/scripts/backup @@ -24,6 +24,7 @@ ynh_abort_if_errors #================================================= # LOAD SETTINGS #================================================= +ynh_print_info "Load settings" app=$YNH_APP_INSTANCE_NAME @@ -36,24 +37,28 @@ db_name=$(ynh_app_setting_get $app db_name) #================================================= # BACKUP THE APP MAIN DIR #================================================= +ynh_print_info "Backup the app main dir" ynh_backup "$final_path" #================================================= # BACKUP THE NGINX CONFIGURATION #================================================= +ynh_print_info "Backup nginx configuration" ynh_backup "/etc/nginx/conf.d/$domain.d/$app.conf" #================================================= # BACKUP THE PHP-FPM CONFIGURATION #================================================= +ynh_print_info "Backup php-fpm configuration" -#ynh_backup "/etc/php5/fpm/pool.d/$app.conf" +#ynh_backup "/etc/php/7.0/fpm/pool.d/$app.conf" #================================================= # BACKUP THE POSTGRESQL DATABASE #================================================= +ynh_print_info "Backup the postgresql database" ynh_psql_dump_db "$db_name" > db.sql @@ -62,12 +67,14 @@ ynh_psql_dump_db "$db_name" > db.sql #================================================= # BACKUP LOGROTATE #================================================= +ynh_print_info "Backup logrotate configuration" ynh_backup "/etc/logrotate.d/$app" #================================================= # BACKUP SYSTEMD #================================================= +ynh_print_info "Backup systemd configuration" ynh_backup "/etc/systemd/system/$app.service" @@ -76,3 +83,9 @@ ynh_backup "/etc/systemd/system/$app.service" #================================================= #ynh_backup "/etc/cron.d/$app" + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_print_info "Backup script completed. Please wait for YunoHost to create the backup." diff --git a/scripts/change_url b/scripts/change_url index 4775517..d7732fd 100644 --- a/scripts/change_url +++ b/scripts/change_url @@ -12,6 +12,7 @@ source /usr/share/yunohost/helpers #================================================= # RETRIEVE ARGUMENTS #================================================= +ynh_print_info "Retrieve arguments from the manifest" old_domain=$YNH_APP_OLD_DOMAIN old_path=$YNH_APP_OLD_PATH @@ -24,6 +25,7 @@ app=$YNH_APP_INSTANCE_NAME #================================================= # LOAD SETTINGS #================================================= +ynh_print_info "Load settings" # Needed for helper "ynh_add_nginx_config" final_path=$(ynh_app_setting_get $app final_path) @@ -35,6 +37,7 @@ final_path=$(ynh_app_setting_get $app final_path) #================================================= # CHECK THE SYNTAX OF THE PATHS #================================================= +ynh_print_info "Check the syntax of the paths" test -n "$old_path" || old_path="/" test -n "$new_path" || new_path="/" @@ -62,6 +65,7 @@ fi #================================================= # MODIFY URL IN NGINX CONF #================================================= +ynh_print_info "Modify url in nginx configuration" nginx_conf_path=/etc/nginx/conf.d/$old_domain.d/$app.conf @@ -98,5 +102,12 @@ fi #================================================= # RELOAD NGINX #================================================= +ynh_print_info "Reload nginx" systemctl reload nginx + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_print_info "Change of url completed" diff --git a/scripts/install b/scripts/install index e62b1f0..1e6070c 100644 --- a/scripts/install +++ b/scripts/install @@ -24,6 +24,7 @@ ynh_abort_if_errors #================================================= # RETRIEVE ARGUMENTS FROM THE MANIFEST #================================================= +ynh_print_info "Retrieve arguments from the manifest ..." domain=$YNH_APP_ARG_DOMAIN path_url="/" @@ -47,6 +48,7 @@ app=$YNH_APP_INSTANCE_NAME #================================================= # CHECK IF THE APP CAN BE INSTALLED WITH THESE ARGS #================================================= +ynh_print_info "Validating arguments ..." ### If the app uses nginx as web server (written in HTML/PHP in most cases), the final path should be "/var/www/$app". ### If the app provides an internal web server (or uses another application server such as uwsgi), the final path should be "/opt/yunohost/$app" @@ -62,6 +64,7 @@ ynh_webpath_register $app $domain $path_url #================================================= # STORE SETTINGS FROM MANIFEST #================================================= +ynh_print_info "Store settings from manifest ..." ynh_app_setting_set $app domain $domain ynh_app_setting_set $app path $path_url @@ -74,6 +77,7 @@ ynh_app_setting_set $app is_public $is_public #================================================= # FIND AND OPEN A PORT #================================================= +ynh_print_info "Configuring firewall ..." ### Use these lines if you have to open a port for the application ### `ynh_find_port` will find the first available port starting from the given port. @@ -83,7 +87,7 @@ ynh_app_setting_set $app is_public $is_public # Find a free port port=$(ynh_find_port 8095) # Open this port -#yunohost firewall allow --no-upnp TCP $port 2>&1 +#ynh_exec_warn_less yunohost firewall allow --no-upnp TCP $port ynh_app_setting_set $app port $port #================================================= @@ -107,6 +111,8 @@ ynh_install_app_dependencies redis-server postgresql postgresql-contrib yarn #================================================= # CREATE A POSTGRESQL DATABASE #================================================= +ynh_print_info "Creating a postgresql database ..." + ### Use these lines if you need a database for the application. ### `ynh_mysql_setup_db` will create a database, an associated user and a ramdom password. @@ -127,6 +133,7 @@ ynh_psql_create_db "$db_name" "$db_name" "$db_pwd" #================================================= # DOWNLOAD, CHECK AND UNPACK SOURCE #================================================= +ynh_print_info "Setting up source files ..." ### `ynh_setup_source` is used to install an app from a zip or tar.gz file, ### downloaded from an upstream source, like a git repository. @@ -144,6 +151,7 @@ popd #================================================= # NGINX CONFIGURATION #================================================= +ynh_print_info "Configuring nginx ..." ### `ynh_add_nginx_config` will use the file conf/nginx.conf @@ -153,6 +161,7 @@ ynh_add_nginx_config #================================================= # CREATE DEDICATED USER #================================================= +ynh_print_info "Configuring system user ..." # Create a system user ynh_system_user_create "$app" "$final_path" @@ -160,6 +169,7 @@ ynh_system_user_create "$app" "$final_path" #================================================= # PHP-FPM CONFIGURATION #================================================= +ynh_print_info "Configuring php-fpm ..." ### `ynh_add_fpm_config` is used to set up a PHP config. ### You can remove it if your app doesn't use PHP. @@ -199,6 +209,7 @@ popd #================================================= # SETUP SYSTEMD #================================================= +ynh_print_info "Configuring a systemd service ..." ### `ynh_systemd_config` is used to configure a systemd script for an app. ### It can be used for apps that use sysvinit (with adaptation) or systemd. @@ -228,6 +239,7 @@ ynh_add_systemd_config #chown -R $app: $final_path # Set the app as temporarily public for curl call +ynh_print_info "Configuring ssowat ..." #ynh_app_setting_set $app skipped_uris "/" # Reload SSOwat config #yunohost app ssowatconf @@ -236,6 +248,7 @@ ynh_add_systemd_config #systemctl reload nginx # Installation with curl +#ynh_print_info "Finalizing install ..." #ynh_local_curl "/INSTALL_PATH" "key1=value1" "key2=value2" "key3=value3" # Remove the public access @@ -285,6 +298,7 @@ chown -R "$app":"$app" "$final_path" #================================================= # SETUP LOGROTATE #================================================= +ynh_print_info "Configuring log rotation ..." ### `ynh_use_logrotate` is used to configure a logrotate configuration for the logs of this app. ### Use this helper only if there is effectively a log file for this app. @@ -316,6 +330,7 @@ yunohost service add $app --description "$app daemon for Wiki.js" --log "/var/lo #================================================= # SETUP SSOWAT #================================================= +ynh_print_info "Configuring SSOwat ..." # Make app public if necessary if [ $is_public -eq 1 ] @@ -327,6 +342,7 @@ fi #================================================= # RELOAD NGINX #================================================= +ynh_print_info "Reloading nginx ..." systemctl reload nginx @@ -335,3 +351,9 @@ systemctl reload nginx #================================================= ynh_systemd_action --action=start --service_name=$app --line_match="Redis connection:" + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_print_info "Installation completed" diff --git a/scripts/remove b/scripts/remove index 711688f..4756cc8 100644 --- a/scripts/remove +++ b/scripts/remove @@ -13,13 +13,13 @@ source /usr/share/yunohost/helpers #================================================= # LOAD SETTINGS #================================================= +ynh_print_info "Load settings" app=$YNH_APP_INSTANCE_NAME domain=$(ynh_app_setting_get $app domain) port=$(ynh_app_setting_get $app port) db_name=$(ynh_app_setting_get $app db_name) -db_user=$db_name final_path=$(ynh_app_setting_get $app final_path) #================================================= @@ -31,13 +31,14 @@ final_path=$(ynh_app_setting_get $app final_path) # Remove a service from the admin panel, added by `yunohost service add` if yunohost service status | grep -q $app then - echo "Remove $app service" + ynh_print_info "Remove $app service" yunohost service remove $app fi #================================================= # STOP AND REMOVE SERVICE #================================================= +ynh_print_info "Stop and remove the service" # Remove the dedicated systemd config ynh_remove_systemd_config @@ -45,6 +46,7 @@ ynh_remove_systemd_config #================================================= # REMOVE THE POSTGRESQL DATABASE #================================================= +ynh_print_info "Remove the postgresql database" # Remove a database if it exists, along with the associated user ynh_psql_remove_db "$db_name" "$db_name" @@ -52,6 +54,7 @@ ynh_psql_remove_db "$db_name" "$db_name" #================================================= # REMOVE DEPENDENCIES #================================================= +ynh_print_info "Remove dependencies" # Remove metapackage and its dependencies ynh_remove_app_dependencies @@ -63,9 +66,7 @@ ynh_secure_remove "/etc/apt/sources.list.d/yarn.list" #================================================= # REMOVE APP MAIN DIR #================================================= - -# remove tmp files -ynh_secure_remove "/var/tmp/*" +ynh_print_info "Remove app main directory" # Remove the app directory securely ynh_secure_remove "$final_path" @@ -73,6 +74,7 @@ ynh_secure_remove "$final_path" #================================================= # REMOVE NGINX CONFIGURATION #================================================= +ynh_print_info "Remove nginx configuration" # Remove the dedicated nginx config ynh_remove_nginx_config @@ -80,6 +82,7 @@ ynh_remove_nginx_config #================================================= # REMOVE PHP-FPM CONFIGURATION #================================================= +ynh_print_info "Remove php-fpm configuration" # Remove the dedicated php-fpm config #ynh_remove_fpm_config @@ -87,6 +90,7 @@ ynh_remove_nginx_config #================================================= # REMOVE LOGROTATE CONFIGURATION #================================================= +ynh_print_info "Remove logrotate configuration" # Remove the app-specific logrotate config ynh_remove_logrotate @@ -94,11 +98,12 @@ ynh_remove_logrotate #================================================= # CLOSE A PORT #================================================= +ynh_print_info "Close ports" if yunohost firewall list | grep -q "\- $port$" then - echo "Close port $port" >&2 - yunohost firewall disallow TCP $port 2>&1 + ynh_print_info "Close port $port" + ynh_exec_warn_less yunohost firewall disallow TCP $port fi #================================================= @@ -121,6 +126,13 @@ ynh_secure_remove "/var/log/$app/" #================================================= # REMOVE DEDICATED USER #================================================= +ynh_print_info "Remove the dedicated user" # Delete a system user ynh_system_user_delete $app + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_print_info "Deletion completed" diff --git a/scripts/restore b/scripts/restore index 9541981..bb1add6 100644 --- a/scripts/restore +++ b/scripts/restore @@ -24,6 +24,7 @@ ynh_abort_if_errors #================================================= # LOAD SETTINGS #================================================= +ynh_print_info "Load settings" app=$YNH_APP_INSTANCE_NAME @@ -53,21 +54,14 @@ ynh_restore_file "/etc/nginx/conf.d/$domain.d/$app.conf" #================================================= # RESTORE THE APP MAIN DIR #================================================= +ynh_print_info "Restore the app main directory" ynh_restore_file "$final_path" -#================================================= -# RESTORE THE POSTGRESQL DATABASE -#================================================= - -ynh_install_app_dependencies postgresql postgresql-contrib -ynh_psql_test_if_first_run -ynh_psql_create_db "$db_name" "$db_name" "$db_pwd" -ynh_psql_execute_file_as_root ./db.sql "$db_name" - #================================================= # RECREATE THE DEDICATED USER #================================================= +ynh_print_info "Recreate the dedicated user" # Create the dedicated user (if not existing) ynh_system_user_create "$app" "$final_path" @@ -83,13 +77,14 @@ chown -R "$app":"$app" "$final_path" # RESTORE THE PHP-FPM CONFIGURATION #================================================= -#ynh_restore_file "/etc/php5/fpm/pool.d/$app.conf" +#ynh_restore_file "/etc/php/7.0/fpm/pool.d/$app.conf" #================================================= # SPECIFIC RESTORATION #================================================= # REINSTALL DEPENDENCIES #================================================= +ynh_print_info "Reinstall dependencies" # Define and install dependencies @@ -100,9 +95,19 @@ ynh_install_nodejs 10 ynh_install_app_dependencies redis-server postgresql postgresql-contrib yarn +#================================================= +# RESTORE THE POSTGRESQL DATABASE +#================================================= +ynh_print_info "Restore the postgresql database" + +ynh_psql_test_if_first_run +ynh_psql_create_db "$db_name" "$db_name" "$db_pwd" +ynh_psql_execute_file_as_root ./db.sql "$db_name" + #================================================= # RESTORE SYSTEMD #================================================= +ynh_print_info "Restore the systemd configuration" ynh_restore_file "/etc/systemd/system/$app.service" systemctl enable $app.service @@ -131,8 +136,9 @@ ynh_restore_file "/etc/logrotate.d/$app" #================================================= # RELOAD NGINX AND PHP-FPM #================================================= +ynh_print_info "Reload nginx and php-fpm" -#systemctl reload php5-fpm +#systemctl reload php7.0-fpm systemctl reload nginx #================================================= @@ -147,3 +153,9 @@ chown -R "$app":"$app" "/var/log/$app" #================================================= ynh_systemd_action --action=start --service_name=$app --line_match="Redis connection:" + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_print_info "Restoration completed" diff --git a/scripts/upgrade b/scripts/upgrade index bbb5706..f61089d 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -13,6 +13,7 @@ source /usr/share/yunohost/helpers #================================================= # LOAD SETTINGS #================================================= +ynh_print_info "Load settings" app=$YNH_APP_INSTANCE_NAME @@ -29,6 +30,7 @@ port=$(ynh_app_setting_get $app port) #================================================= # ENSURE DOWNWARD COMPATIBILITY #================================================= +ynh_print_info "Ensure downward compatibility" # Fix is_public as a boolean value if [ "$is_public" = "Yes" ]; then @@ -54,6 +56,7 @@ fi #================================================= # BACKUP BEFORE UPGRADE THEN ACTIVE TRAP #================================================= +ynh_print_info "Backup the app before upgrading" # Backup the current version of the app ynh_backup_before_upgrade @@ -83,6 +86,7 @@ path_url=$(ynh_normalize_url_path $path_url) #================================================= # DOWNLOAD, CHECK AND UNPACK SOURCE #================================================= +ynh_print_info "Download, check and unpack source" # Download, check integrity, uncompress and patch the source from app.src #ynh_setup_source "$final_path" @@ -95,6 +99,7 @@ popd #================================================= # NGINX CONFIGURATION #================================================= +ynh_print_info "Reconfigure nginx" # Create a dedicated nginx config ynh_add_nginx_config @@ -102,6 +107,7 @@ ynh_add_nginx_config #================================================= # UPGRADE DEPENDENCIES #================================================= +ynh_print_info "Upgrade dependencies" curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add - echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list @@ -113,6 +119,7 @@ ynh_install_app_dependencies redis-server postgresql postgresql-contrib yarn #================================================= # CREATE DEDICATED USER #================================================= +ynh_print_info "Create a dedicated user" # Create a dedicated user (if not existing) ynh_system_user_create "$app" "$final_path" @@ -120,6 +127,7 @@ ynh_system_user_create "$app" "$final_path" #================================================= # PHP-FPM CONFIGURATION #================================================= +ynh_print_info "Reconfigure php-fpm" # Create a dedicated php-fpm config #ynh_add_fpm_config @@ -127,7 +135,7 @@ ynh_system_user_create "$app" "$final_path" #================================================= # SPECIFIC UPGRADE #================================================= -# ... +# SETUP #================================================= chown -R "$app":"$app" "$final_path" @@ -162,6 +170,7 @@ ynh_store_file_checksum "$final_path/config.yml" #================================================= # SETUP LOGROTATE #================================================= +ynh_print_info "Reconfigure logrotate" # Use logrotate to manage app-specific logfile(s) ynh_use_logrotate --non-append @@ -169,6 +178,7 @@ ynh_use_logrotate --non-append #================================================= # SETUP SYSTEMD #================================================= +ynh_print_info "Reconfigure systemd" # Create a dedicated systemd config ynh_replace_string "__NODEJS_PATH__" "$nodejs_path" "../conf/systemd.service" @@ -186,6 +196,7 @@ chown -R "$app":"$app" "$final_path" #================================================= # SETUP SSOWAT #================================================= +ynh_print_info "Reconfigure SSOwat" # Make app public if necessary if [ $is_public -eq 1 ] @@ -197,6 +208,7 @@ fi #================================================= # RELOAD NGINX #================================================= +ynh_print_info "Reload nginx" systemctl reload nginx @@ -205,3 +217,9 @@ systemctl reload nginx #================================================= ynh_systemd_action --action=start --service_name=$app --line_match="Redis connection:" + +#================================================= +# END OF SCRIPT +#================================================= + +ynh_print_info "Upgrade completed" From 4d32fdf9f7a5d248b76541d5935d3350de3c656e Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 06:20:51 +0100 Subject: [PATCH 04/15] upgrade to 2.0.0-beta.33 --- README.md | 2 +- manifest.json | 2 +- scripts/install | 2 +- scripts/upgrade | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 0f3ed7b..3b82f94 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ An open source, modern and powerful wiki app built on Node.js, Git and Markdown **Wiki.js is still under development, all features not already implemented.** -**Shipped version:** 2.0.0-beta.13 +**Shipped version:** 2.0.0-beta.33 ## Screenshots diff --git a/manifest.json b/manifest.json index 935bdfb..13a5d7d 100644 --- a/manifest.json +++ b/manifest.json @@ -6,7 +6,7 @@ "en": "An open source, modern and powerful wiki app built on Node.js, Git and Markdown.", "fr": "Un wiki moderne et open source propulsé Node.js, Git et Markdown." }, - "version": "2.0.0-beta.13~ynh1", + "version": "2.0.0-beta.33~ynh1", "url": "https://wiki.js.org/", "license": "AGPL-3.0-or-later", "maintainer": { diff --git a/scripts/install b/scripts/install index 1e6070c..ed8e66f 100644 --- a/scripts/install +++ b/scripts/install @@ -145,7 +145,7 @@ ynh_app_setting_set $app final_path $final_path git clone https://github.com/Requarks/wiki "$final_path" pushd $final_path - git checkout "tags/2.0.0-beta.13" --quiet + git checkout "tags/2.0.0-beta.33" --quiet popd #================================================= diff --git a/scripts/upgrade b/scripts/upgrade index f61089d..ea084d9 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -93,7 +93,7 @@ ynh_print_info "Download, check and unpack source" pushd $final_path git fetch origin - git checkout "tags/2.0.0-beta.13" --quiet + git checkout "tags/2.0.0-beta.33" --quiet popd #================================================= From 5f22ab4da2e87c0091e661aa7a9cfe5d65bb579e Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 11:12:26 +0100 Subject: [PATCH 05/15] Install from tar --- conf/app.src | 4 ++-- scripts/install | 10 ++-------- scripts/restore | 2 +- scripts/upgrade | 9 ++------- 4 files changed, 7 insertions(+), 18 deletions(-) diff --git a/conf/app.src b/conf/app.src index e4dd89f..844e9b8 100644 --- a/conf/app.src +++ b/conf/app.src @@ -1,5 +1,5 @@ -SOURCE_URL=url of app's source -SOURCE_SUM=sha256 checksum +SOURCE_URL=https://github.com/Requarks/wiki/archive/2.0.0-beta.33.tar.gz +SOURCE_SUM=66115e8ae174083eaaec83d1c7f6e026fa97ee53d664e6f1505ebe22b0dfe7f2 SOURCE_SUM_PRG=sha256sum SOURCE_FORMAT=tar.gz SOURCE_IN_SUBDIR=true diff --git a/scripts/install b/scripts/install index ed8e66f..5b0d081 100644 --- a/scripts/install +++ b/scripts/install @@ -106,14 +106,13 @@ echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/source ynh_install_nodejs 10 -ynh_install_app_dependencies redis-server postgresql postgresql-contrib yarn +ynh_install_app_dependencies yarn redis-server postgresql postgresql-contrib build-essential #================================================= # CREATE A POSTGRESQL DATABASE #================================================= ynh_print_info "Creating a postgresql database ..." - ### Use these lines if you need a database for the application. ### `ynh_mysql_setup_db` will create a database, an associated user and a ramdom password. ### The password will be stored as 'mysqlpwd' into the app settings, @@ -141,12 +140,7 @@ ynh_print_info "Setting up source files ..." ynh_app_setting_set $app final_path $final_path # Download, check integrity, uncompress and patch the source from app.src -#ynh_setup_source "$final_path" -git clone https://github.com/Requarks/wiki "$final_path" - -pushd $final_path - git checkout "tags/2.0.0-beta.33" --quiet -popd +ynh_setup_source "$final_path" #================================================= # NGINX CONFIGURATION diff --git a/scripts/restore b/scripts/restore index bb1add6..680d05a 100644 --- a/scripts/restore +++ b/scripts/restore @@ -93,7 +93,7 @@ echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/source ynh_install_nodejs 10 -ynh_install_app_dependencies redis-server postgresql postgresql-contrib yarn +ynh_install_app_dependencies yarn redis-server postgresql postgresql-contrib build-essential #================================================= # RESTORE THE POSTGRESQL DATABASE diff --git a/scripts/upgrade b/scripts/upgrade index ea084d9..326ec40 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -89,12 +89,7 @@ path_url=$(ynh_normalize_url_path $path_url) ynh_print_info "Download, check and unpack source" # Download, check integrity, uncompress and patch the source from app.src -#ynh_setup_source "$final_path" - -pushd $final_path - git fetch origin - git checkout "tags/2.0.0-beta.33" --quiet -popd +ynh_setup_source "$final_path" #================================================= # NGINX CONFIGURATION @@ -114,7 +109,7 @@ echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/source ynh_install_nodejs 10 -ynh_install_app_dependencies redis-server postgresql postgresql-contrib yarn +ynh_install_app_dependencies yarn redis-server postgresql postgresql-contrib build-essential #================================================= # CREATE DEDICATED USER From 33e12a0768ce31e52aa334b8be14cceace5e8155 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 11:16:45 +0100 Subject: [PATCH 06/15] Add pause before installation failed --- scripts/install | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/install b/scripts/install index 5b0d081..fa0576d 100644 --- a/scripts/install +++ b/scripts/install @@ -16,6 +16,7 @@ source /usr/share/yunohost/helpers ynh_clean_setup () { ### Remove this function if there's nothing to clean before calling the remove script. + read -p "Press any key..." ynh_clean_check_starting } # Exit if an error occurs during the execution of the script From 9946441587e9aed34a5e27f03f4d64ee8ab9f549 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 15:11:06 +0100 Subject: [PATCH 07/15] Fix fs.readdirAsync error --- scripts/install | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/install b/scripts/install index fa0576d..c1d060b 100644 --- a/scripts/install +++ b/scripts/install @@ -189,6 +189,13 @@ ynh_print_info "Configuring php-fpm ..." mkdir -p "/var/log/$app" chown -R "$app":"$app" "/var/log/$app" +#================================================= +# PATCH fs.readdirAsync error +#================================================= + +ynh_replace_string "fs.readdirAsync" "fs.readdirSync" "$final_path/server/db/migrator-source.js" +ynh_replace_string "fs.readdirAsync" "fs.readdirSync" "$final_path/server/jobs/purge-uploads.js" + #================================================= # MAKE SETUP #================================================= From e9fae1c614b5ed696608974a35c660708ae70ad4 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 15:36:00 +0100 Subject: [PATCH 08/15] Remove role --- scripts/remove | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/remove b/scripts/remove index 4756cc8..0838765 100644 --- a/scripts/remove +++ b/scripts/remove @@ -50,6 +50,7 @@ ynh_print_info "Remove the postgresql database" # Remove a database if it exists, along with the associated user ynh_psql_remove_db "$db_name" "$db_name" +ynh_psql_drop_user "$db_name" #================================================= # REMOVE DEPENDENCIES From 3f9d638388e72b5ad2b1b9dbec14e93d12e0e9f9 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 16:23:29 +0100 Subject: [PATCH 09/15] Update install steps --- scripts/install | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/install b/scripts/install index c1d060b..091dd31 100644 --- a/scripts/install +++ b/scripts/install @@ -204,8 +204,10 @@ chown -R "$app":"$app" "$final_path" pushd $final_path ynh_use_nodejs - sudo -u $app env PATH=$PATH:$nodejs_path yarn install - sudo -u $app env PATH=$PATH:$nodejs_path npm run build + sudo -u $app env PATH=$PATH yarn cache clean + sudo -u $app env PATH=$PATH yarn --frozen-lockfile --non-interactive + sudo -u $app env PATH=$PATH yarn build + sudo -u $app env PATH=$PATH yarn --production --frozen-lockfile --non-interactive popd #================================================= From 94093ae71e6199fcd03e09f6caff14d405c40270 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 17:15:30 +0100 Subject: [PATCH 10/15] add install step --- scripts/install | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/install b/scripts/install index 091dd31..114e942 100644 --- a/scripts/install +++ b/scripts/install @@ -207,6 +207,7 @@ pushd $final_path sudo -u $app env PATH=$PATH yarn cache clean sudo -u $app env PATH=$PATH yarn --frozen-lockfile --non-interactive sudo -u $app env PATH=$PATH yarn build + sudo -u $app env PATH=$PATH ynh_secure_remove $final_path/node_modules sudo -u $app env PATH=$PATH yarn --production --frozen-lockfile --non-interactive popd From cee9a61ae468e26a6eff9a57a7b715bd5386b8b6 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 17:24:55 +0100 Subject: [PATCH 11/15] Update upgrade script --- scripts/upgrade | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/scripts/upgrade b/scripts/upgrade index 326ec40..7683d8d 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -137,11 +137,13 @@ chown -R "$app":"$app" "$final_path" pushd $final_path ynh_use_nodejs - sudo -u $app env PATH=$PATH:$nodejs_path yarn install - sudo -u $app env PATH=$PATH:$nodejs_path npm run build + sudo -u $app env PATH=$PATH yarn cache clean + sudo -u $app env PATH=$PATH yarn --frozen-lockfile --non-interactive + sudo -u $app env PATH=$PATH yarn build + sudo -u $app env PATH=$PATH ynh_secure_remove $final_path/node_modules + sudo -u $app env PATH=$PATH yarn --production --frozen-lockfile --non-interactive popd - #================================================= # MODIFY A CONFIG FILE #================================================= From f7633b9982e508d89f70d916236cb488e5714f4e Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 17:30:34 +0100 Subject: [PATCH 12/15] Fix install step --- scripts/upgrade | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/upgrade b/scripts/upgrade index 7683d8d..e6e44fc 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -140,7 +140,7 @@ pushd $final_path sudo -u $app env PATH=$PATH yarn cache clean sudo -u $app env PATH=$PATH yarn --frozen-lockfile --non-interactive sudo -u $app env PATH=$PATH yarn build - sudo -u $app env PATH=$PATH ynh_secure_remove $final_path/node_modules + sudo -u $app ynh_secure_remove $final_path/node_modules sudo -u $app env PATH=$PATH yarn --production --frozen-lockfile --non-interactive popd From ee15909a1c25efe09223c7277a87dbf26ccceb70 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 17:31:15 +0100 Subject: [PATCH 13/15] fix install steps --- scripts/install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/install b/scripts/install index 114e942..71f2e3d 100644 --- a/scripts/install +++ b/scripts/install @@ -207,7 +207,7 @@ pushd $final_path sudo -u $app env PATH=$PATH yarn cache clean sudo -u $app env PATH=$PATH yarn --frozen-lockfile --non-interactive sudo -u $app env PATH=$PATH yarn build - sudo -u $app env PATH=$PATH ynh_secure_remove $final_path/node_modules + sudo -u $app ynh_secure_remove $final_path/node_modules sudo -u $app env PATH=$PATH yarn --production --frozen-lockfile --non-interactive popd From df703769fa8abf97a809a3d00574cc57bed1e937 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 18:00:40 +0100 Subject: [PATCH 14/15] Fix install and upgrade steps --- scripts/install | 2 +- scripts/upgrade | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/install b/scripts/install index 71f2e3d..1e7594e 100644 --- a/scripts/install +++ b/scripts/install @@ -207,7 +207,7 @@ pushd $final_path sudo -u $app env PATH=$PATH yarn cache clean sudo -u $app env PATH=$PATH yarn --frozen-lockfile --non-interactive sudo -u $app env PATH=$PATH yarn build - sudo -u $app ynh_secure_remove $final_path/node_modules + ynh_secure_remove $final_path/node_modules sudo -u $app env PATH=$PATH yarn --production --frozen-lockfile --non-interactive popd diff --git a/scripts/upgrade b/scripts/upgrade index e6e44fc..fea0050 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -140,7 +140,7 @@ pushd $final_path sudo -u $app env PATH=$PATH yarn cache clean sudo -u $app env PATH=$PATH yarn --frozen-lockfile --non-interactive sudo -u $app env PATH=$PATH yarn build - sudo -u $app ynh_secure_remove $final_path/node_modules + ynh_secure_remove $final_path/node_modules sudo -u $app env PATH=$PATH yarn --production --frozen-lockfile --non-interactive popd From d8266e9041dfbc93ef8aabe7f3fb6355481564f3 Mon Sep 17 00:00:00 2001 From: yalh76 Date: Mon, 11 Feb 2019 20:26:27 +0100 Subject: [PATCH 15/15] Fix upgrad: adding patch --- scripts/upgrade | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/upgrade b/scripts/upgrade index fea0050..aa11327 100644 --- a/scripts/upgrade +++ b/scripts/upgrade @@ -130,7 +130,14 @@ ynh_print_info "Reconfigure php-fpm" #================================================= # SPECIFIC UPGRADE #================================================= -# SETUP +# PATCH fs.readdirAsync error +#================================================= + +ynh_replace_string "fs.readdirAsync" "fs.readdirSync" "$final_path/server/db/migrator-source.js" +ynh_replace_string "fs.readdirAsync" "fs.readdirSync" "$final_path/server/jobs/purge-uploads.js" + +#================================================= +# MAKE SETUP #================================================= chown -R "$app":"$app" "$final_path"