From ad896cc857b79535dd935f0b28bac3580f09505a Mon Sep 17 00:00:00 2001
From: tschundler <tschundler@google.com>
Date: Wed, 17 Oct 2018 13:52:04 -0700
Subject: [PATCH] Update tickers.go to not leak goroutine

The code in the example will leak a goroutine because ticker.Stop() does not close ticker.C.
There is no way to close ticker.C, so `for _ := range ticker` is not a generally safe example for using a ticker.
---
 examples/tickers/tickers.go | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/examples/tickers/tickers.go b/examples/tickers/tickers.go
index ef55c97..3547648 100644
--- a/examples/tickers/tickers.go
+++ b/examples/tickers/tickers.go
@@ -16,9 +16,16 @@ func main() {
     // `range` builtin on the channel to iterate over
     // the values as they arrive every 500ms.
     ticker := time.NewTicker(500 * time.Millisecond)
+    done := make(chan bool)
+
     go func() {
-        for t := range ticker.C {
-            fmt.Println("Tick at", t)
+        for {
+            select {
+            case <-done:
+                return
+            case t := <-ticker.C:
+                fmt.Println("Tick at", t)
+            }
         }
     }()
 
@@ -27,5 +34,6 @@ func main() {
     // channel. We'll stop ours after 1600ms.
     time.Sleep(1600 * time.Millisecond)
     ticker.Stop()
+    done <- true
     fmt.Println("Ticker stopped")
 }