From 3b153c7d805c3ed5374923480f42b7561af655b2 Mon Sep 17 00:00:00 2001 From: Maciek Niemczyk Date: Mon, 17 Jun 2019 14:25:41 +0200 Subject: [PATCH] according to https://www.joeshaw.org/dont-defer-close-on-writable-files/ one should not use defer file.close(), its a bad pattern --- examples/defer/defer.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/defer/defer.go b/examples/defer/defer.go index 06c827f..8d1c3ed 100644 --- a/examples/defer/defer.go +++ b/examples/defer/defer.go @@ -40,5 +40,9 @@ func writeFile(f *os.File) { func closeFile(f *os.File) { fmt.Println("closing") - f.Close() + err := f.Close() + if err != nil { + _, _ = fmt.Fprintf(os.Stderr, "error: %v\n", err) + os.Exit(1) + } }