From a334236cc3f6d484a955fa1f56e95760a929953c Mon Sep 17 00:00:00 2001 From: Mark McGranaghan Date: Tue, 27 Dec 2016 12:53:27 -0800 Subject: [PATCH] Remove todos We are not planning to address them at this point. --- examples/multiple-return-values/multiple-return-values.go | 3 --- examples/multiple-return-values/multiple-return-values.hash | 4 ++-- examples/timeouts/timeouts.go | 2 -- examples/timeouts/timeouts.hash | 4 ++-- public/multiple-return-values | 2 +- public/timeouts | 2 +- tools/generate.go | 4 ---- 7 files changed, 6 insertions(+), 15 deletions(-) diff --git a/examples/multiple-return-values/multiple-return-values.go b/examples/multiple-return-values/multiple-return-values.go index 920403c..9b970a6 100644 --- a/examples/multiple-return-values/multiple-return-values.go +++ b/examples/multiple-return-values/multiple-return-values.go @@ -25,6 +25,3 @@ func main() { _, c := vals() fmt.Println(c) } - -// todo: named return parameters -// todo: naked returns diff --git a/examples/multiple-return-values/multiple-return-values.hash b/examples/multiple-return-values/multiple-return-values.hash index f746983..0e13a88 100644 --- a/examples/multiple-return-values/multiple-return-values.hash +++ b/examples/multiple-return-values/multiple-return-values.hash @@ -1,2 +1,2 @@ -9e0a75102d83565fefbf1893728b15633dc44a2c -LrDt1Wah0M +5063ce3d3c70c6bd70f4b709de24bb93d0f24e0c +chwFmr5dG1 diff --git a/examples/timeouts/timeouts.go b/examples/timeouts/timeouts.go index b985eb8..2f545f2 100644 --- a/examples/timeouts/timeouts.go +++ b/examples/timeouts/timeouts.go @@ -46,5 +46,3 @@ func main() { fmt.Println("timeout 2") } } - -// todo: cancellation? diff --git a/examples/timeouts/timeouts.hash b/examples/timeouts/timeouts.hash index 3981e0e..ae18eff 100644 --- a/examples/timeouts/timeouts.hash +++ b/examples/timeouts/timeouts.hash @@ -1,2 +1,2 @@ -48dc2824c813ec9195866592e4bed211fa9a5098 -CoBnJiRyx3 +5ea69771a4d4c6286fd587f91e03cd386f77cada +NR2GHXUKeM diff --git a/public/multiple-return-values b/public/multiple-return-values index 0feed15..fc2a627 100644 --- a/public/multiple-return-values +++ b/public/multiple-return-values @@ -41,7 +41,7 @@ to return both result and error values from a function.

- +
package main
 
diff --git a/public/timeouts b/public/timeouts index 798a75c..d8f346d 100644 --- a/public/timeouts +++ b/public/timeouts @@ -42,7 +42,7 @@ elegant thanks to channels and select.

- +
package main
 
diff --git a/tools/generate.go b/tools/generate.go index 351c8c2..6bb3184 100644 --- a/tools/generate.go +++ b/tools/generate.go @@ -116,7 +116,6 @@ func debug(msg string) { } var docsPat = regexp.MustCompile("^\\s*(\\/\\/|#)\\s") -var todoPat = regexp.MustCompile("\\/\\/ todo: ") var dashPat = regexp.MustCompile("\\-+") type Seg struct { @@ -161,9 +160,6 @@ func parseSegs(sourcePath string) ([]*Seg, string) { lastSeen = "" continue } - if todoPat.MatchString(line) { - continue - } matchDocs := docsPat.MatchString(line) matchCode := !matchDocs newDocs := (lastSeen == "") || ((lastSeen != "docs") && (segs[len(segs)-1].Docs != ""))