Maciek Niemczyk
3b153c7d80
according to https://www.joeshaw.org/dont-defer-close-on-writable-files/ one should not use defer file.close(), its a bad pattern
2019-06-17 14:25:41 +02:00
Mark McGranaghan
46fe6bc6cb
Merge pull request #247 from C-Ross/fixEnvarReference
...
Fix an incorrect textual reference
2019-06-13 21:40:18 -04:00
Ross Eskridge
d18911d3e8
Generate html with textual reference fix
2019-06-13 13:59:54 +00:00
Ross Eskridge
39cc92ae7f
Fix forward reference in command line flags text
...
Text in command line flags referenced environment variables, moved that
to subcommands to read correctly.
2019-06-12 20:18:46 +00:00
Eli Bendersky
1be2c1c910
Add Walk
2019-06-08 11:20:00 -07:00
Eli Bendersky
ee8c401ac3
Update examples/directories/directories.go
...
Co-Authored-By: Mark McGranaghan <mmcgrana@gmail.com>
2019-06-08 11:11:58 -07:00
Mark McGranaghan
bab32db83f
Merge branch 'buildprogress'
2019-06-08 11:23:23 -04:00
Mark McGranaghan
bee52f22ce
Change word
2019-06-08 11:21:40 -04:00
Eli Bendersky
447d77234f
Add directories example
2019-06-08 06:11:13 -07:00
Eli Bendersky
70cb6ffb45
Add printout when sending a request to play.golang.org
2019-06-07 06:26:27 -07:00
Eli Bendersky
cb0f0a3056
Tweak logged text
2019-06-07 06:17:26 -07:00
Eli Bendersky
cdbdae9715
Do progress reporting during parsing/processing stage, not HTML render stage
2019-06-07 06:12:30 -07:00
Eli Bendersky
6eae6fe9b7
Adjust comments in the new file paths sample
2019-06-06 06:20:59 -07:00
Eli Bendersky
52be303a71
File Paths example
2019-06-06 06:17:45 -07:00
Eli Bendersky
d34c7ac64e
Rewrite verbose() to work in OSX bash
2019-06-06 05:26:20 -07:00
Mark McGranaghan
f2802c4c93
Merge pull request #239 from mmcgrana/readmetravis
...
Add Travis link to README
2019-06-05 18:29:01 -07:00
Eli Bendersky
09dec4f4fc
Reformat the travis link to render properly
2019-06-05 10:27:39 -07:00
Eli Bendersky
2438aea95f
Move the travis link / build status around
2019-06-05 10:25:14 -07:00
Eli Bendersky
3d0bde4f8f
Add verbose guard in parseExamples
2019-06-05 10:17:09 -07:00
Eli Bendersky
5487e88919
Add VERBOSE option to tools/build and generate.go
...
VERBOSE will be set by TRAVIS (but can also be set by user to diagnose slow
builds). Using an env var so that it automatically propagates to all the
sub-scripts and tools without having to pass it through tools/build explicitly.
2019-06-05 10:15:13 -07:00
Eli Bendersky
82699a6deb
Add Travis link to README
2019-06-05 09:57:37 -07:00
Mark McGranaghan
9027bb86cd
Merge remote-tracking branch 'github/travis1'
2019-06-05 08:57:58 -07:00
Eli Bendersky
c22108bc89
Comment
2019-06-05 06:37:51 -07:00
Eli Bendersky
2e3c6d3f51
Initial Travis file for running CI
...
Each run invokes tools/build, which already returns a non-zero status on errors
and zero when OK.
Updates #237
2019-06-04 20:32:43 -07:00
Eli Bendersky
baf22e84e7
Move <img> for play.golang.org to separate line in the template
...
This will make future diffs easier to read because code changes modify the
hash/link, but the image data stays the same.
Note that there are whitespace diffs in the generated files where there
is no image. This is because there was a stray tab in the template before,
and now it's replaced by spaces.
Fixes #235
2019-06-04 19:03:37 -07:00
Mark McGranaghan
e39e5b3889
Merge branch 'fixread'
2019-06-04 16:41:51 -07:00
Mark McGranaghan
e862063d82
Merge remote-tracking branch 'github/nopointer'
2019-06-04 16:33:20 -07:00
Eli Bendersky
f99adfc228
Keep the two structs together for presentation
2019-06-04 16:27:55 -07:00
Eli Bendersky
f4729c8ed2
Fix reading-files example to not show out-of-bounds bytes
...
Fixes #165
2019-06-04 16:08:22 -07:00
Eli Bendersky
6d8aa9b50a
Remove pointers from the stateful-goroutines example.
...
The pointers are unnecessary and make the sample slightly more
complicated.
Fixes #221
2019-06-04 15:56:59 -07:00
Mark McGranaghan
d1886245ba
Presentation tweaks
2019-06-04 07:50:21 -07:00
Mark McGranaghan
573cb47955
Rebuild for tabs
2019-06-04 07:44:57 -07:00
Eli Bendersky
fab09ef735
Minor rewording
2019-06-04 07:44:39 -07:00
Eli Bendersky
973da6773f
HTTP servers sample
2019-06-04 07:44:39 -07:00
Mark McGranaghan
552611bc1c
Add periods
2019-06-04 07:36:05 -07:00
Mark McGranaghan
c6a401d2a3
Rebuild subcommands for tabs
2019-06-04 07:32:51 -07:00
Eli Bendersky
7c160440be
Use tabs as the canonical source indentation in git
...
Space conversion is done during generation only. Fixes #192
2019-06-04 07:30:58 -07:00
Mark McGranaghan
1699ad1c45
Merge branch 'subcommand'
2019-06-04 07:27:14 -07:00
Mark McGranaghan
af633e81f3
Presentation tweak
2019-06-04 07:25:49 -07:00
Mark McGranaghan
c00fa9dc79
Rebuild for apple
2019-06-04 05:49:54 -07:00
Eli Bendersky
738fc184ef
Subcommands example
2019-06-04 05:48:59 -07:00
Mark McGranaghan
f2f5af3690
Fix output
2019-06-03 18:35:36 -07:00
Mark McGranaghan
fe60e81e4e
Merge branch 'httpclient-sample'
2019-05-31 13:02:17 -07:00
Mark McGranaghan
2d9b204571
Use "conversion" instead of "cast", per spec
...
Closes #200
2019-05-31 12:45:56 -07:00
Mark McGranaghan
41d6630bdd
Normalize code fragment typography
...
Per convention, code fragments get monotype and methods in the text
don't get parens or parameters.
2019-05-31 12:19:49 -07:00
Mark McGranaghan
c209145948
"An HTTP"
...
This could go either way, but my pronunciation of HTTP dictates "an" (:
https://www.quora.com/A-http-or-an-http-which-is-the-correct-grammatical-usage
2019-05-31 12:14:54 -07:00
Mark McGranaghan
60bed1aa0d
Update whitespace so comment aligns with relevant code
2019-05-31 12:11:24 -07:00
Mark McGranaghan
d2d9a54208
Use fewer words in HTTP Clients intro
...
"out of the box" is implied by "standard library".
2019-05-31 12:10:33 -07:00
Eli Bendersky
dfcaebd536
Basic HTTP client sample
2019-05-31 12:08:57 -07:00
Mark McGranaghan
d351883ab8
Fix whitespace and build
2019-05-31 12:06:44 -07:00