Mirroristas/CommunitySolidServer
2
0
Fork 0
mirror of https://github.com/CommunitySolidServer/CommunitySolidServer.git synced 2024-10-03 14:55:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Simplify test mocks.

Browse Source
This commit is contained in:
Ruben Verborgh
2022-03-24 17:19:42 +00:00
committed by Joachim Van Herwegen
parent 4a37f8c879
commit e4688e12a1
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/unit/util/locking/RedisResourceLocker.test.ts
View File

@@ -1,5 +1,5 @@
import { EventEmitter } from 'events';
import * as Redis from 'ioredis';
import Redis from 'ioredis';
import Redlock from 'redlock';
import type { Lock } from 'redlock';
import * as LogUtil from '../../../../src/logging/LogUtil';
@@ -27,14 +27,11 @@ jest.useFakeTimers();
describe('A RedisResourceLocker', (): void => {
let locker: RedisResourceLocker;
const identifier = { path: 'http://test.com/foo' };
let newRedisSpy: jest.SpyInstance;
beforeEach(async(): Promise<void> => {
jest.clearAllMocks();
redlock.removeAllListeners();
newRedisSpy = jest.spyOn(Redis, 'default').mockImplementation(jest.fn());
locker = new RedisResourceLocker([ '6379' ]);
});
@@ -180,9 +177,9 @@ describe('A RedisResourceLocker', (): void => {
jest.clearAllMocks();
const clientStrings = [ '6379', '127.0.0.1:6378' ];
locker = new RedisResourceLocker(clientStrings);
expect(newRedisSpy).toHaveBeenCalledTimes(2);
expect(newRedisSpy).toHaveBeenCalledWith(6379, undefined);
expect(newRedisSpy).toHaveBeenCalledWith(6378, '127.0.0.1');
expect(Redis).toHaveBeenCalledTimes(2);
expect(Redis).toHaveBeenCalledWith(6379, undefined);
expect(Redis).toHaveBeenCalledWith(6378, '127.0.0.1');
});
it('errors when invalid string is passed.', async(): Promise<void> => {
@@ -191,7 +188,7 @@ describe('A RedisResourceLocker', (): void => {
const clientStrings = [ 'noHostOrPort' ];
expect((): any => new RedisResourceLocker(clientStrings))
.toThrow('Invalid data provided to create a Redis client: noHostOrPort');
expect(newRedisSpy).toHaveBeenCalledTimes(0);
expect(Redis).toHaveBeenCalledTimes(0);
});
});