Mirroristas/bigchaindb
2
0
Fork 0
mirror of https://github.com/bigchaindb/bigchaindb.git synced 2024-10-13 13:34:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Problem: TODO for test_configure_bigchaindb_logging suggest only fixing the test, when removing is also an option

Browse Source 
Solution: Changed the wording on the TODO to suggest fix or remove
This commit is contained in:
z-bowen 2018-08-30 10:39:02 +02:00
parent 9896888e16
commit 8ff6c919b2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/commands/test_utils.py
View File

@ -75,7 +75,8 @@ def test_configure_bigchaindb_logging(log_level):
# TODO: See following comment: # TODO: See following comment:
# This is a dirty test. If a test *preceding* this test makes use of the logger, and then another test *after* this # This is a dirty test. If a test *preceding* this test makes use of the logger, and then another test *after* this
# test also makes use of the logger, somehow we get logger.disabled == True, and the later test fails. We need to # test also makes use of the logger, somehow we get logger.disabled == True, and the later test fails. We need to
# engineer this somehow to leave the test env in the same state as it finds it. # either engineer this somehow to leave the test env in the same state as it finds it, or make an assessment
# whether or not we even need this test, and potentially just remove it.
from bigchaindb.commands.utils import configure_bigchaindb from bigchaindb.commands.utils import configure_bigchaindb